From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C367C8F7D; Sun, 9 Nov 2025 13:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762694178; cv=none; b=mSl2LaBKggdTPTdZfyODjlKqSBv9bcb2bukMen8IbFA9CJ0ISAmbi06950fpyCtj0sdIrsTC+l6hu9wTSZPtNJuAF2WskkLIIgT0LPvKWi96uQUimhrIxIg6oIqRZRP2Hc6rHtoh1R2KeR2YqAw2VKZ9SBqC0oIbNtvnwYGO+Hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762694178; c=relaxed/simple; bh=3KRQry2rN5yBVh+iljFYmxN/MaQaDt+KLgcTKHl1+9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KoIAIeKsGgHSTIn1Vz/SuvMNV8MT/8+TrzpJE8dNvY1F84CkOI40aVXAiZm++j7P7h4nB6BtKJj4pEJZPGheVbGEnVWd5LHFg7EWKICixohqUsDuz04O+kkkj2osi464rmRa2s6x1+PDdMO7VDRbM7Ktic672h/rm85XzDPhe9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oQiplyU/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oQiplyU/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E491CC4CEF8; Sun, 9 Nov 2025 13:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762694178; bh=3KRQry2rN5yBVh+iljFYmxN/MaQaDt+KLgcTKHl1+9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oQiplyU/LbwRxAbtCRePLvDcPxvLpQS2NfkS5btfCzb0bsuWcEEtiKySAoSA1WW8e 0TNN6r5KqR/ObQrunoaH00KsxTgy4sZ0KRO1pVsuZ7jGPPsPtmceUkYzWxOYJQxPVD 6uAslhPWfpwHneONieUUjT6k66NnZKuM7SavY0U/wsGUk1UFXhDLATtJE7XXx/pNuq 7ag1MYZC05SiY92HQxeC4b8g3YK7lWRGU8N4yhCVcX13FdIfTa1OWiPTsZeTPJYfo5 JiQe5iy0AlZj6f35/kqemnNLbA8z+9js+iE/lstC3Tzvi5pxXnTDQjErfVgoN6/Fh3 8OSvTMlZiidzg== Date: Sun, 9 Nov 2025 13:16:14 +0000 From: Conor Dooley To: Lakshmi Patil Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: Lakshmi Patil: dt-bindings: misc: Add Xilinx AXI FIFO MM S controller binding Message-ID: <20251109-annually-nifty-42c9530b4f07@spud> References: <20251109033751.334711-1-lakshmi16796@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H86Bpw1wREfxQN0S" Content-Disposition: inline In-Reply-To: <20251109033751.334711-1-lakshmi16796@gmail.com> --H86Bpw1wREfxQN0S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 09, 2025 at 09:07:49AM +0530, Lakshmi Patil wrote: > Warning found by checkpatch.pl script. What? This commit message and subject is so weird that it looks like it was generated by some of LLM hallucination. >=20 > Add the Device Tree binding documentation for the Xilinx AXI FIFO MM S > (AXI Memory Mapped to Stream) controller. The core provides a FIFO-based > interface between AXI Memory-Mapped and AXI-Stream domains and is used in > Xilinx SoC and FPGA designs to offload DMA-style data transfers. There's already a binding in text form for this device. Your binding below contains almost none of the required properties in the text binding, nor does it actually remove the existing text binding. Did you just not check to see if it was already documented, or what's going on here? I am very confused to be honest. pw-bot: changes-requested Cheers, Conor. >=20 > The binding describes the required properties such as compatible string, > register region, clock, reset, and interrupt line. >=20 > Signed-off-by: Lakshmi Patil > --- > .../bindings/misc/xlnx,axi-fifo-mm-s.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/xlnx,axi-fifo-= mm-s.yaml >=20 > diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.ya= ml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml > new file mode 100644 > index 000000000000..d02a7cf9ac0f > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/xlnx,axi-fifo-mm-s.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx AXI FIFO MM S Controller > + > +maintainers: > + - Lakshmi lakshmi16796@gmail.com > + > +description: | > + The Xilinx AXI FIFO Memory Mapped to Stream (MM2S / S2MM) core provides > + a FIFO-based interface for moving data between AXI Memory-Mapped and > + AXI-Stream domains. It supports both transmit and receive paths > + and is typically used to offload DMA-style data transfers in > + Xilinx SoCs or FPGA designs. > + > +properties: > + compatible: > + enum: > + - xlnx,axi-fifo-mm-s-4.1 > + > + reg: > + maxItems: 1 > + description: > + Base address and size of the AXI FIFO MM S register space. > + > + interrupts: > + maxItems: 1 > + description: > + Interrupt line from the AXI FIFO block, if available. > + > + clocks: > + maxItems: 1 > + description: > + Reference clock for the AXI FIFO interface. > + > + clock-names: > + const: s_axi_aclk > + > + resets: > + maxItems: 1 > + description: > + Reset line for the AXI FIFO interface. > + > + reset-names: > + const: s_axi_aresetn > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + > +additionalProperties: true > + > +examples: > + - | > + axi_fifo_mm_s@43c00000 { > + compatible =3D "xlnx,axi-fifo-mm-s-4.1"; > + reg =3D <0x43c00000 0x10000>; > + interrupts =3D <0 59 4>; > + clocks =3D <&clkc 15>; > + clock-names =3D "s_axi_aclk"; > + resets =3D <&rstc 0>; > + reset-names =3D "s_axi_aresetn"; > + }; > + > --=20 > 2.34.1 >=20 --H86Bpw1wREfxQN0S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaRCT/gAKCRB4tDGHoIJi 0qbhAQDVf3sKkI6hwzIWM62RyARJKS8IANDqSwipdXd4qDmtiwD+NhUFDv9mLofo Ls6JUBUdgFPO4W/AMduv3e/drTji4QU= =aB42 -----END PGP SIGNATURE----- --H86Bpw1wREfxQN0S--