Re: [PATCH v4 09/12] iio: dac: ad5446: Make use of the cleanup helpers

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 4 Nov 2025 20:23:09 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Nov 04, 2025 at 03:35:14PM +0000, Nuno Sá via B4 Relay wrote:
> 
> > Use the auto unlocking helpers from cleanup.h. Allows for some code
> > simplification.
> > 
> > While at it, don't use the ternary operator in
> > ad5446_write_dac_powerdown() and add an helper function to write the DAC
> > code. The reason for the function was purely to avoid having to use
> > unreachable().  
> 
> ...
> 
> > +static int ad5446_write_dac_raw(struct iio_dev *indio_dev,
> > +				const struct iio_chan_spec *chan,
> > +				int val)
> > +{
> > +	struct ad5446_state *st = iio_priv(indio_dev);  
> 
> > +	if (val >= (1 << chan->scan_type.realbits) || val < 0)
> > +		return -EINVAL;  
> 
> BIT() ?
> in_range() ?
> 
It's a code move, so I'd rather that change if made is a separate patch.
BIT() is fine, but in_range() is a bit odd when the start is 0.

Hence applied this as it stands.
> > +	val <<= chan->scan_type.shift;
> > +	guard(mutex)(&st->lock);
> > +
> > +	st->cached_val = val;
> > +	if (st->pwr_down)
> > +		return 0;
> > +
> > +	return st->chip_info->write(st, val);
> > +}  
> 
>