Re: [PATCH v4 10/12] iio: dac: ad5446: Refactor header inclusion

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 4 Nov 2025 20:24:19 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Nov 04, 2025 at 03:35:15PM +0000, Nuno Sá via B4 Relay wrote:
> > 
> > Make sure include files are given in alphabetical order and that we include
> > the ones that were missing and remove the ones we don't really use.  
> 
> ...
> 
> > +#include <linux/export.h>
> >  #include <linux/iio/iio.h>
> > +#include <linux/kstrtox.h>
> > +#include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/regulator/consumer.h>
> > +#include <linux/sysfs.h>  
> 
> Most likely the types.h is missing and maybe more...
> 

Looks like types.h belongs only in the header.

FWIW I ran iwyu against this with my usual iio.imp file
(shared previously on list)

drivers/iio/dac/ad5446.h should add these lines:
#include <linux/compiler.h>  // for __aligned
#include <linux/minmax.h>    // for __cmp_op_max
#include <linux/stddef.h>    // for NULL

drivers/iio/dac/ad5446.h should remove these lines:

The full include-list for drivers/iio/dac/ad5446.h:
#include <linux/bits.h>      // for BIT
#include <linux/compiler.h>  // for __aligned
#include <linux/iio/iio.h>   // for IIO_DMA_MINALIGN, iio_chan_spec
#include <linux/minmax.h>    // for __cmp_op_max
#include <linux/mutex.h>     // for mutex
#include <linux/stddef.h>    // for NULL
#include <linux/types.h>     // for __be16, u16, u8
struct device;  // lines 10-10
---

(drivers/iio/dac/ad5446.c has correct #includes/fwd-decls)

(drivers/iio/dac/ad5446-spi.c has correct #includes/fwd-decls)

(drivers/iio/dac/ad5446-i2c.c has correct #includes/fwd-decls)


So maybe those 3 extra in the header  but seem not much needed in the c file.

Hence applied with the compiler.h one added to the header.
Whereever that minmax is coming from is burried deep in macro
so probably isn't appropriate anyway and including stddef for NULL seems
over the top.


Jonathan