* [PATCH 1/4] dt-bindings: riscv: spacemit: Add OrangePi R2S board
[not found] <20251109222858.3085488-1-michael.opdenacker@rootcommit.com>
@ 2025-11-09 22:29 ` michael.opdenacker
2025-11-10 8:02 ` Krzysztof Kozlowski
2025-11-09 22:30 ` [PATCH 2/4] riscv: dts: spacemit: Add OrangePi R2S board device tree michael.opdenacker
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: michael.opdenacker @ 2025-11-09 22:29 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Yangyu Chen
Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit,
linux-kernel
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
Document the compatible string for the OrangePi R2S board [1], which
is marketed as using the Ky X1 SoC but is in fact identical to
the SpacemiT K1 SoC [2].
Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1]
Link: https://www.spacemit.com/en/key-stone-k1 [2]
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml
index 52fe39296031..1b2f279d31f9 100644
--- a/Documentation/devicetree/bindings/riscv/spacemit.yaml
+++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml
@@ -24,6 +24,7 @@ properties:
- milkv,jupiter
- spacemit,musepi-pro
- xunlong,orangepi-rv2
+ - xunlong,orangepi-r2s
- const: spacemit,k1
additionalProperties: true
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/4] riscv: dts: spacemit: Add OrangePi R2S board device tree
[not found] <20251109222858.3085488-1-michael.opdenacker@rootcommit.com>
2025-11-09 22:29 ` [PATCH 1/4] dt-bindings: riscv: spacemit: Add OrangePi R2S board michael.opdenacker
@ 2025-11-09 22:30 ` michael.opdenacker
2025-11-09 22:30 ` [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S michael.opdenacker
2025-11-09 22:30 ` [PATCH 4/4] riscv: dts: spacemit: add eMMC " michael.opdenacker
3 siblings, 0 replies; 8+ messages in thread
From: michael.opdenacker @ 2025-11-09 22:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti
Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit,
linux-kernel
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
Add initial device tree support for the OrangePi RV2 board [1], which is
marketed as using the Ky X1 SoC but has been confirmed to be
identical to the SpacemiT K1 [2].
The device tree is similar to the OrangePi RV2 device tree
(k1-orangepi-rv2.dts)
This minimal device tree enables booting into a serial console with UART.
Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1]
Link: https://www.spacemit.com/en/key-stone-k1 [2]
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
arch/riscv/boot/dts/spacemit/Makefile | 1 +
.../boot/dts/spacemit/k1-orangepi-r2s.dts | 28 +++++++++++++++++++
2 files changed, 29 insertions(+)
create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dts/spacemit/Makefile
index 942ecb38bea0..96b3a13a3944 100644
--- a/arch/riscv/boot/dts/spacemit/Makefile
+++ b/arch/riscv/boot/dts/spacemit/Makefile
@@ -3,3 +3,4 @@ dtb-$(CONFIG_ARCH_SPACEMIT) += k1-bananapi-f3.dtb
dtb-$(CONFIG_ARCH_SPACEMIT) += k1-milkv-jupiter.dtb
dtb-$(CONFIG_ARCH_SPACEMIT) += k1-musepi-pro.dtb
dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-rv2.dtb
+dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-r2s.dtb
diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
new file mode 100644
index 000000000000..902cb6702fbf
--- /dev/null
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com>
+ */
+
+/dts-v1/;
+
+#include "k1.dtsi"
+#include "k1-pinctrl.dtsi"
+
+/ {
+ model = "OrangePi R2S";
+ compatible = "xunlong,orangepi-r2s", "spacemit,k1";
+
+ aliases {
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0";
+ };
+};
+
+&uart0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart0_2_cfg>;
+ status = "okay";
+};
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S
[not found] <20251109222858.3085488-1-michael.opdenacker@rootcommit.com>
2025-11-09 22:29 ` [PATCH 1/4] dt-bindings: riscv: spacemit: Add OrangePi R2S board michael.opdenacker
2025-11-09 22:30 ` [PATCH 2/4] riscv: dts: spacemit: Add OrangePi R2S board device tree michael.opdenacker
@ 2025-11-09 22:30 ` michael.opdenacker
2025-11-10 0:52 ` Yixun Lan
2025-11-10 8:04 ` Krzysztof Kozlowski
2025-11-09 22:30 ` [PATCH 4/4] riscv: dts: spacemit: add eMMC " michael.opdenacker
3 siblings, 2 replies; 8+ messages in thread
From: michael.opdenacker @ 2025-11-09 22:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti
Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit,
linux-kernel
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
The OrangePi R2S board includes two RGMII ethernet ports
supporting Gigabit Ethernet operation.
They have an external Motorcomm YT8531C PHY attached,
the PHY uses GPIO for reset pin control. Their description
was reused from the DTS from the OrangePi RV2 board.
Enable PDMA for the SpacemiT K1-based SoC.
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
tests on eth0
-------------
root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1
Connecting to host 172.24.0.1, port 5201
[ 5] local 172.24.0.2 port 51354 connected to 172.24.0.1 port 5201
[ ID] Interval Transfer Bitrate Retr Cwnd
[ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 395 KBytes
[ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 395 KBytes
[ 5] 2.00-3.00 sec 112 MBytes 936 Mbits/sec 0 395 KBytes
[ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec 0 395 KBytes
[ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec 0 395 KBytes
[ 5] 5.00-6.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes
[ 5] 6.00-7.00 sec 113 MBytes 948 Mbits/sec 0 409 KBytes
[ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes
[ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec 0 414 KBytes
[ 5] 9.00-10.03 sec 113 MBytes 919 Mbits/sec 0 414 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bitrate Retr
[ 5] 0.00-10.03 sec 1.10 GBytes 940 Mbits/sec 0 sender
[ 5] 0.00-10.04 sec 1.10 GBytes 939 Mbits/sec receiver
iperf Done.
root@orangepi-rv2-mainline:~# iperf3 -s
-----------------------------------------------------------
Server listening on 5201 (test #1)
-----------------------------------------------------------
Accepted connection from 172.24.0.1, port 38326
[ 5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 38332
[ ID] Interval Transfer Bitrate
[ 5] 0.00-1.00 sec 112 MBytes 935 Mbits/sec
[ 5] 1.00-2.00 sec 112 MBytes 942 Mbits/sec
[ 5] 2.00-3.00 sec 112 MBytes 941 Mbits/sec
[ 5] 3.00-4.00 sec 112 MBytes 941 Mbits/sec
[ 5] 4.00-5.00 sec 112 MBytes 942 Mbits/sec
[ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec
[ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec
[ 5] 7.00-8.00 sec 112 MBytes 942 Mbits/sec
[ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec
[ 5] 9.00-10.00 sec 112 MBytes 943 Mbits/sec
[ 5] 10.00-10.01 sec 384 KBytes 725 Mbits/sec
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bitrate
[ 5] 0.00-10.01 sec 1.10 GBytes 941 Mbits/sec receiver
Tests on eth1
------------------
root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1
Connecting to host 172.24.0.1, port 5201
[ 5] local 172.24.0.2 port 60564 connected to 172.24.0.1 port 5201
[ ID] Interval Transfer Bitrate Retr Cwnd
[ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 423 KBytes
[ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 423 KBytes
[ 5] 2.00-3.00 sec 112 MBytes 943 Mbits/sec 0 423 KBytes
[ 5] 3.00-4.00 sec 112 MBytes 938 Mbits/sec 0 423 KBytes
[ 5] 4.00-5.00 sec 112 MBytes 944 Mbits/sec 0 423 KBytes
[ 5] 5.00-6.00 sec 112 MBytes 936 Mbits/sec 0 423 KBytes
[ 5] 6.00-7.00 sec 112 MBytes 943 Mbits/sec 0 423 KBytes
[ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 423 KBytes
[ 5] 8.00-9.00 sec 113 MBytes 951 Mbits/sec 0 639 KBytes
[ 5] 9.00-10.01 sec 112 MBytes 934 Mbits/sec 0 639 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bitrate Retr
[ 5] 0.00-10.01 sec 1.10 GBytes 943 Mbits/sec 0 sender
[ 5] 0.00-10.02 sec 1.10 GBytes 940 Mbits/sec receiver
iperf Done.
root@orangepi-rv2-mainline:~# iperf3 -s 172.24.0.1
-----------------------------------------------------------
Server listening on 5201 (test #1)
-----------------------------------------------------------
Accepted connection from 172.24.0.1, port 49628
[ 5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 49640
[ ID] Interval Transfer Bitrate
[ 5] 0.00-1.00 sec 112 MBytes 934 Mbits/sec
[ 5] 1.00-2.00 sec 112 MBytes 942 Mbits/sec
[ 5] 2.00-3.00 sec 112 MBytes 942 Mbits/sec
[ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec
[ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec
[ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec
[ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec
[ 5] 7.00-8.00 sec 112 MBytes 942 Mbits/sec
[ 5] 8.00-9.00 sec 112 MBytes 942 Mbits/sec
[ 5] 9.00-10.00 sec 112 MBytes 941 Mbits/sec
[ 5] 10.00-10.01 sec 640 KBytes 1.14 Gbits/sec
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bitrate
[ 5] 0.00-10.01 sec 1.10 GBytes 941 Mbits/sec receiver
---
.../boot/dts/spacemit/k1-orangepi-r2s.dts | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
index 902cb6702fbf..a4007a7a1656 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
@@ -14,6 +14,8 @@ / {
aliases {
serial0 = &uart0;
+ ethernet0 = ð0;
+ ethernet1 = ð1;
};
chosen {
@@ -21,6 +23,56 @@ chosen {
};
};
+ð0 {
+ phy-handle = <&rgmii0>;
+ phy-mode = "rgmii-id";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac0_cfg>;
+ rx-internal-delay-ps = <0>;
+ tx-internal-delay-ps = <0>;
+ status = "okay";
+
+ mdio-bus {
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+
+ reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>;
+ reset-delay-us = <10000>;
+ reset-post-delay-us = <100000>;
+
+ rgmii0: phy@1 {
+ reg = <0x1>;
+ };
+ };
+};
+
+ð1 {
+ phy-handle = <&rgmii1>;
+ phy-mode = "rgmii-id";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac1_cfg>;
+ rx-internal-delay-ps = <0>;
+ tx-internal-delay-ps = <250>;
+ status = "okay";
+
+ mdio-bus {
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+
+ reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>;
+ reset-delay-us = <10000>;
+ reset-post-delay-us = <100000>;
+
+ rgmii1: phy@1 {
+ reg = <0x1>;
+ };
+ };
+};
+
+&pdma {
+ status = "okay";
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_2_cfg>;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/4] riscv: dts: spacemit: add eMMC to OrangePi R2S
[not found] <20251109222858.3085488-1-michael.opdenacker@rootcommit.com>
` (2 preceding siblings ...)
2025-11-09 22:30 ` [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S michael.opdenacker
@ 2025-11-09 22:30 ` michael.opdenacker
2025-11-10 8:03 ` Krzysztof Kozlowski
3 siblings, 1 reply; 8+ messages in thread
From: michael.opdenacker @ 2025-11-09 22:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yixun Lan
Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit,
linux-kernel
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
The OrangePi R2S board includes a 8 GB eMMC chip for storage.
It works fine with the same description as on the BananaPi F3 board DTS.
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
Read tests
----------
hdparm -t --direct /dev/mmcblk0
/dev/mmcblk0:
Timing O_DIRECT disk reads: 846 MB in 3.01 seconds = 281.52 MB/sec
Write tests
-----------
dd if=/dev/zero of=/dev/mmcblk0p2 bs=4M oflag=direct status=progress
7600078848 bytes (7.6 GB, 7.1 GiB) copied, 127 s, 59.8 MB/s
dd: error writing '/dev/mmcblk0p2': No space left on device
1825+0 records in
1824+0 records out
7650410496 bytes (7.7 GB, 7.1 GiB) copied, 127.866 s, 59.8 MB/s
---
arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
index a4007a7a1656..58098c4a2aab 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
@@ -23,6 +23,16 @@ chosen {
};
};
+&emmc {
+ bus-width = <8>;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ non-removable;
+ no-sd;
+ no-sdio;
+ status = "okay";
+};
+
ð0 {
phy-handle = <&rgmii0>;
phy-mode = "rgmii-id";
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S
2025-11-09 22:30 ` [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S michael.opdenacker
@ 2025-11-10 0:52 ` Yixun Lan
2025-11-10 8:04 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Yixun Lan @ 2025-11-10 0:52 UTC (permalink / raw)
To: michael.opdenacker
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, devicetree,
linux-riscv, spacemit, linux-kernel
Hi Michael,
Please squash patch 2-4, see previous discussion here [1]
Once you've done this, you could put additional info inside cover letter
Link: https://lore.kernel.org/all/20251010-confider-raven-0ad7a810e5de@spud/ [1]
On 22:30 Sun 09 Nov , michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> The OrangePi R2S board includes two RGMII ethernet ports
> supporting Gigabit Ethernet operation.
>
> They have an external Motorcomm YT8531C PHY attached,
> the PHY uses GPIO for reset pin control.
..
> Their description
> was reused from the DTS from the OrangePi RV2 board.
Suggest to drop this, useless and even make people confused.
>
> Enable PDMA for the SpacemiT K1-based SoC.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> ---
>
> tests on eth0
> -------------
>
> root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1
> Connecting to host 172.24.0.1, port 5201
> [ 5] local 172.24.0.2 port 51354 connected to 172.24.0.1 port 5201
> [ ID] Interval Transfer Bitrate Retr Cwnd
> [ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 395 KBytes
> [ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 395 KBytes
> [ 5] 2.00-3.00 sec 112 MBytes 936 Mbits/sec 0 395 KBytes
> [ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec 0 395 KBytes
> [ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec 0 395 KBytes
> [ 5] 5.00-6.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes
> [ 5] 6.00-7.00 sec 113 MBytes 948 Mbits/sec 0 409 KBytes
> [ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes
> [ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec 0 414 KBytes
> [ 5] 9.00-10.03 sec 113 MBytes 919 Mbits/sec 0 414 KBytes
> - - - - - - - - - - - - - - - - - - - - - - - - -
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.03 sec 1.10 GBytes 940 Mbits/sec 0 sender
> [ 5] 0.00-10.04 sec 1.10 GBytes 939 Mbits/sec receiver
>
> iperf Done.
..
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] dt-bindings: riscv: spacemit: Add OrangePi R2S board
2025-11-09 22:29 ` [PATCH 1/4] dt-bindings: riscv: spacemit: Add OrangePi R2S board michael.opdenacker
@ 2025-11-10 8:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-10 8:02 UTC (permalink / raw)
To: michael.opdenacker
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel
On Sun, Nov 09, 2025 at 10:29:57PM +0000, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> Document the compatible string for the OrangePi R2S board [1], which
> is marketed as using the Ky X1 SoC but is in fact identical to
> the SpacemiT K1 SoC [2].
>
> Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1]
> Link: https://www.spacemit.com/en/key-stone-k1 [2]
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> ---
> Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> index 52fe39296031..1b2f279d31f9 100644
> --- a/Documentation/devicetree/bindings/riscv/spacemit.yaml
> +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> @@ -24,6 +24,7 @@ properties:
> - milkv,jupiter
> - spacemit,musepi-pro
> - xunlong,orangepi-rv2
> + - xunlong,orangepi-r2s
2 < v.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4/4] riscv: dts: spacemit: add eMMC to OrangePi R2S
2025-11-09 22:30 ` [PATCH 4/4] riscv: dts: spacemit: add eMMC " michael.opdenacker
@ 2025-11-10 8:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-10 8:03 UTC (permalink / raw)
To: michael.opdenacker
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yixun Lan, devicetree,
linux-riscv, spacemit, linux-kernel
On Sun, Nov 09, 2025 at 10:30:12PM +0000, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> The OrangePi R2S board includes a 8 GB eMMC chip for storage.
>
> It works fine with the same description as on the BananaPi F3 board DTS.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
Squash the patch. You just added this board. Adding board is one commit.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S
2025-11-09 22:30 ` [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S michael.opdenacker
2025-11-10 0:52 ` Yixun Lan
@ 2025-11-10 8:04 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-10 8:04 UTC (permalink / raw)
To: michael.opdenacker
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
devicetree, linux-riscv, spacemit, linux-kernel
On Sun, Nov 09, 2025 at 10:30:09PM +0000, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> The OrangePi R2S board includes two RGMII ethernet ports
> supporting Gigabit Ethernet operation.
>
> They have an external Motorcomm YT8531C PHY attached,
> the PHY uses GPIO for reset pin control. Their description
> was reused from the DTS from the OrangePi RV2 board.
>
> Enable PDMA for the SpacemiT K1-based SoC.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> ---
>
Squash the patch. You just added this board. Adding board is one commit.
Why adding incomplete or even buggy code just to fix it immediately?
Best regards,
Krzysztof
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-11-10 8:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251109222858.3085488-1-michael.opdenacker@rootcommit.com>
2025-11-09 22:29 ` [PATCH 1/4] dt-bindings: riscv: spacemit: Add OrangePi R2S board michael.opdenacker
2025-11-10 8:02 ` Krzysztof Kozlowski
2025-11-09 22:30 ` [PATCH 2/4] riscv: dts: spacemit: Add OrangePi R2S board device tree michael.opdenacker
2025-11-09 22:30 ` [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S michael.opdenacker
2025-11-10 0:52 ` Yixun Lan
2025-11-10 8:04 ` Krzysztof Kozlowski
2025-11-09 22:30 ` [PATCH 4/4] riscv: dts: spacemit: add eMMC " michael.opdenacker
2025-11-10 8:03 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).