From: Conor Dooley <conor@kernel.org>
To: Hanchien Lin <hanchien.lin@mediatek.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Balsam CHIHI <bchihi@baylibre.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
raymond.sun@mediatek.com, Irving-CH.lin@mediatek.com
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node
Date: Mon, 10 Nov 2025 18:45:20 +0000 [thread overview]
Message-ID: <20251110-vagueness-waggle-50b8efe728a8@spud> (raw)
In-Reply-To: <20251110094113.3965182-2-hanchien.lin@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 3381 bytes --]
On Mon, Nov 10, 2025 at 05:40:38PM +0800, Hanchien Lin wrote:
> Add device tree node for the thermal controller on MediaTek MT8189 SoC.
$subject is incorrect for a binding change.
pw-bot: changes-requested
>
> Signed-off-by: Hanchien Lin <hanchien.lin@mediatek.com>
> ---
> .../thermal/mediatek,lvts-thermal.yaml | 27 +++++++++++++++++--
> .../thermal/mediatek,lvts-thermal.h | 20 ++++++++++++++
> 2 files changed, 45 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> index 0259cd3ce9c5..0f7fd69f5fdf 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -22,6 +22,8 @@ properties:
> - mediatek,mt8186-lvts
> - mediatek,mt8188-lvts-ap
> - mediatek,mt8188-lvts-mcu
> + - mediatek,mt8189-lvts-ap
> + - mediatek,mt8189-lvts-mcu
> - mediatek,mt8192-lvts-ap
> - mediatek,mt8192-lvts-mcu
> - mediatek,mt8195-lvts-ap
> @@ -58,6 +60,21 @@ properties:
> allOf:
> - $ref: thermal-sensor.yaml#
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt8189-lvts-ap
> + - mediatek,mt8189-lvts-mcu
> + then:
> + properties:
> + nvmem-cells:
> + minItems: 2
> +
> + nvmem-cell-names:
> + minItems: 2
> +
> - if:
> properties:
> compatible:
> @@ -75,6 +92,10 @@ allOf:
> nvmem-cell-names:
> maxItems: 1
>
> + required:
> + - clocks
> + - resets
> +
> - if:
> properties:
> compatible:
> @@ -91,12 +112,14 @@ allOf:
> nvmem-cell-names:
> minItems: 2
>
> + required:
> + - clocks
> + - resets
> +
> required:
> - compatible
> - reg
> - interrupts
> - - clocks
> - - resets
> - nvmem-cells
> - nvmem-cell-names
>
> diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
> index ddc7302a510a..6c9103dfdc2d 100644
> --- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h
> +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
> @@ -42,6 +42,26 @@
> #define MT8188_AP_CAM1 6
> #define MT8188_AP_CAM2 7
>
> +#define MT8189_MCU_BIG_CPU1 0
> +#define MT8189_MCU_BIG_CPU2 1
> +#define MT8189_MCU_BIG_CPU3 2
> +#define MT8189_MCU_BIG_CPU4 3
> +#define MT8189_MCU_LITTLE_CPU1 4
> +#define MT8189_MCU_LITTLE_CPU2 5
> +#define MT8189_MCU_LITTLE_CPU3 6
> +#define MT8189_MCU_LITTLE_CPU4 7
> +#define MT8189_MCU_LITTLE_CPU5 8
> +#define MT8189_MCU_LITTLE_CPU6 9
> +#define MT8189_MCU_LITTLE_CPU7 10
> +#define MT8189_MCU_LITTLE_CPU8 11
> +
> +#define MT8189_AP_SOC1 12
> +#define MT8189_AP_SOC2 13
> +#define MT8189_AP_SOC3 14
> +#define MT8189_AP_APU 15
> +#define MT8189_AP_GPU1 16
> +#define MT8189_AP_GPU2 17
> +
> #define MT8195_MCU_BIG_CPU0 0
> #define MT8195_MCU_BIG_CPU1 1
> #define MT8195_MCU_BIG_CPU2 2
> --
> 2.45.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-11-10 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 9:40 [PATCH 0/2] arm64: dts/thermal: Add MT8189 thermal controller and driver support Hanchien Lin
2025-11-10 9:40 ` [PATCH 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node Hanchien Lin
2025-11-10 18:45 ` Conor Dooley [this message]
2025-12-02 8:02 ` Hanchien Lin (林翰謙)
2025-11-10 9:40 ` [PATCH 2/2] thermal/drivers/mediatek/lvts_thermal: Add MT8189 support Hanchien Lin
2025-11-10 9:53 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110-vagueness-waggle-50b8efe728a8@spud \
--to=conor@kernel.org \
--cc=Irving-CH.lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bchihi@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hanchien.lin@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=raymond.sun@mediatek.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox