devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH 0/2] phy: microchip: lan966x: Allow to invert N and P signals
Date: Mon, 10 Nov 2025 13:42:16 +0200	[thread overview]
Message-ID: <20251110114216.r6zdgg4iky7kasut@skbuf> (raw)
In-Reply-To: <20251110110536.2596490-1-horatiu.vultur@microchip.com>

Hi Horatiu,

On Mon, Nov 10, 2025 at 12:05:34PM +0100, Horatiu Vultur wrote:
> Allow to invert the N and P signals of the Serdes for both RX and TX. This
> is used to allow the board designer to trace more easily the signals.
> 
> Horatiu Vultur (2):
>   phy: microchip: lan966x: Add support for inverting the rx/tx lanes
>   dt-bindings: phy: lan966x: Add optional microchip,sx-tx/rx-inverted
> 
>  .../phy/microchip,lan966x-serdes.yaml         | 24 +++++++++++++++++++
>  drivers/phy/microchip/lan966x_serdes.c        | 23 ++++++++++++++++++
>  2 files changed, 47 insertions(+)
> 
> -- 
> 2.34.1

For context, I am trying to describe the lane polarity property
generically, and I've already blocked Daniel Golle's attempt to
introduce the similar in intent "maxlinear,rx-inverted" and
"maxlinear,tx-inverted".
https://lore.kernel.org/netdev/20251028000959.3kiac5kwo5pcl4ft@skbuf/

I am trying to find out all there is to know in order about this
feature, and I just noticed your patch, so I have to ask some questions
in order to understand, had a generic property existed, whether you
would have used it.

So I see that you don't have OF nodes for individual SerDes lanes, so
this makes your device tree structure incompatible with simple
"tx-polarity"/"rx-polarity" properties. Are those something you're not
willing to introduce? What about other stuff that's in
Documentation/devicetree/bindings/phy/transmit-amplitude.yaml?
You also won't be able to make use of the existing device tree
properties if you don't have OF node containers for each lane.

  parent reply	other threads:[~2025-11-10 11:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 11:05 [PATCH 0/2] phy: microchip: lan966x: Allow to invert N and P signals Horatiu Vultur
2025-11-10 11:05 ` [PATCH 1/2] phy: microchip: lan966x: Add support for inverting the rx/tx lanes Horatiu Vultur
2025-11-10 11:05 ` [PATCH 2/2] dt-bindings: phy: lan966x: Add optional microchip,sx-tx/rx-inverted Horatiu Vultur
2025-11-10 18:43   ` Conor Dooley
2025-11-11  9:58     ` Horatiu Vultur
2025-11-11 10:06       ` Krzysztof Kozlowski
2025-11-11 17:39         ` Conor Dooley
2025-11-12  8:02           ` Horatiu Vultur
2025-11-12 18:32             ` Conor Dooley
2025-11-13 11:56               ` Horatiu Vultur
2025-11-13 19:13                 ` Conor Dooley
2025-11-10 11:42 ` Vladimir Oltean [this message]
2025-11-11  9:50   ` [PATCH 0/2] phy: microchip: lan966x: Allow to invert N and P signals Horatiu Vultur
2025-11-13 16:30     ` Vladimir Oltean
2025-11-14 10:34       ` Horatiu Vultur
2025-11-19 19:23         ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110114216.r6zdgg4iky7kasut@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).