From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5403F3A1D11; Tue, 11 Nov 2025 18:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762885806; cv=none; b=P8PpBMt9zGZenLliDsAIL3UO5Y/5w4VkGFvdNtARq0N9bZXQwRdFZorA7JkWg/h4XNPZ1UfopMLoYHPh8rzF4tRrl6H3c2GG3GuxeJBbk9lPbtiV9RjleciZfmb0DydG8HoIN5BkIE0jAdJOT8jzc3SGwJNHemRv1P4+6our5cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762885806; c=relaxed/simple; bh=bR+S/G6a5cL9iT3wiJ+fUBO3PPAFX+/KEGXf+e9r7Ds=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FyeKYQVHAixOTZPo8Y2zIMZ9+KfUhYH1Vrx2Zsw5a9Vf15GtVOO+ObMI0Td+L8vzo8L62tyPZ8EKAnE/fTvNqBe0qz1zPD3RppDwoPUaMtg5B7Sl7LWX4yHftBhbjRAmJPJD4q9a2OqEH/iX6kN5dByqyeUanlTVLZY3CfhQIec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o0mHU2Nb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o0mHU2Nb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C796CC116D0; Tue, 11 Nov 2025 18:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762885803; bh=bR+S/G6a5cL9iT3wiJ+fUBO3PPAFX+/KEGXf+e9r7Ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o0mHU2Nb+JnDUJ/4AMKxFQjJfcJUtaWirZTAYNRVYPxqSANsAVDy2a028ZyS5NyNP 3QP8xJfxCiDysZ+4+9ymEwSxzapy72lZ4vUxQ4NMwWhNHNgSMF3vfFwCFbnkIzz4+Y vVSObd5/n1x8A1MPQi6BqsxLMUn8ltJBTjGbSRGyrQ9XYIg2ERp2YKMe1ePl29J2GW WeLmqb+20z2EgZ751maQmpVuULYUZol0NdMNKonJQMS9pIAtUmO6FYnIvNd6hJlqCv rHVn1DX7gYOW0oPTCO1PIvNNvlN8JVs1fPp/pFOHRK1TnMfv387i3sF66ku/XMueCM gtIfWA/RyEZyQ== Date: Tue, 11 Nov 2025 18:29:54 +0000 From: Conor Dooley To: Michal Wilczynski Cc: Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Conor Dooley , Xingyu Wu , Vinod Koul , Kishon Vijay Abraham I , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Icenowy Zheng , Maud Spierings , Andy Yan , Heiko Stuebner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH RFC 05/13] dt-bindings: mfd: Add starfive,jh7110-hdmi-mfd Message-ID: <20251111-late-sycamore-baff8bd0a5b7@spud> References: <20251108-jh7110-clean-send-v1-0-06bf43bb76b1@samsung.com> <20251108-jh7110-clean-send-v1-5-06bf43bb76b1@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MHBF9IdfTAgSUpdQ" Content-Disposition: inline In-Reply-To: <20251108-jh7110-clean-send-v1-5-06bf43bb76b1@samsung.com> --MHBF9IdfTAgSUpdQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 08, 2025 at 02:04:39AM +0100, Michal Wilczynski wrote: > Add the dt-binding for the StarFive JH7110 HDMI MFD (Multi-Function > Device). >=20 > The JH7110 HDMI IP is a monolithic block containing both the digital > controller and analog PHY in a single register space. This binding > defines the MFD parent device, which holds the shared register map and > populates its two children: the PHY and the controller. This is > necessary to resolve a circular clock dependency between the HDMI block > and the VOUT clock generator. >=20 > Signed-off-by: Michal Wilczynski > --- > .../bindings/mfd/starfive,jh7110-hdmi-mfd.yaml | 93 ++++++++++++++++= ++++++ > MAINTAINERS | 1 + > 2 files changed, 94 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-m= fd.yaml b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-mfd.ya= ml > new file mode 100644 > index 0000000000000000000000000000000000000000..2cbfb2b975083240575a0567b= 06e6cafd542cf9b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-mfd.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/starfive,jh7110-hdmi-mfd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 HDMI MFD (Controller+PHY) > + > +maintainers: > + - Michal Wilczynski > + > +description: > + The StarFive JH7110 HDMI block is a monolithic IP containing both > + the digital controller logic and the analog PHY logic in a single > + register space. > + > +properties: > + compatible: > + const: starfive,jh7110-hdmi-mfd Drop "mfd" from this please, maybe using "subsystem" is a more suitable alternative? > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +patternProperties: > + "^phy(@[0-9a-f]+)?$": > + $ref: ../phy/starfive,jh7110-inno-hdmi-phy.yaml# > + "^controller(@[0-9a-f]+)?$": > + $ref: ../display/bridge/starfive,jh7110-inno-hdmi-controller.yaml# Can you make these absolute references please? > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + soc { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + hdmi_mfd: hdmi@29590000 { And drop any unused labels from here. I definitely thing you could do away with the same example being in three different places. Maybe one full one here, and two partials in each of the children? > + compatible =3D "starfive,jh7110-hdmi-mfd"; > + reg =3D <0x29590000 0x4000>; > + > + hdmi_phy: phy { > + compatible =3D "starfive,jh7110-inno-hdmi-phy"; > + clocks =3D <&xin24m>; > + clock-names =3D "refoclk"; > + #clock-cells =3D <0>; > + clock-output-names =3D "hdmi_pclk"; > + #phy-cells =3D <0>; > + }; > + > + hdmi_controller: controller { > + compatible =3D "starfive,jh7110-inno-hdmi-controller"; > + interrupts =3D <99>; > + clocks =3D <&voutcrg JH7110_VOUTCLK_HDMI_TX_SYS>, > + <&voutcrg JH7110_VOUTCLK_HDMI_TX_MCLK>, > + <&voutcrg JH7110_VOUTCLK_HDMI_TX_BCLK>, > + <&hdmi_phy>; > + clock-names =3D "sys", "mclk", "bclk", "pclk"; > + resets =3D <&voutcrg JH7110_VOUTRST_HDMI_TX_HDMI>; > + reset-names =3D "hdmi_tx"; > + phys =3D <&hdmi_phy>; > + phy-names =3D "hdmi-phy"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + hdmi_in: endpoint { > + remote-endpoint =3D <&dpu_out_dpi0>; > + }; > + }; > + > + port@1 { > + reg =3D <1>; > + hdmi_out: endpoint { > + remote-endpoint =3D <&hdmi_con_in>; > + }; > + }; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 66fab45bbee8c1a5f73d09bb470d28029b8c6139..052876c6538f980f75ff64e78= b6ebea460307904 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -24048,6 +24048,7 @@ STARFIVE JH7110 DISPLAY SUBSYSTEM > M: Michal Wilczynski > S: Maintained > F: Documentation/devicetree/bindings/display/bridge/starfive,jh7110-inno= -hdmi-controller.yaml > +F: Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-mfd.yaml > F: Documentation/devicetree/bindings/phy/starfive,jh7110-inno-hdmi-phy.y= aml > F: Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-vout-s= ubsystem.yaml > =20 >=20 > --=20 > 2.34.1 >=20 --MHBF9IdfTAgSUpdQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaROAogAKCRB4tDGHoIJi 0lFuAQCF+AFB3vd2cBEjM70iO0hvHejdfbLmbcZNcxt68vCp5gEAjTw9rqui2EYo 3QeXzLstfJTO5hhitM8svk5TR9ugnQM= =eZh0 -----END PGP SIGNATURE----- --MHBF9IdfTAgSUpdQ--