devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>,
	vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: lan966x: Add optional microchip,sx-tx/rx-inverted
Date: Tue, 11 Nov 2025 17:39:36 +0000	[thread overview]
Message-ID: <20251111-ploy-dispersal-164ae403df4d@spud> (raw)
In-Reply-To: <58b0d712-48a4-4490-a63f-404716844557@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On Tue, Nov 11, 2025 at 11:06:02AM +0100, Krzysztof Kozlowski wrote:
> On 11/11/2025 10:58, Horatiu Vultur wrote:
> > The 11/10/2025 18:43, Conor Dooley wrote:
> > 
> > Hi Conor,
> > 
> >> On Mon, Nov 10, 2025 at 12:05:36PM +0100, Horatiu Vultur wrote:
> >>> This allows to invert the N and P signals of the RX and TX Serdes
> >>> signals. This option allows the board designer to trace their signals
> >>> easier on the boards.
> >>
> >> Why can't this just be done in software, debugfs or something like that?
> >> Maybe it's just your description is poor, but sounds like the intention
> >> here is to just switch things around for debug purposes.
> > 
> > I don't think it should be done through debugfs. As this describes the
> > board layout and I don't think someone will want to change it at
> > runtime to see how things behave. So maybe the description is poor.
> 
> You said it is purely for hardware designer to trace signals, so sorry,
> but that's not DTs purpose.

If it is not purely some sort of debug helper, then please explain
better in your commit message.
pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-11-11 17:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 11:05 [PATCH 0/2] phy: microchip: lan966x: Allow to invert N and P signals Horatiu Vultur
2025-11-10 11:05 ` [PATCH 1/2] phy: microchip: lan966x: Add support for inverting the rx/tx lanes Horatiu Vultur
2025-11-10 11:05 ` [PATCH 2/2] dt-bindings: phy: lan966x: Add optional microchip,sx-tx/rx-inverted Horatiu Vultur
2025-11-10 18:43   ` Conor Dooley
2025-11-11  9:58     ` Horatiu Vultur
2025-11-11 10:06       ` Krzysztof Kozlowski
2025-11-11 17:39         ` Conor Dooley [this message]
2025-11-12  8:02           ` Horatiu Vultur
2025-11-12 18:32             ` Conor Dooley
2025-11-13 11:56               ` Horatiu Vultur
2025-11-13 19:13                 ` Conor Dooley
2025-11-10 11:42 ` [PATCH 0/2] phy: microchip: lan966x: Allow to invert N and P signals Vladimir Oltean
2025-11-11  9:50   ` Horatiu Vultur
2025-11-13 16:30     ` Vladimir Oltean
2025-11-14 10:34       ` Horatiu Vultur
2025-11-19 19:23         ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111-ploy-dispersal-164ae403df4d@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).