From: Wenliang Yan <wenliang202407@163.com>
To: linux@roeck-us.net, Jean Delvare <jdelvare@suse.com>
Cc: christophe.jaillet@wanadoo.fr, conor+dt@kernel.org,
corbet@lwn.net, devicetree@vger.kernel.org, krzk+dt@kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
robh@kernel.org, wenliang202407@163.com
Subject: [PATCH 3/8] hwmon:(ina3221)Support alert-type
Date: Tue, 11 Nov 2025 03:05:41 -0500 [thread overview]
Message-ID: <20251111080546.32421-4-wenliang202407@163.com> (raw)
In-Reply-To: <20251111080546.32421-1-wenliang202407@163.com>
SQ52210 supports setting alert-type, and this parameter has been
described in the devicetree. Add support for it to the driver.
Signed-off-by: Wenliang Yan <wenliang202407@163.com>
---
drivers/hwmon/ina3221.c | 73 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 72 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index 80c1bcc7edd7..ee9ad022e255 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -65,6 +65,8 @@
#define INA3221_MASK_ENABLE_SCC_MASK GENMASK(14, 12)
+#define SQ52210_ALERT_CONFIG_MASK GENMASK(15, 4)
+
#define INA3221_CONFIG_DEFAULT 0x7127
#define INA3221_RSHUNT_DEFAULT 10000
@@ -105,6 +107,13 @@ enum ina3221_channels {
INA3221_NUM_CHANNELS
};
+enum ina3221_alert_type {
+ SUL,
+ BOL,
+ BUL,
+ POL
+};
+
/**
* struct ina3221_input - channel input source specific information
* @label: label of channel input source
@@ -121,9 +130,15 @@ struct ina3221_input {
enum ina3221_ids { ina3221, sq52210 };
+struct ina3221_config {
+ bool has_alerts; /* chip supports alerts and limits */
+ bool has_current; /* chip has internal current reg */
+ bool has_power; /* chip has internal power reg */
+};
/**
* struct ina3221_data - device specific information
+ * @config: Used to store characteristics of different chips
* @chip: Chip type identifier
* @pm_dev: Device pointer for pm runtime
* @regmap: Register map of the device
@@ -132,9 +147,11 @@ enum ina3221_ids { ina3221, sq52210 };
* @reg_config: Register value of INA3221_CONFIG
* @summation_shunt_resistor: equivalent shunt resistor value for summation
* @summation_channel_control: Value written to SCC field in INA3221_MASK_ENABLE
+ * @alert_type_select: Used to store the alert trigger type
* @single_shot: running in single-shot operating mode
*/
struct ina3221_data {
+ const struct ina3221_config *config;
enum ina3221_ids chip;
struct device *pm_dev;
@@ -144,10 +161,24 @@ struct ina3221_data {
u32 reg_config;
int summation_shunt_resistor;
u32 summation_channel_control;
+ u32 alert_type_select;
bool single_shot;
};
+static const struct ina3221_config ina3221_config[] = {
+ [ina3221] = {
+ .has_alerts = false,
+ .has_current = false,
+ .has_power = false,
+ },
+ [sq52210] = {
+ .has_alerts = true,
+ .has_current = true,
+ .has_power = true,
+ },
+};
+
static inline bool ina3221_is_enabled(struct ina3221_data *ina, int channel)
{
/* Summation channel checks shunt resistor values */
@@ -772,7 +803,7 @@ static int ina3221_probe_child_from_dt(struct device *dev,
struct ina3221_data *ina)
{
struct ina3221_input *input;
- u32 val;
+ u32 val, alert_type;
int ret;
ret = of_property_read_u32(child, "reg", &val);
@@ -792,6 +823,34 @@ static int ina3221_probe_child_from_dt(struct device *dev,
return 0;
}
+ if (ina->config->has_alerts) {
+ ret = of_property_read_u32(child, "alert-type", &alert_type);
+ if (ret < 0) {
+ dev_err(dev, "missing alert-type property of %pOFn\n", child);
+ return ret;
+ } else if (alert_type > POL) {
+ dev_err(dev, "invalid alert-type of %pOFn\n", child);
+ return -EINVAL;
+ }
+ switch (alert_type) {
+ /* val is channel value*/
+ case SUL:
+ ina->alert_type_select |= BIT(15 - val);
+ break;
+ case BOL:
+ ina->alert_type_select |= BIT(12 - val);
+ break;
+ case BUL:
+ ina->alert_type_select |= BIT(9 - val);
+ break;
+ case POL:
+ ina->alert_type_select |= BIT(6 - val);
+ break;
+ default:
+ break;
+ }
+ }
+
/* Save the connected input label if available */
of_property_read_string(child, "label", &input->label);
@@ -847,6 +906,7 @@ static int ina3221_probe(struct i2c_client *client)
return -ENOMEM;
ina->chip = chip;
+ ina->config = &ina3221_config[chip];
ina->regmap = devm_regmap_init_i2c(client, &ina3221_regmap_config);
if (IS_ERR(ina->regmap)) {
@@ -1012,6 +1072,17 @@ static int ina3221_resume(struct device *dev)
}
}
+ /* Restore alert config register value to hardware */
+ if (ina->config->has_alerts) {
+ ret = regmap_update_bits(ina->regmap, SQ52210_ALERT_CONFIG,
+ SQ52210_ALERT_CONFIG_MASK,
+ ina->alert_type_select);
+ if (ret) {
+ dev_err(dev, "Unable to select alert type\n");
+ return ret;
+ }
+ }
+
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2025-11-11 8:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 8:05 [PATCH 0/8] (hwmon):(ina3221) Various improvement and add support for SQ52210 Wenliang Yan
2025-11-11 8:05 ` [PATCH 1/8] dt-binding:ti,ina3221:Add SQ52210 Wenliang Yan
2025-11-11 8:17 ` Krzysztof Kozlowski
2025-11-12 2:09 ` Wenliang Yan
2025-11-11 9:32 ` Rob Herring (Arm)
2025-11-12 2:08 ` Wenliang Yan
2025-11-13 2:03 ` Guenter Roeck
2025-11-14 6:44 ` Wenliang Yan
2025-11-11 8:05 ` [PATCH 2/8] hwmon:(ina3221)Add support for SQ52210 Wenliang Yan
2025-11-11 8:05 ` Wenliang Yan [this message]
2025-11-11 8:05 ` [PATCH 4/8] hwmon:(ina3221)Pre-calculate current and power LSB Wenliang Yan
2025-11-11 8:05 ` [PATCH 5/8] hwmon:(ina3221)Introduce power attribute and other characteristics of other attribute Wenliang Yan
2025-11-11 8:05 ` [PATCH 6/8] hwmon:(ina3221)Modify read/write functions for 'in' attribute Wenliang Yan
2025-11-12 3:58 ` kernel test robot
2025-11-13 17:16 ` Guenter Roeck
2025-11-14 7:36 ` [PATCH 1/8] dt-binding:ti,ina3221:Add SQ52210 Wenliang Yan
2025-11-11 8:05 ` [PATCH 7/8] hwmon:(ina3221)Support read/write functions for 'power' attribute Wenliang Yan
2025-11-13 17:18 ` Guenter Roeck
2025-11-14 7:41 ` [PATCH 1/8] dt-binding:ti,ina3221:Add SQ52210 Wenliang Yan
2025-11-11 8:05 ` [PATCH 8/8] hwmon:(ina3221)Support read/write functions for current_lcrict attribute Wenliang Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111080546.32421-4-wenliang202407@163.com \
--to=wenliang202407@163.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).