Re: [PATCH 2/2] dt-bindings: phy: lan966x: Add optional microchip,sx-tx/rx-inverted

Conor Dooley
2025-11-11T17:39:41Z

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On Tue, Nov 11, 2025 at 11:06:02AM +0100, Krzysztof Kozlowski wrote:
> On 11/11/2025 10:58, Horatiu Vultur wrote:
> > The 11/10/2025 18:43, Conor Dooley wrote:
> >
> > Hi Conor,
> >
> >> On Mon, Nov 10, 2025 at 12:05:36PM +0100, Horatiu Vultur wrote:
> >>> This allows to invert the N and P signals of the RX and TX Serdes
> >>> signals. This option allows the board designer to trace their signals
> >>> easier on the boards.
> >>
> >> Why can't this just be done in software, debugfs or something like that?
> >> Maybe it's just your description is poor, but sounds like the intention
> >> here is to just switch things around for debug purposes.
> >
> > I don't think it should be done through debugfs. As this describes the
> > board layout and I don't think someone will want to change it at
> > runtime to see how things behave. So maybe the description is poor.
>
> You said it is purely for hardware designer to trace signals, so sorry,
> but that's not DTs purpose.

If it is not purely some sort of debug helper, then please explain
better in your commit message.
pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]