Re: [PATCH 2/2] dt-bindings: phy: lan966x: Add optional microchip,sx-tx/rx-inverted

Horatiu Vultur
2025-11-11T10:01:05Z

The 11/10/2025 18:43, Conor Dooley wrote:

Hi Conor,

> On Mon, Nov 10, 2025 at 12:05:36PM +0100, Horatiu Vultur wrote:
> > This allows to invert the N and P signals of the RX and TX Serdes
> > signals. This option allows the board designer to trace their signals
> > easier on the boards.
>
> Why can't this just be done in software, debugfs or something like that?
> Maybe it's just your description is poor, but sounds like the intention
> here is to just switch things around for debug purposes.

I don't think it should be done through debugfs. As this describes the
board layout and I don't think someone will want to change it at
runtime to see how things behave. So maybe the description is poor.

>
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > .../phy/microchip,lan966x-serdes.yaml | 24 +++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml b/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml
> > index 6e914fbbac567..21b19e06a75aa 100644
> > --- a/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml
> > +++ b/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml
> > @@ -41,6 +41,30 @@ properties:
> > - The macro to be used. The macros are defined in
> > dt-bindings/phy/phy-lan966x-serdes.
> >
> > + microchip,s0-tx-inverted:
> > + type: boolean
> > + description: Invert the TX N and P signals for Serdes 0
> > +
> > + microchip,s1-tx-inverted:
> > + type: boolean
> > + description: Invert the TX N and P signals for Serdes 1
> > +
> > + microchip,s2-tx-inverted:
> > + type: boolean
> > + description: Invert the TX N and P signals for Serdes 2
> > +
> > + microchip,s0-rx-inverted:
> > + type: boolean
> > + description: Invert the RX N and P signals for Serdes 0
> > +
> > + microchip,s1-rx-inverted:
> > + type: boolean
> > + description: Invert the RX N and P signals for Serdes 1
> > +
> > + microchip,s2-rx-inverted:
> > + type: boolean
> > + description: Invert the RX N and P signals for Serdes 2
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.34.1
> >

--
/Horatiu