From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: "Srinivas Kandagatla" <srini@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
semen.protsenko@linaro.org, willmcvicker@google.com,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/5] nvmem: add Samsung Exynos OTP support
Date: Thu, 13 Nov 2025 09:30:10 +0100 [thread overview]
Message-ID: <20251113-benign-macaw-of-development-dbd1f8@kuoka> (raw)
In-Reply-To: <20251112-gs101-otp-v2-2-bff2eb020c95@linaro.org>
On Wed, Nov 12, 2025 at 08:29:06AM +0000, Tudor Ambarus wrote:
> Add initial support for the Samsung Exynos OTP controller. Read the
> product and chip IDs from the OTP controller registers space and
> register the SoC info to the SoC interface.
>
> The driver can be extended to empower the controller become nvmem
> provider. This is not in the scope of this patch because it seems the
> OTP memory space is not yet used by any consumer, even downstream.
Quick look tells me you just duplicated existing Samsung ChipID driver.
Even actual product ID registers and masks are the same, with one
difference - you read CHIPID3... which is the same as in newer Exynos,
e.g. Exynos8895.
What is exactly the point of having this as separate driver? I think
this can easily be just customized chipid driver - with different
implementation of exynos_chipid_get_chipid_info().
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-13 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 8:29 [PATCH v2 0/5] nvmem: add Samsung Exynos OTP support Tudor Ambarus
2025-11-12 8:29 ` [PATCH v2 1/5] dt-bindings: nvmem: add google,gs101-otp Tudor Ambarus
2025-11-13 8:22 ` Krzysztof Kozlowski
2025-11-13 9:05 ` André Draszik
2025-11-12 8:29 ` [PATCH v2 2/5] nvmem: add Samsung Exynos OTP support Tudor Ambarus
2025-11-13 8:30 ` Krzysztof Kozlowski [this message]
2025-11-13 9:28 ` Tudor Ambarus
2025-11-13 9:35 ` Krzysztof Kozlowski
2025-11-13 9:51 ` Tudor Ambarus
2025-11-13 10:26 ` Tudor Ambarus
2025-11-13 10:44 ` Krzysztof Kozlowski
2025-11-13 12:52 ` Tudor Ambarus
2025-11-13 10:43 ` Krzysztof Kozlowski
2025-11-12 8:29 ` [PATCH v2 3/5] arm64: dts: exynos: gs101: add OTP node Tudor Ambarus
2025-11-12 8:29 ` [PATCH v2 4/5] arm64: defconfig: enable Samsung Exynos OTP controller Tudor Ambarus
2025-11-12 8:29 ` [PATCH v2 5/5] MAINTAINERS: add entry for the Samsung Exynos OTP controller driver Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113-benign-macaw-of-development-dbd1f8@kuoka \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=srini@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).