* [PATCH] arm64: dts: exynos: gs101-pixel: add all S2MPG1x regulators
@ 2025-11-13 13:31 André Draszik
2025-11-17 8:11 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: André Draszik @ 2025-11-13 13:31 UTC (permalink / raw)
To: Peter Griffin, Tudor Ambarus, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alim Akhtar
Cc: Will McVicker, Juan Yescas, Douglas Anderson, kernel-team,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
André Draszik
Most rails are the same between Pixel 6 and Pro, with the following
differences:
* only Pro has UWB
* Pro uses l2m, not l14m, for TCXO
* Pro uses bucka, not l31m, for NFC
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
Please note that this patch depends on the bindings updates for S2MPG1x
from
https://lore.kernel.org/all/20251110-s2mpg1x-regulators-v4-0-94c9e726d4ba@linaro.org/
I've left out conversion of placeholder regulators for now, because
some more testing is required for such changes.
With this in change (and the corresponding driver updates), the most
noteable change is that the display is turned off at some point during
boot (since we don't have a display driver yet). To avoid that, one
could boot with regulator_ignore_unused or vci_disp (ldo22m) could be
marked as regulator-always-on. I've not done that to ensure power
consumption is reduced by default and the phone stays cool and the
battery charges using the default settings configured by the bootloader.
---
arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 22 +
.../boot/dts/exynos/google/gs101-pixel-common.dtsi | 494 ++++++++++++++++++++-
arch/arm64/boot/dts/exynos/google/gs101-raven.dts | 18 +
3 files changed, 533 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
index 8df42bedbc036b5e97f6238d64820370043ffef2..36721adcaa239da20d63173bdeab67f4381f3c91 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
+++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
@@ -8,6 +8,7 @@
/dts-v1/;
+#include <dt-bindings/regulator/samsung,s2mpg10-regulator.h>
#include "gs101-pixel-common.dtsi"
/ {
@@ -15,6 +16,27 @@ / {
compatible = "google,gs101-oriole", "google,gs101";
};
+&acpm_ipc {
+ pmic-1 {
+ regulators {
+ ldo14m {
+ /* PLL */
+ regulator-name = "avdd18_tcxo";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_TCXO_ON>;
+ };
+
+ ldo31m {
+ regulator-name = "nfc";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+ };
+ };
+};
+
&cont_splash_mem {
reg = <0x0 0xfac00000 (1080 * 2400 * 4)>;
status = "okay";
diff --git a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
index 93892adaa679439bd87b0630cf9416b05c9d4536..f957e0abe9a0ea8a015334424a64b69b26d789de 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
@@ -10,6 +10,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/regulator/samsung,s2mpg10-regulator.h>
#include <dt-bindings/usb/pd.h>
#include "gs101-pinctrl.h"
#include "gs101.dtsi"
@@ -101,7 +102,7 @@ cont_splash_mem: splash@fac00000 {
};
&acpm_ipc {
- pmic {
+ pmic-1 {
compatible = "samsung,s2mpg10-pmic";
interrupts-extended = <&gpa0 6 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
@@ -109,6 +110,22 @@ pmic {
system-power-controller;
wakeup-source;
+ vinl1m-supply = <&s2mpg11_buck3s>;
+ vinl2m-supply = <&s2mpg11_buck3s>;
+ vinl3m-supply = <&s2mpg10_buck8m>;
+ vinl4m-supply = <&s2mpg10_buck9m>;
+ vinl5m-supply = <&s2mpg10_buck9m>;
+ vinl6m-supply = <&s2mpg10_buck9m>;
+ vinl7m-supply = <&s2mpg11_buck6s>;
+ vinl8m-supply = <&s2mpg11_buck6s>;
+ vinl9m-supply = <&s2mpg11_buck7s>;
+ vinl10m-supply = <&s2mpg11_buck7s>;
+ vinl11m-supply = <&s2mpg11_buck7s>;
+ vinl12m-supply = <&s2mpg11_bucka>;
+ vinl13m-supply = <&s2mpg11_bucka>;
+ vinl14m-supply = <&s2mpg11_buckboost>;
+ vinl15m-supply = <&s2mpg11_buckboost>;
+
clocks {
compatible = "samsung,s2mpg10-clk";
#clock-cells = <1>;
@@ -117,6 +134,475 @@ clocks {
};
regulators {
+ buck1m {
+ regulator-name = "vdd_mif";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN_MIF>;
+ };
+
+ buck2m {
+ regulator-name = "vdd_cpucl2";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_CPUCL2_EN2>;
+ };
+
+ buck3m {
+ regulator-name = "vdd_cpucl1";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_CPUCL1_EN2>;
+ };
+
+ buck4m {
+ regulator-name = "vdd_cpucl0";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN>;
+ };
+
+ buck5m {
+ regulator-name = "vdd_int";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN_MIF>;
+ };
+
+ buck6m {
+ regulator-name = "vdd_cpucl2_m";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_CPUCL2_EN2>;
+ };
+
+ buck7m {
+ /* GPU */
+ regulator-name = "vdd_int_m";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN_MIF>;
+ };
+
+ s2mpg10_buck8m: buck8m {
+ regulator-name = "lldo2";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ };
+
+ s2mpg10_buck9m: buck9m {
+ regulator-name = "lldo3";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ };
+
+ buck10m {
+ regulator-name = "vdd_tpu";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_TPU_EN>;
+ };
+
+ ldo1m {
+ /* ALIVE, AOC PLL */
+ regulator-name = "vdd_l1m_alive";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ };
+
+ ldo2m {
+ /* lots, DDR */
+ regulator-name = "vdd_l2m_alive";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ regulator-always-on;
+ };
+
+ ldo3m {
+ /* AVDD: MIPI CSI & DSI, PLL: CPUCL SHARED TPU UFS */
+ regulator-name = "ldo3m";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN_MIF>;
+ };
+
+ ldo4m {
+ /* AVDD: MIPI CSI & DSI, UFS, OTP, TS_SUB, TS_TOP, XOTP */
+ regulator-name = "ldo4m";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN_MIF>;
+ };
+
+ ldo5m {
+ /* VDD: ADD, AVDD: TCXO & TCXO_FAR */
+ regulator-name = "avdd075_tcxo";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_TCXO_ON>;
+ };
+
+ ldo6m {
+ /* PLL CPUCL & MIFx, UFS clk, MIPI DSI */
+ regulator-name = "vdd_pll";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN_MIF>;
+ };
+
+ ldo7m {
+ /* IO (HSI (USB)) */
+ regulator-name = "vdd_hsi";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <6250>;
+ /*
+ * TODO: link to HSI power domain, without this,
+ * Linux hangs during USB access.
+ */
+ regulator-always-on;
+ };
+
+ ldo8m {
+ regulator-name = "vdd085_usb";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-always-on;
+ };
+
+ ldo9m {
+ regulator-name = "vdd18_usb";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ regulator-always-on;
+ };
+
+ ldo10m {
+ regulator-name = "vdd33_usb";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3350000>;
+ regulator-always-on;
+ };
+
+ ldo11m {
+ regulator-name = "vdd_cpucl1_m";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_CPUCL1_EN2>;
+ };
+
+ ldo12m {
+ regulator-name = "vdd_cpucl0_m";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_PWREN>;
+ };
+
+ ldo13m {
+ regulator-name = "vdd_tpu_m";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_TPU_EN>;
+ };
+
+ ldo15m {
+ regulator-name = "vdd_slc_m";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ };
+
+ ldo16m {
+ regulator-name = "vdd085_pcie0";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ };
+
+ ldo17m {
+ regulator-name = "vdd085_pcie1";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ };
+
+ ldo18m {
+ regulator-name = "vdd18_pcie0";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+
+ ldo19m {
+ regulator-name = "vdd18_pcie1";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+
+ ldo20m {
+ /* DMIC, memory power */
+ regulator-name = "vddq_aoc_pdm";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG10_EXTCTRL_LDO20M_EN2>;
+ };
+
+ ldo21m {
+ /* Dauntless */
+ regulator-name = "vdd_dtls";
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ ldo22m {
+ /* display */
+ regulator-name = "vci_disp";
+ regulator-min-microvolt = <3025000>;
+ regulator-max-microvolt = <3025000>;
+ };
+
+ ldo25m {
+ /* touch */
+ regulator-name = "dvdd_tsp";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+
+ ldo26m {
+ /* touch */
+ regulator-name = "avdd_ts";
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo27m {
+ /* under-display fingerprint scanner */
+ regulator-name = "avdd_udfps";
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ };
+ };
+
+ pmic-2 {
+ compatible = "samsung,s2mpg11-pmic";
+ interrupts-extended = <&gpa0 7 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sub_pmic_int>;
+ wakeup-source;
+
+ vinl1s-supply = <&s2mpg10_buck8m>;
+ vinl2s-supply = <&s2mpg11_buck6s>;
+ vinl3s-supply = <&s2mpg11_buck7s>;
+ vinl4s-supply = <&s2mpg11_buck7s>;
+ vinl5s-supply = <&s2mpg11_buckboost>;
+ vinl6s-supply = <&s2mpg11_buckboost>;
+ vinbd-supply = <&s2mpg11_buckboost>;
+
+ regulators {
+ buck1s {
+ /* multimedia */
+ regulator-name = "vdd_cam";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_PWREN_MIF>;
+ };
+
+ buck2s {
+ regulator-name = "vdd_g3d";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_G3D_EN>;
+ };
+
+ s2mpg11_buck3s: buck3s {
+ regulator-name = "lldo1";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ };
+
+ buck4s {
+ /* DDR */
+ regulator-name = "vdd2h_mem";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ };
+
+ buck5s {
+ /* DDR */
+ regulator-name = "vddq_mem";
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_PWREN_MIF>;
+ };
+
+ s2mpg11_buck6s: buck6s {
+ regulator-name = "lldo4";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-ramp-delay = <6250>;
+ };
+
+ s2mpg11_buck7s: buck7s {
+ regulator-name = "mldo";
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <2200000>;
+ regulator-ramp-delay = <6250>;
+ };
+
+ buck8s {
+ regulator-name = "vdd_g3d_l2";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_G3D_EN>;
+ };
+
+ buck9s {
+ regulator-name = "vdd_aoc";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ };
+
+ buck10s {
+ /* DDR */
+ regulator-name = "vdd2l_mem";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ };
+
+ buckd {
+ regulator-name = "vcc_ufs";
+ regulator-min-microvolt = <2400000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_UFS_EN>;
+ };
+
+ s2mpg11_bucka: bucka {
+ /* lots, IO */
+ regulator-name = "bucka";
+ regulator-min-microvolt = <1700000>;
+ regulator-max-microvolt = <2100000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ };
+
+ s2mpg11_buckboost: buckboost {
+ regulator-name = "buckboost";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3600000>;
+ };
+
+ ldo1s {
+ regulator-name = "vdd_g3d_m";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <6250>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_G3D_EN>;
+ };
+
+ ldo2s {
+ regulator-name = "vdd_aoc_ret";
+ regulator-min-microvolt = <450000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+ regulator-always-on;
+ };
+
+ ldo6s {
+ /* sensors */
+ regulator-name = "vdd_prox";
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo7s {
+ /* sensors */
+ regulator-name = "vdd_sensors";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+
+ ldo8s {
+ regulator-name = "vccq_ufs";
+ regulator-min-microvolt = <1130400>;
+ regulator-max-microvolt = <1281200>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_UFS_EN>;
+ };
+
+ ldo9s {
+ regulator-name = "vdd_gnss";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <1300000>;
+ };
+
+ ldo10s {
+ regulator-name = "vdd_gnss_rf";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+
+ ldo11s {
+ regulator-name = "vdd_gnss_aux";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+
+ ldo13s {
+ regulator-name = "vddq_mmc";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3350000>;
+ regulator-always-on;
+ samsung,ext-control = <S2MPG11_EXTCTRL_LDO13S_EN>;
+ };
};
};
};
@@ -317,6 +803,12 @@ pmic_int: pmic-int-pins {
samsung,pin-pud = <GS101_PIN_PULL_NONE>;
};
+ sub_pmic_int: sub-pmic-int-pins {
+ samsung,pins = "gpa0-7";
+ samsung,pin-function = <GS101_PIN_FUNC_EINT>;
+ samsung,pin-pud = <GS101_PIN_PULL_NONE>;
+ };
+
key_power: key-power-pins {
samsung,pins = "gpa10-1";
samsung,pin-function = <GS101_PIN_FUNC_EINT>;
diff --git a/arch/arm64/boot/dts/exynos/google/gs101-raven.dts b/arch/arm64/boot/dts/exynos/google/gs101-raven.dts
index 1e7e6b34b8649bc700a745c579a0268f0f6a9524..a422542715f27c8ea7a624f749b6d92e1bcb3429 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101-raven.dts
+++ b/arch/arm64/boot/dts/exynos/google/gs101-raven.dts
@@ -15,6 +15,24 @@ / {
compatible = "google,gs101-raven", "google,gs101";
};
+&acpm_ipc {
+ pmic-2 {
+ regulators {
+ ldo4s {
+ regulator-name = "vdd2_uwb";
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo14s {
+ regulator-name = "vdd3_uwb";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <1950000>;
+ };
+ };
+ };
+};
+
&cont_splash_mem {
reg = <0x0 0xfac00000 (1440 * 3120 * 4)>;
status = "okay";
---
base-commit: edf57d8dafc63f9298a209e518ea6a2e0df78ed0
change-id: 20250603-s2mpg1x-regulators-dts-aea4bde3dff9
prerequisite-change-id: 20250603-s2mpg1x-regulators-7a41c8399abf:v4
prerequisite-patch-id: 9d4a1e0afe6eb45dcd35a9537b7d5b4e35e801c3
prerequisite-patch-id: 928fd84e5f6207a2fd98dd8372a91df0776ecfde
prerequisite-patch-id: b87abb6b9a8fc104f0f752bca0e9347d17de72e0
prerequisite-patch-id: e053834e5bec411f5c512b63a3528e49aad11ee2
prerequisite-patch-id: 4fdd195c0b3fea537144ac8d82bb40a38cbde117
prerequisite-patch-id: cc716fef97d6c25c0589d7269b8f34e04ea96216
prerequisite-patch-id: 20ff503abaf2fcaef4328e1f8009ed3df242bad3
prerequisite-patch-id: a0d80e8f49401dd79a7e4dda2517e00228aa3087
prerequisite-patch-id: 2368af876ec7c643d9765d3fb1e9bc4991023a18
prerequisite-patch-id: b70d5648790458e72db82e26b180bbd7301469b3
prerequisite-patch-id: 92be1aa6f95b2a5795df84e11a602e97a41b2938
prerequisite-patch-id: 86625bb109da618cbb8aef07fa717257918077b8
prerequisite-patch-id: 2016c6cd5e0d51daddada37232e3b99c8f4ad77b
prerequisite-patch-id: d323362e84d3991bd949745579aec34897620321
prerequisite-patch-id: b1571de42ac7dcf0fe8ddb77650a656244ff751b
prerequisite-patch-id: 44ea2393bc4df716427cbac9b7f080a683ba1c0b
prerequisite-patch-id: c968c5b557897767bfc2629de79b1ede8ab48767
prerequisite-patch-id: 221800199a94e12e928dc9606c82b6eb33cffa3a
prerequisite-patch-id: c76d8055f620e0b5fa81101a31db08fd5a60e773
prerequisite-patch-id: be0027a934451be02b1c4653bac8b6bc2ae2bd85
Best regards,
--
André Draszik <andre.draszik@linaro.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: exynos: gs101-pixel: add all S2MPG1x regulators
2025-11-13 13:31 [PATCH] arm64: dts: exynos: gs101-pixel: add all S2MPG1x regulators André Draszik
@ 2025-11-17 8:11 ` Krzysztof Kozlowski
2025-11-17 8:46 ` André Draszik
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-17 8:11 UTC (permalink / raw)
To: André Draszik, Peter Griffin, Tudor Ambarus, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: Will McVicker, Juan Yescas, Douglas Anderson, kernel-team,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel
On 13/11/2025 14:31, André Draszik wrote:
> + ldo12m {
> + regulator-name = "vdd_cpucl0_m";
> + regulator-min-microvolt = <700000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-ramp-delay = <6250>;
> + regulator-always-on;
> + samsung,ext-control = <S2MPG10_EXTCTRL_PWREN>;
> + };
> +
> + ldo13m {
> + regulator-name = "vdd_tpu_m";
> + regulator-min-microvolt = <450000>;
> + regulator-max-microvolt = <950000>;
> + regulator-ramp-delay = <12500>;
> + regulator-always-on;
> + samsung,ext-control = <S2MPG10_EXTCTRL_TPU_EN>;
> + };
Please add here brief comment that ldo14m is to be defined per-board.
Same for all other cases which are missing from common DTSI.
> +
> + ldo15m {
> + regulator-name = "vdd_slc_m";
> + regulator-min-microvolt = <450000>;
> + regulator-max-microvolt = <950000>;
> + regulator-ramp-delay = <12500>;
> + regulator-always-on;
> + };
> +
> + ldo16m {
> + regulator-name = "vdd085_pcie0";
> + regulator-min-microvolt = <725000>;
> + regulator-max-microvolt = <1300000>;
> + };
> +
...
> ---
> base-commit: edf57d8dafc63f9298a209e518ea6a2e0df78ed0
> change-id: 20250603-s2mpg1x-regulators-dts-aea4bde3dff9
> prerequisite-change-id: 20250603-s2mpg1x-regulators-7a41c8399abf:v4
> prerequisite-patch-id: 9d4a1e0afe6eb45dcd35a9537b7d5b4e35e801c3
> prerequisite-patch-id: 928fd84e5f6207a2fd98dd8372a91df0776ecfde
> prerequisite-patch-id: b87abb6b9a8fc104f0f752bca0e9347d17de72e0
> prerequisite-patch-id: e053834e5bec411f5c512b63a3528e49aad11ee2
> prerequisite-patch-id: 4fdd195c0b3fea537144ac8d82bb40a38cbde117
> prerequisite-patch-id: cc716fef97d6c25c0589d7269b8f34e04ea96216
> prerequisite-patch-id: 20ff503abaf2fcaef4328e1f8009ed3df242bad3
> prerequisite-patch-id: a0d80e8f49401dd79a7e4dda2517e00228aa3087
> prerequisite-patch-id: 2368af876ec7c643d9765d3fb1e9bc4991023a18
> prerequisite-patch-id: b70d5648790458e72db82e26b180bbd7301469b3
> prerequisite-patch-id: 92be1aa6f95b2a5795df84e11a602e97a41b2938
> prerequisite-patch-id: 86625bb109da618cbb8aef07fa717257918077b8
> prerequisite-patch-id: 2016c6cd5e0d51daddada37232e3b99c8f4ad77b
> prerequisite-patch-id: d323362e84d3991bd949745579aec34897620321
> prerequisite-patch-id: b1571de42ac7dcf0fe8ddb77650a656244ff751b
> prerequisite-patch-id: 44ea2393bc4df716427cbac9b7f080a683ba1c0b
> prerequisite-patch-id: c968c5b557897767bfc2629de79b1ede8ab48767
> prerequisite-patch-id: 221800199a94e12e928dc9606c82b6eb33cffa3a
> prerequisite-patch-id: c76d8055f620e0b5fa81101a31db08fd5a60e773
> prerequisite-patch-id: be0027a934451be02b1c4653bac8b6bc2ae2bd85
This would block this from merging, so then please add RFC prefix. But
probably these are not actual dependencies, so they should not be here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: exynos: gs101-pixel: add all S2MPG1x regulators
2025-11-17 8:11 ` Krzysztof Kozlowski
@ 2025-11-17 8:46 ` André Draszik
0 siblings, 0 replies; 3+ messages in thread
From: André Draszik @ 2025-11-17 8:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, Peter Griffin, Tudor Ambarus, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: Will McVicker, Juan Yescas, Douglas Anderson, kernel-team,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel
On Mon, 2025-11-17 at 09:11 +0100, Krzysztof Kozlowski wrote:
> On 13/11/2025 14:31, André Draszik wrote:
> > + ldo12m {
> > + regulator-name = "vdd_cpucl0_m";
> > + regulator-min-microvolt = <700000>;
> > + regulator-max-microvolt = <1300000>;
> > + regulator-ramp-delay = <6250>;
> > + regulator-always-on;
> > + samsung,ext-control = <S2MPG10_EXTCTRL_PWREN>;
> > + };
> > +
> > + ldo13m {
> > + regulator-name = "vdd_tpu_m";
> > + regulator-min-microvolt = <450000>;
> > + regulator-max-microvolt = <950000>;
> > + regulator-ramp-delay = <12500>;
> > + regulator-always-on;
> > + samsung,ext-control = <S2MPG10_EXTCTRL_TPU_EN>;
> > + };
>
> Please add here brief comment that ldo14m is to be defined per-board.
> Same for all other cases which are missing from common DTSI.
Sure, can do. I assumed commit message would be enough.
> > +
> > + ldo15m {
> > + regulator-name = "vdd_slc_m";
> > + regulator-min-microvolt = <450000>;
> > + regulator-max-microvolt = <950000>;
> > + regulator-ramp-delay = <12500>;
> > + regulator-always-on;
> > + };
> > +
> > + ldo16m {
> > + regulator-name = "vdd085_pcie0";
> > + regulator-min-microvolt = <725000>;
> > + regulator-max-microvolt = <1300000>;
> > + };
> > +
>
> ...
>
> > ---
> > base-commit: edf57d8dafc63f9298a209e518ea6a2e0df78ed0
> > change-id: 20250603-s2mpg1x-regulators-dts-aea4bde3dff9
> > prerequisite-change-id: 20250603-s2mpg1x-regulators-7a41c8399abf:v4
> > prerequisite-patch-id: 9d4a1e0afe6eb45dcd35a9537b7d5b4e35e801c3
> > prerequisite-patch-id: 928fd84e5f6207a2fd98dd8372a91df0776ecfde
> > prerequisite-patch-id: b87abb6b9a8fc104f0f752bca0e9347d17de72e0
> > prerequisite-patch-id: e053834e5bec411f5c512b63a3528e49aad11ee2
> > prerequisite-patch-id: 4fdd195c0b3fea537144ac8d82bb40a38cbde117
> > prerequisite-patch-id: cc716fef97d6c25c0589d7269b8f34e04ea96216
> > prerequisite-patch-id: 20ff503abaf2fcaef4328e1f8009ed3df242bad3
> > prerequisite-patch-id: a0d80e8f49401dd79a7e4dda2517e00228aa3087
> > prerequisite-patch-id: 2368af876ec7c643d9765d3fb1e9bc4991023a18
> > prerequisite-patch-id: b70d5648790458e72db82e26b180bbd7301469b3
> > prerequisite-patch-id: 92be1aa6f95b2a5795df84e11a602e97a41b2938
> > prerequisite-patch-id: 86625bb109da618cbb8aef07fa717257918077b8
> > prerequisite-patch-id: 2016c6cd5e0d51daddada37232e3b99c8f4ad77b
> > prerequisite-patch-id: d323362e84d3991bd949745579aec34897620321
> > prerequisite-patch-id: b1571de42ac7dcf0fe8ddb77650a656244ff751b
> > prerequisite-patch-id: 44ea2393bc4df716427cbac9b7f080a683ba1c0b
> > prerequisite-patch-id: c968c5b557897767bfc2629de79b1ede8ab48767
> > prerequisite-patch-id: 221800199a94e12e928dc9606c82b6eb33cffa3a
> > prerequisite-patch-id: c76d8055f620e0b5fa81101a31db08fd5a60e773
> > prerequisite-patch-id: be0027a934451be02b1c4653bac8b6bc2ae2bd85
>
> This would block this from merging, so then please add RFC prefix. But
> probably these are not actual dependencies, so they should not be here.
I added these to highlight the dependency on the bindings updates, to avoid
validation failures. Looks like the drivers in that series will need some
updates, so bindings will also be delayed.
I'll send v2 of this here once the other series is updated, as I don't
want lingering DT validation warnings :-)
Cheers,
Andre'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-17 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13 13:31 [PATCH] arm64: dts: exynos: gs101-pixel: add all S2MPG1x regulators André Draszik
2025-11-17 8:11 ` Krzysztof Kozlowski
2025-11-17 8:46 ` André Draszik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).