* [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity
@ 2025-11-13 11:14 Xu Yang
2025-11-13 16:28 ` Frank Li
2025-11-16 13:10 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Xu Yang @ 2025-11-13 11:14 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
Frank.Li, jun.li
Cc: devicetree, imx, linux-arm-kernel, linux-kernel
According to the board design, set SEL to high means flipped
connection (TX2/RX2). And the TCPM will output logical 1 if it needs
flipped connection. So switch to active high for select-gpios.
The EN pin on mux chip is low active, so switch to active low for
enable-gpios too.
Fixes: b237975b2cd5 ("arm64: dts: imx8qm-mek: add usb 3.0 and related type C nodes")
Cc: stable@vger.kernel.org
Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
index 202d5c67ac40..9c0b6b8d6459 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
@@ -217,8 +217,8 @@ mux-controller {
compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_typec_mux>;
- select-gpios = <&lsio_gpio4 6 GPIO_ACTIVE_LOW>;
- enable-gpios = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
+ select-gpios = <&lsio_gpio4 6 GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&lsio_gpio4 19 GPIO_ACTIVE_LOW>;
orientation-switch;
port {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity
2025-11-13 11:14 [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity Xu Yang
@ 2025-11-13 16:28 ` Frank Li
2025-11-16 13:10 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-11-13 16:28 UTC (permalink / raw)
To: Xu Yang
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
jun.li, devicetree, imx, linux-arm-kernel, linux-kernel
On Thu, Nov 13, 2025 at 07:14:44PM +0800, Xu Yang wrote:
> According to the board design, set SEL to high means flipped
> connection (TX2/RX2). And the TCPM will output logical 1 if it needs
> flipped connection. So switch to active high for select-gpios.
> The EN pin on mux chip is low active, so switch to active low for
> enable-gpios too.
>
> Fixes: b237975b2cd5 ("arm64: dts: imx8qm-mek: add usb 3.0 and related type C nodes")
> Cc: stable@vger.kernel.org
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> index 202d5c67ac40..9c0b6b8d6459 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> @@ -217,8 +217,8 @@ mux-controller {
> compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_typec_mux>;
> - select-gpios = <&lsio_gpio4 6 GPIO_ACTIVE_LOW>;
> - enable-gpios = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
> + select-gpios = <&lsio_gpio4 6 GPIO_ACTIVE_HIGH>;
> + enable-gpios = <&lsio_gpio4 19 GPIO_ACTIVE_LOW>;
> orientation-switch;
>
> port {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity
2025-11-13 11:14 [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity Xu Yang
2025-11-13 16:28 ` Frank Li
@ 2025-11-16 13:10 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2025-11-16 13:10 UTC (permalink / raw)
To: Xu Yang
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
Frank.Li, jun.li, devicetree, imx, linux-arm-kernel, linux-kernel
On Thu, Nov 13, 2025 at 07:14:44PM +0800, Xu Yang wrote:
> According to the board design, set SEL to high means flipped
> connection (TX2/RX2). And the TCPM will output logical 1 if it needs
> flipped connection. So switch to active high for select-gpios.
> The EN pin on mux chip is low active, so switch to active low for
> enable-gpios too.
>
> Fixes: b237975b2cd5 ("arm64: dts: imx8qm-mek: add usb 3.0 and related type C nodes")
> Cc: stable@vger.kernel.org
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-16 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13 11:14 [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity Xu Yang
2025-11-13 16:28 ` Frank Li
2025-11-16 13:10 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).