From: Lee Jones <lee@kernel.org>
To: Alexander Kurz <akurz@blala.de>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Dzmitry Sankouski" <dsankouski@gmail.com>,
"Griffin Kroah-Hartman" <griffin.kroah@fairphone.com>,
"Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Dr . David Alan Gilbert" <linux@treblig.org>,
"Job Sava" <jsava@criticallink.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v7 3/6] Input: mc13783-pwrbutton: convert pdata members to array
Date: Thu, 13 Nov 2025 14:30:28 +0000 [thread overview]
Message-ID: <20251113143028.GJ1949330@google.com> (raw)
In-Reply-To: <20251031195718.1586-4-akurz@blala.de>
On Fri, 31 Oct 2025, Alexander Kurz wrote:
> As preparation for the extension of support for all three mc13xxx
> variants, convert the members of mc13xxx_buttons_platform_data to
> arrays to allow index access within the next commit.
>
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
> drivers/input/misc/mc13783-pwrbutton.c | 42 +++++++++++++-------------
> include/linux/mfd/mc13xxx.h | 8 ++---
Acked-by: Lee Jones <lee@kernel.org>
> 2 files changed, 23 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/input/misc/mc13783-pwrbutton.c b/drivers/input/misc/mc13783-pwrbutton.c
> index 20f68aab6edf..2ee115d77b1c 100644
> --- a/drivers/input/misc/mc13783-pwrbutton.c
> +++ b/drivers/input/misc/mc13783-pwrbutton.c
> @@ -108,24 +108,24 @@ static int mc13783_pwrbutton_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - reg |= (pdata->b1on_flags & 0x3) << MC13783_POWER_CONTROL_2_ON1BDBNC;
> - reg |= (pdata->b2on_flags & 0x3) << MC13783_POWER_CONTROL_2_ON2BDBNC;
> - reg |= (pdata->b3on_flags & 0x3) << MC13783_POWER_CONTROL_2_ON3BDBNC;
> + reg |= (pdata->b_on_flags[0] & 0x3) << MC13783_POWER_CONTROL_2_ON1BDBNC;
> + reg |= (pdata->b_on_flags[1] & 0x3) << MC13783_POWER_CONTROL_2_ON2BDBNC;
> + reg |= (pdata->b_on_flags[2] & 0x3) << MC13783_POWER_CONTROL_2_ON3BDBNC;
>
> priv->pwr = pwr;
> priv->mc13783 = mc13783;
>
> mc13xxx_lock(mc13783);
>
> - if (pdata->b1on_flags & MC13783_BUTTON_ENABLE) {
> - priv->keymap[0] = pdata->b1on_key;
> - if (pdata->b1on_key != KEY_RESERVED)
> - __set_bit(pdata->b1on_key, pwr->keybit);
> + if (pdata->b_on_flags[0] & MC13783_BUTTON_ENABLE) {
> + priv->keymap[0] = pdata->b_on_key[0];
> + if (pdata->b_on_key[0] != KEY_RESERVED)
> + __set_bit(pdata->b_on_key[0], pwr->keybit);
>
> - if (pdata->b1on_flags & MC13783_BUTTON_POL_INVERT)
> + if (pdata->b_on_flags[0] & MC13783_BUTTON_POL_INVERT)
> priv->flags |= MC13783_PWRB_B1_POL_INVERT;
>
> - if (pdata->b1on_flags & MC13783_BUTTON_RESET_EN)
> + if (pdata->b_on_flags[0] & MC13783_BUTTON_RESET_EN)
> reg |= MC13783_POWER_CONTROL_2_ON1BRSTEN;
>
> irq = platform_get_irq_byname(pdev, "b1on");
> @@ -144,15 +144,15 @@ static int mc13783_pwrbutton_probe(struct platform_device *pdev)
> priv->irq[0] = irq;
> }
>
> - if (pdata->b2on_flags & MC13783_BUTTON_ENABLE) {
> - priv->keymap[1] = pdata->b2on_key;
> - if (pdata->b2on_key != KEY_RESERVED)
> - __set_bit(pdata->b2on_key, pwr->keybit);
> + if (pdata->b_on_flags[1] & MC13783_BUTTON_ENABLE) {
> + priv->keymap[1] = pdata->b_on_key[1];
> + if (pdata->b_on_key[1] != KEY_RESERVED)
> + __set_bit(pdata->b_on_key[1], pwr->keybit);
>
> - if (pdata->b2on_flags & MC13783_BUTTON_POL_INVERT)
> + if (pdata->b_on_flags[1] & MC13783_BUTTON_POL_INVERT)
> priv->flags |= MC13783_PWRB_B2_POL_INVERT;
>
> - if (pdata->b2on_flags & MC13783_BUTTON_RESET_EN)
> + if (pdata->b_on_flags[1] & MC13783_BUTTON_RESET_EN)
> reg |= MC13783_POWER_CONTROL_2_ON2BRSTEN;
>
> irq = platform_get_irq_byname(pdev, "b2on");
> @@ -171,15 +171,15 @@ static int mc13783_pwrbutton_probe(struct platform_device *pdev)
> priv->irq[1] = irq;
> }
>
> - if (pdata->b3on_flags & MC13783_BUTTON_ENABLE) {
> - priv->keymap[2] = pdata->b3on_key;
> - if (pdata->b3on_key != KEY_RESERVED)
> - __set_bit(pdata->b3on_key, pwr->keybit);
> + if (pdata->b_on_flags[2] & MC13783_BUTTON_ENABLE) {
> + priv->keymap[2] = pdata->b_on_key[2];
> + if (pdata->b_on_key[2] != KEY_RESERVED)
> + __set_bit(pdata->b_on_key[2], pwr->keybit);
>
> - if (pdata->b3on_flags & MC13783_BUTTON_POL_INVERT)
> + if (pdata->b_on_flags[2] & MC13783_BUTTON_POL_INVERT)
> priv->flags |= MC13783_PWRB_B3_POL_INVERT;
>
> - if (pdata->b3on_flags & MC13783_BUTTON_RESET_EN)
> + if (pdata->b_on_flags[2] & MC13783_BUTTON_RESET_EN)
> reg |= MC13783_POWER_CONTROL_2_ON3BRSTEN;
>
> irq = platform_get_irq_byname(pdev, "b3on");
> diff --git a/include/linux/mfd/mc13xxx.h b/include/linux/mfd/mc13xxx.h
> index dd46fe424a80..4437ab80fcf8 100644
> --- a/include/linux/mfd/mc13xxx.h
> +++ b/include/linux/mfd/mc13xxx.h
> @@ -181,12 +181,8 @@ struct mc13xxx_leds_platform_data {
> #define MC13783_BUTTON_RESET_EN (1 << 4)
>
> struct mc13xxx_buttons_platform_data {
> - int b1on_flags;
> - unsigned short b1on_key;
> - int b2on_flags;
> - unsigned short b2on_key;
> - int b3on_flags;
> - unsigned short b3on_key;
> + int b_on_flags[3];
> + unsigned int b_on_key[3];
> };
>
> #define MC13783_TS_ATO_FIRST false
> --
> 2.39.5
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-11-13 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 19:57 [PATCH v7 0/6] Fix, extend and support OF to mc13xxx pwrbutton Alexander Kurz
2025-10-31 19:57 ` [PATCH v7 1/6] Input: mc13783-pwrbutton: use managed resources Alexander Kurz
2025-10-31 19:57 ` [PATCH v7 2/6] Input: mc13783-pwrbutton: fix irq mixup and use resources Alexander Kurz
2025-10-31 19:57 ` [PATCH v7 3/6] Input: mc13783-pwrbutton: convert pdata members to array Alexander Kurz
2025-11-13 14:30 ` Lee Jones [this message]
2025-10-31 19:57 ` [PATCH v7 4/6] Input: mc13783-pwrbutton: enable other mc13xxx PMIC Alexander Kurz
2025-10-31 19:57 ` [PATCH v7 5/6] Input: mc13783-pwrbutton: add OF support and drop platform_data Alexander Kurz
2025-11-13 14:30 ` Lee Jones
2025-10-31 19:57 ` [PATCH v7 6/6] ARM: dts: imx53: add imx53-qsrb PMIC power button Alexander Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113143028.GJ1949330@google.com \
--to=lee@kernel.org \
--cc=akurz@blala.de \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dsankouski@gmail.com \
--cc=festevam@gmail.com \
--cc=griffin.kroah@fairphone.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=jsava@criticallink.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).