[PATCH v2 0/3] regulator: Add FP9931/JD9930

[PATCH v2 0/3] regulator: Add FP9931/JD9930

[Andreas Kemnade]

Add a driver for the FP9931/JD9930 regulator which provides the
comparatively high voltages needed for electronic paper displays.

Datasheet for the FP9931 is at
https://www.fitipower.com/dl/file/flXa6hIchVeu0W3K

Although it is in English, it seems to be only downloadable
from the Chinese part of that website. 
For the JD9930 there can be a datasheet found at
https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/196/JD9930_2D00_0.7_2D00_JUN_2D00_2019.pdf

To simplify things, include the hwmon part directly which is only
one register read and there are not other functions besides
regulators in this chip.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Changes in v2:
- vendor prefix fiti->fitipower
- tdly in ms with enum
- no #thermal-sensor-cells
- regulator node names lowercase and under regulators subnode
- s/ts-en/en-ts/
- remove duplicate v3p3 of_match
- remove ancient driver.owner assignmed
- some style cleanup
- Link to v1: https://patch.msgid.link/20251107-fp9931-submit-v1-0-aa7b79d9abb6@kemnade.info

---
Andreas Kemnade (3):
      dt-bindings: vendor-prefixes: Add Fitipower
      dt-bindings: regulator: Add Fitipower FP9931/JD9930
      regulator: Add FP9931/JD9930 driver

 .../bindings/regulator/fitipower,fp9931.yaml       | 110 ++++
 .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
 drivers/regulator/Kconfig                          |  10 +
 drivers/regulator/Makefile                         |   1 +
 drivers/regulator/fp9931.c                         | 564 +++++++++++++++++++++
 5 files changed, 687 insertions(+)
---
base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
change-id: 20251107-fp9931-submit-0ac249b5d6b0

Best regards,
--  
Andreas Kemnade <andreas@kemnade.info>

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Fitipower

[Andreas Kemnade]

Add Fitipower Integrated Technology Inc. to the vendor prefixes.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index f1d1882009ba..80fbde5ac48f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -570,6 +570,8 @@ patternProperties:
     description: Foxconn Industrial Internet
   "^firefly,.*":
     description: Firefly
+  "^fitipower,.*":
+    description: Fitipower Integrated Technology Inc.
   "^flipkart,.*":
     description: Flipkart Inc.
   "^focaltech,.*":

-- 
2.47.3

Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Fitipower

[Krzysztof Kozlowski]

On Fri, Nov 14, 2025 at 12:06:41AM +0100, Andreas Kemnade wrote:
> Add Fitipower Integrated Technology Inc. to the vendor prefixes.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH v2 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930

[Andreas Kemnade]

Document the FP9931/JD9930. As the FP9931 is a clear subset of the JD9930,
define it as a fallback compatible. GPIO names are same as in the datasheet
except for the EN pad which is described as "enable".

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 .../bindings/regulator/fitipower,fp9931.yaml       | 110 +++++++++++++++++++++
 1 file changed, 110 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml b/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml
new file mode 100644
index 000000000000..28802e4518c3
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/fitipower,fp9931.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FitiPower FP9931/JD9930 Power Management Integrated Circuit
+
+maintainers:
+  - Andreas Kemnade <andreas@kemnade.info>
+
+description:
+  FP9931 is a Power Management IC to provide Power for EPDs with one 3.3V
+  switch, 2 symmetric LDOs behind 2 DC/DC converters, and one unsymmetric
+  regulator for a compensation voltage.
+  JD9930 has in addition some kind of night mode.
+
+properties:
+  compatible:
+    oneOf:
+      - const: fitipower,fp9931
+
+      - items:
+          - const: fitipower,jd9930
+          - const: fitipower,fp9931
+
+  reg:
+    maxItems: 1
+
+  enable-gpios:
+    maxItems: 1
+
+  pg-gpios:
+    maxItems: 1
+
+  en-ts-gpios:
+    maxItems: 1
+
+  xon-gpios:
+    maxItems: 1
+
+  vin-supply:
+    description:
+      Supply for the whole chip. Some vendor kernels and devicetrees
+      declare this as a non-existing GPIO named "pwrall".
+
+  fitipower,tdly-ms:
+    description:
+      Power up soft start delay settings tDLY1-4 bitfields in the
+      POWERON_DELAY register
+    items:
+      - enum: [0, 1, 2, 4]
+      - enum: [0, 1, 2, 4]
+      - enum: [0, 1, 2, 4]
+      - enum: [0, 1, 2, 4]
+
+  regulators:
+    type: object
+    additionalProperties: false
+    patternProperties:
+      "^(vcom|vposneg|v3p3)$":
+        unevaluatedProperties: false
+        type: object
+        $ref: /schemas/regulator/regulator.yaml
+
+required:
+  - compatible
+  - reg
+  - pg-gpios
+  - enable-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@18 {
+          compatible = "fitipower,fp9931";
+          reg = <0x18>;
+          pinctrl-names = "default";
+          pinctrl-0 = <&pinctrl_fp9931_gpio>;
+          vin-supply = <&epd_pmic_supply>;
+          pg-gpios = <&gpio2 7 GPIO_ACTIVE_HIGH>;
+          en-ts-gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>;
+          enable-gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
+          fitipower,tdly-ms = <2 2 4 4>;
+
+          regulators {
+            vcom {
+              regulator-name = "vcom";
+              regulator-min-microvolt = <2352840>;
+              regulator-max-microvolt = <2352840>;
+            };
+
+            vposneg {
+              regulator-name = "vposneg";
+              regulator-min-microvolt = <15060000>;
+              regulator-max-microvolt = <15060000>;
+            };
+
+            v3p3 {
+              regulator-name = "v3p3";
+            };
+          };
+        };
+    };

-- 
2.47.3

Re: [PATCH v2 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930

[Krzysztof Kozlowski]

On Fri, Nov 14, 2025 at 12:06:42AM +0100, Andreas Kemnade wrote:
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@18 {
> +          compatible = "fitipower,fp9931";

If there is going to be new version, please use consistent indentation,
4 spaces. I think I missed this last time.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH v2 3/3] regulator: Add FP9931/JD9930 driver

[Andreas Kemnade]

Add a driver for the FP9931/JD9930 regulator. Implement handling of the PG
(power good), TS_EN (temperature sensor enable), and EN (enable regulators)
pins. Implement the pair of symmetric LDOs as a single regulator because
they share a single voltage set register. For simplicity, just add the
temperature sensor (depending on external NTC) directly.

Limitations:
- As these regulators are controlled together with the VCOM regulator via
  the EN pin, some kind of management must be in place. As the enable op
  is not called when the regulator is already enabled, simple refcounting
  seems not to work to avoid clearing EN when one regulator is still
  enabled. As these regulators are typically used together, this
  limitation should not hurt hard, just provide the is_enabled op.
- As the VCOM step is quite odd (5V/255 steps), rounding is needed.
  Due to some limitations in the regulator core, the max/min voltages in
  the devicetree must match the idea of the driver how to round things
  exactly.
- Night mode is not implemented, so only the FP9931 compatible is needed in
  the driver, there is no REGULATOR_MODE_NIGHT and no clear definition in
  the datasheet what it does, also the XON pin which seems to be an input
  related to that night mode is not used.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/regulator/Kconfig  |  10 +
 drivers/regulator/Makefile |   1 +
 drivers/regulator/fp9931.c | 564 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 575 insertions(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index d84f3d054c59..c817a4cc00c8 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -500,6 +500,16 @@ config REGULATOR_ISL6271A
 	help
 	  This driver supports ISL6271A voltage regulator chip.
 
+config REGULATOR_FP9931
+	tristate "FitiPower FP9931/JD9930 EPD regulator"
+	depends on I2C
+	select REGMAP_I2C
+	help
+	  This driver supports the FP9931/JD9930 voltage regulator chip
+	  which is used to provide power to Electronic Paper Displays
+	  so it is found in E-Book readers.
+	  If HWWON is enabled, it also provides temperature measurement.
+
 config REGULATOR_LM363X
 	tristate "TI LM363X voltage regulators"
 	depends on MFD_TI_LMU
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index b3101376029d..98a02c854044 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -59,6 +59,7 @@ obj-$(CONFIG_REGULATOR_HI6421V600) += hi6421v600-regulator.o
 obj-$(CONFIG_REGULATOR_HI655X) += hi655x-regulator.o
 obj-$(CONFIG_REGULATOR_ISL6271A) += isl6271a-regulator.o
 obj-$(CONFIG_REGULATOR_ISL9305) += isl9305.o
+obj-$(CONFIG_REGULATOR_FP9931) += fp9931.o
 obj-$(CONFIG_REGULATOR_LM363X) += lm363x-regulator.o
 obj-$(CONFIG_REGULATOR_LOCHNAGAR) += lochnagar-regulator.o
 obj-$(CONFIG_REGULATOR_LP3971) += lp3971.o
diff --git a/drivers/regulator/fp9931.c b/drivers/regulator/fp9931.c
new file mode 100644
index 000000000000..7e3df5f2ccb9
--- /dev/null
+++ b/drivers/regulator/fp9931.c
@@ -0,0 +1,564 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (C) 2025 Andreas Kemnade
+
+/* Datasheet: https://www.fitipower.com/dl/file/flXa6hIchVeu0W3K */
+
+#include <linux/cleanup.h>
+#include <linux/completion.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/hwmon.h>
+#include <linux/pm_runtime.h>
+#include <linux/property.h>
+#include <linux/regulator/consumer.h>
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>
+#include <linux/regmap.h>
+
+#define FP9931_REG_TMST_VALUE 0
+#define FP9931_REG_VCOM_SETTING 1
+#define FP9931_REG_VPOSNEG_SETTING 2
+#define FP9931_REG_PWRON_DELAY 3
+#define FP9931_REG_CONTROL_REG1 11
+
+#define PGOOD_TIMEOUT_MSECS 200
+
+struct fp9931_data {
+	struct device *dev;
+	struct regmap *regmap;
+	struct regulator *vin_reg;
+	struct gpio_desc *pgood_gpio;
+	struct gpio_desc *en_gpio;
+	struct gpio_desc *en_ts_gpio;
+	struct completion pgood_completion;
+	int pgood_irq;
+};
+
+static const unsigned int VPOSNEG_table[] = {
+	7040000,
+	7040000,
+	7040000,
+	7040000,
+	7040000,
+	7040000,
+	7260000,
+	7490000,
+	7710000,
+	7930000,
+	8150000,
+	8380000,
+	8600000,
+	8820000,
+	9040000,
+	9270000,
+	9490000,
+	9710000,
+	9940000,
+	10160000,
+	10380000,
+	10600000,
+	10830000,
+	11050000,
+	11270000,
+	11490000,
+	11720000,
+	11940000,
+	12160000,
+	12380000,
+	12610000,
+	12830000,
+	13050000,
+	13280000,
+	13500000,
+	13720000,
+	13940000,
+	14170000,
+	14390000,
+	14610000,
+	14830000,
+	15060000,
+};
+
+static const struct hwmon_channel_info *fp9931_info[] = {
+	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
+	HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT),
+	NULL
+};
+
+static int setup_timings(struct fp9931_data *data)
+{
+	u32 tdly[4];
+	u8 tdlys = 0;
+	int i;
+	int ret;
+
+	ret = device_property_count_u32(data->dev, "fitipower,tdly-ms");
+	if (ret == -EINVAL) /* property is optional */
+		return 0;
+
+	if (ret < 0)
+		return ret;
+
+	if (ret != ARRAY_SIZE(tdly)) {
+		dev_err(data->dev, "invalid delay specification");
+		return -EINVAL;
+	}
+
+	ret = device_property_read_u32_array(data->dev, "fitipower,tdly-ms",
+					     tdly, ARRAY_SIZE(tdly));
+	if (ret)
+		return ret;
+
+	for (i = ARRAY_SIZE(tdly) - 1; i >= 0; i--) {
+		if (tdly[i] > 4 || tdly[i] == 3)
+			return -EINVAL;
+
+		if (tdly[i] == 4) /* convert from ms */
+			tdly[i] = 3;
+
+		tdlys <<= 2;
+		tdlys |= tdly[i];
+	}
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return ret;
+
+	ret = regmap_write(data->regmap, FP9931_REG_PWRON_DELAY, tdlys);
+	pm_runtime_put_autosuspend(data->dev);
+
+	return ret;
+}
+
+static int fp9931_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
+			     u32 attr, int channel, long *temp)
+{
+	struct fp9931_data *data = dev_get_drvdata(dev);
+	unsigned int val;
+	s8 signed_val;
+	int ret;
+
+	if (attr != hwmon_temp_input)
+		return -EOPNOTSUPP;
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return ret;
+
+	ret = regmap_read(data->regmap, FP9931_REG_TMST_VALUE, &val);
+	if (ret)
+		return ret;
+
+	pm_runtime_put_autosuspend(data->dev);
+	signed_val = (s8)val;
+
+	*temp = signed_val;
+	*temp = *temp * 1000;
+
+	return 0;
+}
+
+static umode_t fp9931_hwmon_is_visible(const void *data,
+				       enum hwmon_sensor_types type,
+				       u32 attr, int channel)
+{
+	if (type != hwmon_temp)
+		return 0;
+
+	if (attr != hwmon_temp_input)
+		return 0;
+
+	return 0444;
+}
+
+static const struct hwmon_ops fp9931_hwmon_ops = {
+	.is_visible = fp9931_hwmon_is_visible,
+	.read = fp9931_hwmon_read,
+};
+
+static const struct hwmon_chip_info fp9931_chip_info = {
+	.ops = &fp9931_hwmon_ops,
+	.info = fp9931_info,
+};
+
+static int fp9931_runtime_suspend(struct device *dev)
+{
+	int ret = 0;
+	struct fp9931_data *data = dev_get_drvdata(dev);
+
+	if (data->en_ts_gpio)
+		gpiod_set_value_cansleep(data->en_ts_gpio, 0);
+
+	if (data->vin_reg) {
+		ret = regulator_disable(data->vin_reg);
+		regcache_mark_dirty(data->regmap);
+	}
+
+	return ret;
+}
+
+static int fp9931_runtime_resume(struct device *dev)
+{
+	int ret = 0;
+	struct fp9931_data *data = dev_get_drvdata(dev);
+
+	if (data->vin_reg)
+		ret = regulator_enable(data->vin_reg);
+
+	if (ret)
+		return ret;
+
+	if (data->en_ts_gpio) {
+		gpiod_set_value_cansleep(data->en_ts_gpio, 1);
+		/* wait for one ADC conversion to have sane temperature */
+		usleep_range(10000, 15000);
+	}
+
+	ret = regcache_sync(data->regmap);
+
+	return ret;
+}
+
+static bool fp9931_volatile_reg(struct device *dev, unsigned int reg)
+{
+	return reg == FP9931_REG_TMST_VALUE;
+}
+
+static const struct reg_default fp9931_reg_default = {
+	.reg = FP9931_REG_VCOM_SETTING,
+	.def = 0x80,
+};
+
+static const struct regmap_config regmap_config = {
+	.reg_bits = 8,
+	.val_bits = 8,
+	.max_register = 12,
+	.cache_type = REGCACHE_FLAT,
+	.volatile_reg = fp9931_volatile_reg,
+	.reg_defaults = &fp9931_reg_default,
+	.num_reg_defaults = 1,
+};
+
+static void disable_nopm(void *d)
+{
+	struct fp9931_data *data = d;
+
+	fp9931_runtime_suspend(data->dev);
+}
+
+static int fp9931_v3p3_enable(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+	int ret;
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return ret;
+
+	ret = regulator_enable_regmap(rdev);
+	if (ret < 0)
+		pm_runtime_put_autosuspend(data->dev);
+
+	return ret;
+}
+
+static int fp9931_v3p3_disable(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+	int ret;
+
+	ret = regulator_disable_regmap(rdev);
+	pm_runtime_put_autosuspend(data->dev);
+
+	return ret;
+}
+
+static int fp9931_v3p3_is_enabled(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+	int ret;
+
+	if (pm_runtime_status_suspended(data->dev))
+		return 0;
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return 0;
+
+	ret = regulator_is_enabled_regmap(rdev);
+
+	pm_runtime_put_autosuspend(data->dev);
+	return ret;
+}
+
+static const struct regulator_ops fp9931_v3p3ops = {
+	.list_voltage = regulator_list_voltage_linear,
+	.enable = fp9931_v3p3_enable,
+	.disable = fp9931_v3p3_disable,
+	.is_enabled = fp9931_v3p3_is_enabled,
+};
+
+static int fp9931_check_powergood(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+
+	if (pm_runtime_status_suspended(data->dev))
+		return 0;
+
+	return gpiod_get_value_cansleep(data->pgood_gpio);
+}
+
+static int fp9931_get_voltage_sel(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+	int ret;
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return ret;
+
+	ret = regulator_get_voltage_sel_regmap(rdev);
+	pm_runtime_put_autosuspend(data->dev);
+
+	return ret;
+}
+
+static int fp9931_set_voltage_sel(struct regulator_dev *rdev, unsigned int selector)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+	int ret;
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return ret;
+
+	ret = regulator_set_voltage_sel_regmap(rdev, selector);
+	pm_runtime_put_autosuspend(data->dev);
+
+	return ret;
+}
+
+static irqreturn_t pgood_handler(int irq, void *dev_id)
+{
+	struct fp9931_data *data = dev_id;
+
+	complete(&data->pgood_completion);
+
+	return IRQ_HANDLED;
+}
+
+static int fp9931_set_enable(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+	int ret;
+
+	ret = pm_runtime_resume_and_get(data->dev);
+	if (ret < 0)
+		return ret;
+
+	reinit_completion(&data->pgood_completion);
+	gpiod_set_value_cansleep(data->en_gpio, 1);
+	dev_dbg(data->dev, "turning on...");
+	wait_for_completion_timeout(&data->pgood_completion,
+				    msecs_to_jiffies(PGOOD_TIMEOUT_MSECS));
+	dev_dbg(data->dev, "turned on");
+	if (gpiod_get_value_cansleep(data->pgood_gpio) != 1) {
+		pm_runtime_put_autosuspend(data->dev);
+		return -ETIMEDOUT;
+	}
+
+	return 0;
+}
+
+static int fp9931_clear_enable(struct regulator_dev *rdev)
+{
+	struct fp9931_data *data = rdev_get_drvdata(rdev);
+
+	gpiod_set_value_cansleep(data->en_gpio, 0);
+	pm_runtime_put_autosuspend(data->dev);
+	return 0;
+}
+
+static const struct regulator_ops fp9931_vcom_ops = {
+	.list_voltage = regulator_list_voltage_linear,
+	.map_voltage = regulator_map_voltage_linear,
+	.enable = fp9931_set_enable,
+	.disable = fp9931_clear_enable,
+	.is_enabled = fp9931_check_powergood,
+	.set_voltage_sel = fp9931_set_voltage_sel,
+	.get_voltage_sel = fp9931_get_voltage_sel,
+};
+
+static const struct regulator_ops fp9931_vposneg_ops = {
+	.list_voltage = regulator_list_voltage_table,
+	.map_voltage = regulator_map_voltage_ascend,
+	/* gets enabled by enabling vcom, too */
+	.is_enabled = fp9931_check_powergood,
+	.set_voltage_sel = fp9931_set_voltage_sel,
+	.get_voltage_sel = fp9931_get_voltage_sel,
+};
+
+static const struct regulator_desc regulators[] = {
+	{
+		.name = "v3p3",
+		.of_match = of_match_ptr("v3p3"),
+		.id = 0,
+		.ops = &fp9931_v3p3ops,
+		.type = REGULATOR_VOLTAGE,
+		.owner = THIS_MODULE,
+		.enable_reg = FP9931_REG_CONTROL_REG1,
+		.enable_mask = BIT(1),
+		.n_voltages = 1,
+		.min_uV = 3300000
+	},
+	{
+		.name = "vposneg",
+		.of_match = of_match_ptr("vposneg"),
+		.id = 1,
+		.ops = &fp9931_vposneg_ops,
+		.type = REGULATOR_VOLTAGE,
+		.owner = THIS_MODULE,
+		.n_voltages = ARRAY_SIZE(VPOSNEG_table),
+		.vsel_reg = FP9931_REG_VPOSNEG_SETTING,
+		.vsel_mask = 0x3F,
+		.volt_table = VPOSNEG_table,
+	},
+	{
+		.name = "vcom",
+		.of_match = of_match_ptr("vcom"),
+		.id = 2,
+		.ops = &fp9931_vcom_ops,
+		.type = REGULATOR_VOLTAGE,
+		.owner = THIS_MODULE,
+		.n_voltages = 255,
+		.min_uV = 0,
+		.uV_step = 5000000 / 255,
+		.vsel_reg = FP9931_REG_VCOM_SETTING,
+		.vsel_mask = 0xFF
+	},
+};
+
+static int fp9931_probe(struct i2c_client *client)
+{
+	struct fp9931_data *data;
+	struct regulator_config config = { };
+	struct regulator_dev *rdev;
+	int ret = 0;
+	int i;
+
+	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
+	data->regmap = devm_regmap_init_i2c(client, &regmap_config);
+	if (IS_ERR(data->regmap))
+		return dev_err_probe(&client->dev, PTR_ERR(data->regmap),
+				     "failed to allocate regmap!\n");
+
+	data->vin_reg = devm_regulator_get_optional(&client->dev, "vin");
+	if (IS_ERR(data->vin_reg))
+		return dev_err_probe(&client->dev, PTR_ERR(data->vin_reg),
+				     "failid to get vin regulator\n");
+
+	data->pgood_gpio = devm_gpiod_get(&client->dev, "pg", GPIOD_IN);
+	if (IS_ERR(data->pgood_gpio))
+		return dev_err_probe(&client->dev,
+				     PTR_ERR(data->pgood_gpio),
+				     "failed to get power good gpio\n");
+
+	data->pgood_irq = gpiod_to_irq(data->pgood_gpio);
+	if (data->pgood_irq < 0)
+		return data->pgood_irq;
+
+	data->en_gpio = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW);
+	if (IS_ERR(data->en_gpio))
+		return dev_err_probe(&client->dev, PTR_ERR(data->en_gpio),
+				     "failed to get en gpio\n");
+
+	data->en_ts_gpio = devm_gpiod_get_optional(&client->dev, "en-ts", GPIOD_OUT_LOW);
+	if (IS_ERR(data->en_ts_gpio))
+		return dev_err_probe(&client->dev,
+				     PTR_ERR(data->en_ts_gpio),
+				     "failed to get en gpio\n");
+
+	data->dev = &client->dev;
+	i2c_set_clientdata(client, data);
+
+	init_completion(&data->pgood_completion);
+
+	ret = devm_request_threaded_irq(&client->dev, data->pgood_irq, NULL,
+					pgood_handler,
+					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					"PGOOD", data);
+	if (ret)
+		return dev_err_probe(&client->dev, ret,
+				     "failed to request irq\n");
+
+	if (IS_ENABLED(CONFIG_PM)) {
+		devm_pm_runtime_enable(&client->dev);
+		pm_runtime_set_autosuspend_delay(&client->dev, 4000);
+		pm_runtime_use_autosuspend(&client->dev);
+	} else {
+		ret = fp9931_runtime_resume(&client->dev);
+		if (ret < 0)
+			return ret;
+
+		devm_add_action_or_reset(&client->dev, disable_nopm, data);
+	}
+
+	ret = setup_timings(data);
+	if (ret)
+		return dev_err_probe(&client->dev, ret, "failed to setup timings\n");
+
+	config.driver_data = data;
+	config.dev = &client->dev;
+	config.regmap = data->regmap;
+
+	for (i = 0; i < ARRAY_SIZE(regulators); i++) {
+		rdev = devm_regulator_register(&client->dev, &regulators[i],
+					       &config);
+		if (IS_ERR(rdev))
+			return dev_err_probe(&client->dev, PTR_ERR(rdev),
+					     "failed to register %s regulator\n",
+					     regulators[i].name);
+	}
+
+	if (IS_REACHABLE(CONFIG_HWMON)) {
+		struct device *hwmon_dev;
+
+		hwmon_dev = devm_hwmon_device_register_with_info(&client->dev, "fp9931", data,
+								 &fp9931_chip_info, NULL);
+		if (IS_ERR(hwmon_dev))
+			dev_err(&client->dev, "failed to register hwmon\n");
+	}
+
+	return 0;
+}
+
+static const struct dev_pm_ops fp9931_pm_ops = {
+	SET_RUNTIME_PM_OPS(fp9931_runtime_suspend, fp9931_runtime_resume, NULL)
+};
+
+static const struct of_device_id fp9931_dt_ids[] = {
+	{
+		.compatible = "fitipower,fp9931",
+	}, {
+		/* sentinel */
+	}
+};
+MODULE_DEVICE_TABLE(of, fp9931_dt_ids);
+
+static struct i2c_driver fp9931_i2c_driver = {
+	.driver = {
+		   .name = "fp9931",
+		   .of_match_table = fp9931_dt_ids,
+		   .pm = &fp9931_pm_ops,
+	},
+	.probe = fp9931_probe,
+};
+
+module_i2c_driver(fp9931_i2c_driver);
+
+/* Module information */
+MODULE_DESCRIPTION("FP9931 regulator driver");
+MODULE_LICENSE("GPL");
+

-- 
2.47.3

Re: [PATCH v2 3/3] regulator: Add FP9931/JD9930 driver

[Guenter Roeck]

On 11/13/25 15:06, Andreas Kemnade wrote:
> Add a driver for the FP9931/JD9930 regulator. Implement handling of the PG
> (power good), TS_EN (temperature sensor enable), and EN (enable regulators)
> pins. Implement the pair of symmetric LDOs as a single regulator because
> they share a single voltage set register. For simplicity, just add the
> temperature sensor (depending on external NTC) directly.
> 
> Limitations:
> - As these regulators are controlled together with the VCOM regulator via
>    the EN pin, some kind of management must be in place. As the enable op
>    is not called when the regulator is already enabled, simple refcounting
>    seems not to work to avoid clearing EN when one regulator is still
>    enabled. As these regulators are typically used together, this
>    limitation should not hurt hard, just provide the is_enabled op.
> - As the VCOM step is quite odd (5V/255 steps), rounding is needed.
>    Due to some limitations in the regulator core, the max/min voltages in
>    the devicetree must match the idea of the driver how to round things
>    exactly.
> - Night mode is not implemented, so only the FP9931 compatible is needed in
>    the driver, there is no REGULATOR_MODE_NIGHT and no clear definition in
>    the datasheet what it does, also the XON pin which seems to be an input
>    related to that night mode is not used.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>   drivers/regulator/Kconfig  |  10 +
>   drivers/regulator/Makefile |   1 +
>   drivers/regulator/fp9931.c | 564 +++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 575 insertions(+)
> 
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index d84f3d054c59..c817a4cc00c8 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -500,6 +500,16 @@ config REGULATOR_ISL6271A
>   	help
>   	  This driver supports ISL6271A voltage regulator chip.
>   
> +config REGULATOR_FP9931
> +	tristate "FitiPower FP9931/JD9930 EPD regulator"
> +	depends on I2C
> +	select REGMAP_I2C
> +	help
> +	  This driver supports the FP9931/JD9930 voltage regulator chip
> +	  which is used to provide power to Electronic Paper Displays
> +	  so it is found in E-Book readers.
> +	  If HWWON is enabled, it also provides temperature measurement.
> +
>   config REGULATOR_LM363X
>   	tristate "TI LM363X voltage regulators"
>   	depends on MFD_TI_LMU
> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
> index b3101376029d..98a02c854044 100644
> --- a/drivers/regulator/Makefile
> +++ b/drivers/regulator/Makefile
> @@ -59,6 +59,7 @@ obj-$(CONFIG_REGULATOR_HI6421V600) += hi6421v600-regulator.o
>   obj-$(CONFIG_REGULATOR_HI655X) += hi655x-regulator.o
>   obj-$(CONFIG_REGULATOR_ISL6271A) += isl6271a-regulator.o
>   obj-$(CONFIG_REGULATOR_ISL9305) += isl9305.o
> +obj-$(CONFIG_REGULATOR_FP9931) += fp9931.o
>   obj-$(CONFIG_REGULATOR_LM363X) += lm363x-regulator.o
>   obj-$(CONFIG_REGULATOR_LOCHNAGAR) += lochnagar-regulator.o
>   obj-$(CONFIG_REGULATOR_LP3971) += lp3971.o
> diff --git a/drivers/regulator/fp9931.c b/drivers/regulator/fp9931.c
> new file mode 100644
> index 000000000000..7e3df5f2ccb9
> --- /dev/null
> +++ b/drivers/regulator/fp9931.c
> @@ -0,0 +1,564 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Copyright (C) 2025 Andreas Kemnade
> +
> +/* Datasheet: https://www.fitipower.com/dl/file/flXa6hIchVeu0W3K */
> +
> +#include <linux/cleanup.h>
> +#include <linux/completion.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/hwmon.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/property.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>
> +#include <linux/regmap.h>
> +
> +#define FP9931_REG_TMST_VALUE 0
> +#define FP9931_REG_VCOM_SETTING 1
> +#define FP9931_REG_VPOSNEG_SETTING 2
> +#define FP9931_REG_PWRON_DELAY 3
> +#define FP9931_REG_CONTROL_REG1 11
> +
> +#define PGOOD_TIMEOUT_MSECS 200
> +
> +struct fp9931_data {
> +	struct device *dev;
> +	struct regmap *regmap;
> +	struct regulator *vin_reg;
> +	struct gpio_desc *pgood_gpio;
> +	struct gpio_desc *en_gpio;
> +	struct gpio_desc *en_ts_gpio;
> +	struct completion pgood_completion;
> +	int pgood_irq;
> +};
> +
> +static const unsigned int VPOSNEG_table[] = {
> +	7040000,
> +	7040000,
> +	7040000,
> +	7040000,
> +	7040000,
> +	7040000,
> +	7260000,
> +	7490000,
> +	7710000,
> +	7930000,
> +	8150000,
> +	8380000,
> +	8600000,
> +	8820000,
> +	9040000,
> +	9270000,
> +	9490000,
> +	9710000,
> +	9940000,
> +	10160000,
> +	10380000,
> +	10600000,
> +	10830000,
> +	11050000,
> +	11270000,
> +	11490000,
> +	11720000,
> +	11940000,
> +	12160000,
> +	12380000,
> +	12610000,
> +	12830000,
> +	13050000,
> +	13280000,
> +	13500000,
> +	13720000,
> +	13940000,
> +	14170000,
> +	14390000,
> +	14610000,
> +	14830000,
> +	15060000,
> +};
> +
> +static const struct hwmon_channel_info *fp9931_info[] = {
> +	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
> +	HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT),
> +	NULL
> +};
> +
> +static int setup_timings(struct fp9931_data *data)
> +{
> +	u32 tdly[4];
> +	u8 tdlys = 0;
> +	int i;
> +	int ret;
> +
> +	ret = device_property_count_u32(data->dev, "fitipower,tdly-ms");
> +	if (ret == -EINVAL) /* property is optional */
> +		return 0;
> +
> +	if (ret < 0)
> +		return ret;
> +
> +	if (ret != ARRAY_SIZE(tdly)) {
> +		dev_err(data->dev, "invalid delay specification");
> +		return -EINVAL;
> +	}
> +
> +	ret = device_property_read_u32_array(data->dev, "fitipower,tdly-ms",
> +					     tdly, ARRAY_SIZE(tdly));
> +	if (ret)
> +		return ret;
> +
> +	for (i = ARRAY_SIZE(tdly) - 1; i >= 0; i--) {
> +		if (tdly[i] > 4 || tdly[i] == 3)
> +			return -EINVAL;
> +
> +		if (tdly[i] == 4) /* convert from ms */
> +			tdly[i] = 3;
> +
> +		tdlys <<= 2;
> +		tdlys |= tdly[i];
> +	}
> +
> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = regmap_write(data->regmap, FP9931_REG_PWRON_DELAY, tdlys);
> +	pm_runtime_put_autosuspend(data->dev);
> +
> +	return ret;
> +}
> +
> +static int fp9931_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
> +			     u32 attr, int channel, long *temp)
> +{
> +	struct fp9931_data *data = dev_get_drvdata(dev);
> +	unsigned int val;
> +	s8 signed_val;
> +	int ret;
> +
> +	if (attr != hwmon_temp_input)
> +		return -EOPNOTSUPP;
> +

This doesn't hurt, but it is unnecessary.

> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = regmap_read(data->regmap, FP9931_REG_TMST_VALUE, &val);
> +	if (ret)
> +		return ret;
> +
> +	pm_runtime_put_autosuspend(data->dev);
> +	signed_val = (s8)val;
> +
> +	*temp = signed_val;
> +	*temp = *temp * 1000;

	*temp = (s8)val * 1000;

would do just as well.

> +
> +	return 0;
> +}
> +
> +static umode_t fp9931_hwmon_is_visible(const void *data,
> +				       enum hwmon_sensor_types type,
> +				       u32 attr, int channel)
> +{
> +	if (type != hwmon_temp)
> +		return 0;
> +
> +	if (attr != hwmon_temp_input)
> +		return 0;
> +

Not that it matters (much), but those checks are unnecessary.

> +	return 0444;
> +}
> +
> +static const struct hwmon_ops fp9931_hwmon_ops = {
> +	.is_visible = fp9931_hwmon_is_visible,
> +	.read = fp9931_hwmon_read,
> +};
> +
> +static const struct hwmon_chip_info fp9931_chip_info = {
> +	.ops = &fp9931_hwmon_ops,
> +	.info = fp9931_info,
> +};
> +
> +static int fp9931_runtime_suspend(struct device *dev)
> +{
> +	int ret = 0;
> +	struct fp9931_data *data = dev_get_drvdata(dev);
> +
> +	if (data->en_ts_gpio)
> +		gpiod_set_value_cansleep(data->en_ts_gpio, 0);
> +
> +	if (data->vin_reg) {
> +		ret = regulator_disable(data->vin_reg);
> +		regcache_mark_dirty(data->regmap);
> +	}
> +
> +	return ret;
> +}
> +
> +static int fp9931_runtime_resume(struct device *dev)
> +{
> +	int ret = 0;
> +	struct fp9931_data *data = dev_get_drvdata(dev);
> +
> +	if (data->vin_reg)
> +		ret = regulator_enable(data->vin_reg);
> +
> +	if (ret)
> +		return ret;
> +
> +	if (data->en_ts_gpio) {
> +		gpiod_set_value_cansleep(data->en_ts_gpio, 1);
> +		/* wait for one ADC conversion to have sane temperature */
> +		usleep_range(10000, 15000);
> +	}
> +
> +	ret = regcache_sync(data->regmap);
> +
> +	return ret;
> +}
> +
> +static bool fp9931_volatile_reg(struct device *dev, unsigned int reg)
> +{
> +	return reg == FP9931_REG_TMST_VALUE;
> +}
> +
> +static const struct reg_default fp9931_reg_default = {
> +	.reg = FP9931_REG_VCOM_SETTING,
> +	.def = 0x80,
> +};
> +
> +static const struct regmap_config regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +	.max_register = 12,
> +	.cache_type = REGCACHE_FLAT,
> +	.volatile_reg = fp9931_volatile_reg,
> +	.reg_defaults = &fp9931_reg_default,
> +	.num_reg_defaults = 1,
> +};
> +
> +static void disable_nopm(void *d)
> +{
> +	struct fp9931_data *data = d;
> +
> +	fp9931_runtime_suspend(data->dev);
> +}
> +
> +static int fp9931_v3p3_enable(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +	int ret;
> +
> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = regulator_enable_regmap(rdev);
> +	if (ret < 0)
> +		pm_runtime_put_autosuspend(data->dev);
> +
> +	return ret;
> +}
> +
> +static int fp9931_v3p3_disable(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +	int ret;
> +
> +	ret = regulator_disable_regmap(rdev);
> +	pm_runtime_put_autosuspend(data->dev);
> +
> +	return ret;
> +}
> +
> +static int fp9931_v3p3_is_enabled(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +	int ret;
> +
> +	if (pm_runtime_status_suspended(data->dev))
> +		return 0;
> +
> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return 0;
> +
> +	ret = regulator_is_enabled_regmap(rdev);
> +
> +	pm_runtime_put_autosuspend(data->dev);
> +	return ret;
> +}
> +
> +static const struct regulator_ops fp9931_v3p3ops = {
> +	.list_voltage = regulator_list_voltage_linear,
> +	.enable = fp9931_v3p3_enable,
> +	.disable = fp9931_v3p3_disable,
> +	.is_enabled = fp9931_v3p3_is_enabled,
> +};
> +
> +static int fp9931_check_powergood(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +
> +	if (pm_runtime_status_suspended(data->dev))
> +		return 0;
> +
> +	return gpiod_get_value_cansleep(data->pgood_gpio);
> +}
> +
> +static int fp9931_get_voltage_sel(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +	int ret;
> +
> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = regulator_get_voltage_sel_regmap(rdev);
> +	pm_runtime_put_autosuspend(data->dev);
> +
> +	return ret;
> +}
> +
> +static int fp9931_set_voltage_sel(struct regulator_dev *rdev, unsigned int selector)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +	int ret;
> +
> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = regulator_set_voltage_sel_regmap(rdev, selector);
> +	pm_runtime_put_autosuspend(data->dev);
> +
> +	return ret;
> +}
> +
> +static irqreturn_t pgood_handler(int irq, void *dev_id)
> +{
> +	struct fp9931_data *data = dev_id;
> +
> +	complete(&data->pgood_completion);
> +
> +	return IRQ_HANDLED;
> +}
> +
> +static int fp9931_set_enable(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +	int ret;
> +
> +	ret = pm_runtime_resume_and_get(data->dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	reinit_completion(&data->pgood_completion);
> +	gpiod_set_value_cansleep(data->en_gpio, 1);
> +	dev_dbg(data->dev, "turning on...");
> +	wait_for_completion_timeout(&data->pgood_completion,
> +				    msecs_to_jiffies(PGOOD_TIMEOUT_MSECS));
> +	dev_dbg(data->dev, "turned on");
> +	if (gpiod_get_value_cansleep(data->pgood_gpio) != 1) {
> +		pm_runtime_put_autosuspend(data->dev);
> +		return -ETIMEDOUT;
> +	}
> +
> +	return 0;
> +}
> +
> +static int fp9931_clear_enable(struct regulator_dev *rdev)
> +{
> +	struct fp9931_data *data = rdev_get_drvdata(rdev);
> +
> +	gpiod_set_value_cansleep(data->en_gpio, 0);
> +	pm_runtime_put_autosuspend(data->dev);
> +	return 0;
> +}
> +
> +static const struct regulator_ops fp9931_vcom_ops = {
> +	.list_voltage = regulator_list_voltage_linear,
> +	.map_voltage = regulator_map_voltage_linear,
> +	.enable = fp9931_set_enable,
> +	.disable = fp9931_clear_enable,
> +	.is_enabled = fp9931_check_powergood,
> +	.set_voltage_sel = fp9931_set_voltage_sel,
> +	.get_voltage_sel = fp9931_get_voltage_sel,
> +};
> +
> +static const struct regulator_ops fp9931_vposneg_ops = {
> +	.list_voltage = regulator_list_voltage_table,
> +	.map_voltage = regulator_map_voltage_ascend,
> +	/* gets enabled by enabling vcom, too */
> +	.is_enabled = fp9931_check_powergood,
> +	.set_voltage_sel = fp9931_set_voltage_sel,
> +	.get_voltage_sel = fp9931_get_voltage_sel,
> +};
> +
> +static const struct regulator_desc regulators[] = {
> +	{
> +		.name = "v3p3",
> +		.of_match = of_match_ptr("v3p3"),
> +		.id = 0,
> +		.ops = &fp9931_v3p3ops,
> +		.type = REGULATOR_VOLTAGE,
> +		.owner = THIS_MODULE,
> +		.enable_reg = FP9931_REG_CONTROL_REG1,
> +		.enable_mask = BIT(1),
> +		.n_voltages = 1,
> +		.min_uV = 3300000
> +	},
> +	{
> +		.name = "vposneg",
> +		.of_match = of_match_ptr("vposneg"),
> +		.id = 1,
> +		.ops = &fp9931_vposneg_ops,
> +		.type = REGULATOR_VOLTAGE,
> +		.owner = THIS_MODULE,
> +		.n_voltages = ARRAY_SIZE(VPOSNEG_table),
> +		.vsel_reg = FP9931_REG_VPOSNEG_SETTING,
> +		.vsel_mask = 0x3F,
> +		.volt_table = VPOSNEG_table,
> +	},
> +	{
> +		.name = "vcom",
> +		.of_match = of_match_ptr("vcom"),
> +		.id = 2,
> +		.ops = &fp9931_vcom_ops,
> +		.type = REGULATOR_VOLTAGE,
> +		.owner = THIS_MODULE,
> +		.n_voltages = 255,
> +		.min_uV = 0,
> +		.uV_step = 5000000 / 255,
> +		.vsel_reg = FP9931_REG_VCOM_SETTING,
> +		.vsel_mask = 0xFF
> +	},
> +};
> +
> +static int fp9931_probe(struct i2c_client *client)
> +{
> +	struct fp9931_data *data;
> +	struct regulator_config config = { };
> +	struct regulator_dev *rdev;
> +	int ret = 0;
> +	int i;
> +
> +	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
> +	data->regmap = devm_regmap_init_i2c(client, &regmap_config);
> +	if (IS_ERR(data->regmap))
> +		return dev_err_probe(&client->dev, PTR_ERR(data->regmap),
> +				     "failed to allocate regmap!\n");
> +
> +	data->vin_reg = devm_regulator_get_optional(&client->dev, "vin");
> +	if (IS_ERR(data->vin_reg))
> +		return dev_err_probe(&client->dev, PTR_ERR(data->vin_reg),
> +				     "failid to get vin regulator\n");
> +
> +	data->pgood_gpio = devm_gpiod_get(&client->dev, "pg", GPIOD_IN);
> +	if (IS_ERR(data->pgood_gpio))
> +		return dev_err_probe(&client->dev,
> +				     PTR_ERR(data->pgood_gpio),
> +				     "failed to get power good gpio\n");
> +
> +	data->pgood_irq = gpiod_to_irq(data->pgood_gpio);
> +	if (data->pgood_irq < 0)
> +		return data->pgood_irq;
> +
> +	data->en_gpio = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW);
> +	if (IS_ERR(data->en_gpio))
> +		return dev_err_probe(&client->dev, PTR_ERR(data->en_gpio),
> +				     "failed to get en gpio\n");
> +
> +	data->en_ts_gpio = devm_gpiod_get_optional(&client->dev, "en-ts", GPIOD_OUT_LOW);
> +	if (IS_ERR(data->en_ts_gpio))
> +		return dev_err_probe(&client->dev,
> +				     PTR_ERR(data->en_ts_gpio),
> +				     "failed to get en gpio\n");
> +
> +	data->dev = &client->dev;
> +	i2c_set_clientdata(client, data);
> +
> +	init_completion(&data->pgood_completion);
> +
> +	ret = devm_request_threaded_irq(&client->dev, data->pgood_irq, NULL,
> +					pgood_handler,
> +					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +					"PGOOD", data);
> +	if (ret)
> +		return dev_err_probe(&client->dev, ret,
> +				     "failed to request irq\n");
> +
> +	if (IS_ENABLED(CONFIG_PM)) {
> +		devm_pm_runtime_enable(&client->dev);
> +		pm_runtime_set_autosuspend_delay(&client->dev, 4000);
> +		pm_runtime_use_autosuspend(&client->dev);
> +	} else {
> +		ret = fp9931_runtime_resume(&client->dev);
> +		if (ret < 0)
> +			return ret;
> +
> +		devm_add_action_or_reset(&client->dev, disable_nopm, data);
> +	}
> +
> +	ret = setup_timings(data);
> +	if (ret)
> +		return dev_err_probe(&client->dev, ret, "failed to setup timings\n");
> +
> +	config.driver_data = data;
> +	config.dev = &client->dev;
> +	config.regmap = data->regmap;
> +
> +	for (i = 0; i < ARRAY_SIZE(regulators); i++) {
> +		rdev = devm_regulator_register(&client->dev, &regulators[i],
> +					       &config);
> +		if (IS_ERR(rdev))
> +			return dev_err_probe(&client->dev, PTR_ERR(rdev),
> +					     "failed to register %s regulator\n",
> +					     regulators[i].name);
> +	}
> +
> +	if (IS_REACHABLE(CONFIG_HWMON)) {
> +		struct device *hwmon_dev;
> +
> +		hwmon_dev = devm_hwmon_device_register_with_info(&client->dev, "fp9931", data,
> +								 &fp9931_chip_info, NULL);
> +		if (IS_ERR(hwmon_dev))
> +			dev_err(&client->dev, "failed to register hwmon\n");

This is not an error. After all, it does not result in a probe failure.
It should be a notice.

> +	}
> +
> +	return 0;
> +}
> +
> +static const struct dev_pm_ops fp9931_pm_ops = {
> +	SET_RUNTIME_PM_OPS(fp9931_runtime_suspend, fp9931_runtime_resume, NULL)
> +};
> +
> +static const struct of_device_id fp9931_dt_ids[] = {
> +	{
> +		.compatible = "fitipower,fp9931",
> +	}, {
> +		/* sentinel */
> +	}
> +};
> +MODULE_DEVICE_TABLE(of, fp9931_dt_ids);
> +
> +static struct i2c_driver fp9931_i2c_driver = {
> +	.driver = {
> +		   .name = "fp9931",
> +		   .of_match_table = fp9931_dt_ids,
> +		   .pm = &fp9931_pm_ops,
> +	},
> +	.probe = fp9931_probe,
> +};
> +
> +module_i2c_driver(fp9931_i2c_driver);
> +
> +/* Module information */
> +MODULE_DESCRIPTION("FP9931 regulator driver");
> +MODULE_LICENSE("GPL");
> +
>