Re: [PATCH v9 3/3] net: can: rockchip: add can for RK3576 Soc

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2353 bytes --]

On 14.11.2025 20:14:13, zhangqing wrote:
>
> 在 2025/11/14 19:01, Marc Kleine-Budde 写道:
> > On 14.11.2025 17:55:53, zhangqing wrote:
> > > > > +/* The rk3576 CAN-FD */
> > > > > +static const struct rkcanfd_devtype_data rkcan_devtype_data_rk3576 = {
> > > > > +	.model = RKCAN_MODEL_RK3576,
> > > > > +	.quirks = RKCANFD_QUIRK_CANFD_BROKEN,
> > > > Is CAN-FD mode broken on the rk3576?
> > > >
> > > > Please test CAN-FD and please do the tests documented near the
> > > > definition of RKCANFD_QUIRK_CANFD_BROKEN:
> > > >
> > > > | Tests on the rk3568v2 and rk3568v3 show that receiving certain
> > > > | CAN-FD frames trigger an Error Interrupt.
> > > > |
> > > > | - Form Error in RX Arbitration Phase: TX_IDLE RX_STUFF_COUNT (0x0a010100) CMD=0 RX=0 TX=0
> > > > |   Error-Warning=1 Bus-Off=0
> > > > |   To reproduce:
> > > > |   host:
> > > > |     cansend can0 002##01f
> > > > |   DUT:
> > > > |     candump any,0:0,#FFFFFFFF -cexdHtA
> > > > |
> > > > | - Form Error in RX Arbitration Phase: TX_IDLE RX_CRC (0x0a010200) CMD=0 RX=0 TX=0
> > > > |   Error-Warning=1 Bus-Off=0
> > > > |   To reproduce:
> > > > |   host:
> > > > |     cansend can0 002##07217010000000000
> > > > |   DUT:
> > > > |     candump any,0:0,#FFFFFFFF -cexdHtA
> > > There is no doubt about the other modifications above. They will be
> > > corrected in version V10.
> > >
> > > CANFD requires authorization and is not supported by default.
> > Can you explain what you mean by authorization? What do you mean by "not
> > supported"?
>
> For RK3576 SoC, the IC hardware design supports CANFD.
> However, a license application is required before it can be used; otherwise,
> there will be legal risks.

INANL. If an SoC is supplied without a license for the IP cores that you
want to use in a product you sell, you must purchase a license from
Bosch:

https://www.bosch-semiconductors.com/products/ip-modules/can-protocol-license/can-protocol-license.html

I don't see why you should restrict the driver to CAN only, if CAN-FD is
functional.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]