Re: [PATCH v3 1/2] bindings: iio: adc: Add bindings for TI ADS131M0x ADCs

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

On Fri, Nov 14, 2025 at 10:33:59AM -0600, David Lechner wrote:
> On 11/14/25 3:19 AM, Oleksij Rempel wrote:
> > Add device tree bindings documentation for the Texas Instruments
> > ADS131M0x analog-to-digital converters. This family includes the ADS131M02,
> > ADS131M03, ADS131M04, ADS131M06, and ADS131M08 variants.
> > 
> > These variants differ primarily in the number of supported channels
> > (2, 3, 4, 6, and 8, respectively), which requires separate compatible
> > strings to validate the channel nodes.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > changes v3:
> > - Make channel@ regex patterns consistent
> > changes v2:
> > - Rename file to ti,ads131m02.yaml and update $id.
> > - Add supplies (avdd, dvdd, refin), interrupts, reset-gpios, and clock-names.
> > - Make avdd-supply, dvdd-supply, and clock-names required.
> > - Tighten channel validation logic for each device variant.
> > - Simplify channel description and reorder datasheet list.
> > - Update commit message to clarify device difference
> > ---
> 
> 
> ...
> 
> > +  - if:
> > +      # 32-pin devices: M06, M08
> > +      # These support both XTAL/CLKIN and optional REFIN.
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - ti,ads131m06
> > +            - ti,ads131m08
> > +    then:
> > +      properties:
> > +        clock-names:
> > +          description:
> > +            Indicates if a crystal oscillator (XTAL) or CMOS signal is connected
> > +            (CLKIN).
> > +          enum: [xtal, clkin]
> 
> 
> Usually, we want all possible properties declared at the top level and then
> only limit them by the conditional statements.
> 
> This makes it easier to see what all of the possibilities are. At first I
> thought clock-names had not been added.
> 
> 
> > +        refin-supply:
> > +          description: Optional external reference supply (REFIN).
> 
> refin-supply should be at the top level as well.

Oh ye, good shout. I didn't notice those inside the list of different
devices.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]