devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	Frank Li <Frank.Li@nxp.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index
Date: Fri, 14 Nov 2025 05:37:34 -0800	[thread overview]
Message-ID: <20251114133738.1762-3-laurentiumihalcea111@gmail.com> (raw)
In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com>

From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Replace the reset map mask with the bit index to make it clear that all
reset lines are managed by exactly 1 bit.

Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
---
 drivers/reset/reset-imx8mp-audiomix.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
index acfa92b15329..d993c294c548 100644
--- a/drivers/reset/reset-imx8mp-audiomix.c
+++ b/drivers/reset/reset-imx8mp-audiomix.c
@@ -19,24 +19,24 @@
 
 struct imx8mp_reset_map {
 	unsigned int offset;
-	unsigned int mask;
+	unsigned int bit;
 	bool active_low;
 };
 
 static const struct imx8mp_reset_map reset_map[] = {
 	[IMX8MP_AUDIOMIX_EARC_RESET] = {
 		.offset	= IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
-		.mask = BIT(0),
+		.bit = 0,
 		.active_low = true,
 	},
 	[IMX8MP_AUDIOMIX_EARC_PHY_RESET] = {
 		.offset	= IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
-		.mask = BIT(1),
+		.bit = 1,
 		.active_low = true,
 	},
 	[IMX8MP_AUDIOMIX_DSP_RUNSTALL] = {
 		.offset	= IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET,
-		.mask = BIT(5),
+		.bit = 5,
 		.active_low = false,
 	},
 };
@@ -60,7 +60,7 @@ static int imx8mp_audiomix_update(struct reset_controller_dev *rcdev,
 	unsigned int mask, offset, active_low;
 	unsigned long reg, flags;
 
-	mask = reset_map[id].mask;
+	mask = BIT(reset_map[id].bit);
 	offset = reset_map[id].offset;
 	active_low = reset_map[id].active_low;
 
-- 
2.43.0


  parent reply	other threads:[~2025-11-14 13:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 13:37 [PATCH v5 0/6] Add support for i.MX8ULP's SIM LPAV Laurentiu Mihalcea
2025-11-14 13:37 ` [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros Laurentiu Mihalcea
2025-11-14 15:48   ` Philipp Zabel
2025-11-14 13:37 ` Laurentiu Mihalcea [this message]
2025-11-14 15:48   ` [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index Philipp Zabel
2025-11-21 15:38   ` Frank Li
2025-11-14 13:37 ` [PATCH v5 3/6] reset: imx8mp-audiomix: Switch to using regmap API Laurentiu Mihalcea
2025-11-14 15:49   ` Philipp Zabel
2025-11-21 15:43   ` Frank Li
2025-11-14 13:37 ` [PATCH v5 4/6] reset: imx8mp-audiomix: Extend the driver usage Laurentiu Mihalcea
2025-11-14 16:02   ` Philipp Zabel
2025-11-21  9:29     ` Laurentiu Mihalcea
2025-11-21 15:18       ` Philipp Zabel
2025-11-14 13:37 ` [PATCH v5 5/6] reset: imx8mp-audiomix: Support i.MX8ULP SIM LPAV Laurentiu Mihalcea
2025-11-14 16:09   ` Philipp Zabel
2025-11-14 13:37 ` [PATCH v5 6/6] arm64: dts: imx8ulp: add sim lpav node Laurentiu Mihalcea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114133738.1762-3-laurentiumihalcea111@gmail.com \
    --to=laurentiumihalcea111@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).