On Mon, Nov 17, 2025 at 12:27:44PM -0600, Rob Herring (Arm) wrote: > > On Mon, 17 Nov 2025 16:38:18 +0000, Conor Dooley wrote: > > From: Conor Dooley > > > > The CAN cores on Polarfire SoC both have a reset. The platform firmware > > brings both cores out of reset, but the linux driver must use them > > during normal operation. The resets should have been made required, but > > this is one of the things that can happen when the binding is written > > without driver support. > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > Signed-off-by: Conor Dooley > > --- > > This is the second mistake in this binding, both spotted because of the > > driver being written (although this one sat downstream for a while for > > w/e reason). I wish I could say that I'd send the driver soon, but I am > > busy upstreaming things I wrote and therefore understand at the moment, > > so a driver that I'd have to go understand and review before sending is > > low priority, sorry! > > > > CC: Conor Dooley > > CC: Daire McNamara > > CC: Marc Kleine-Budde > > CC: Vincent Mailhol > > CC: Rob Herring > > CC: Krzysztof Kozlowski > > CC: linux-riscv@lists.infradead.org > > CC: linux-can@vger.kernel.org > > CC: devicetree@vger.kernel.org > > CC: linux-kernel@vger.kernel.org > > --- > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.example.dtb: can@2010c000 (microchip,mpfs-can): 'resets' is a required property > from schema $id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml Two issues in the same branch now, there's something weird going on with my test script. /sigh guess that's my evening gone.