From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org,
"Gregory CLEMENT" <gregory.clement@bootlin.com>
Subject: [PATCH 3/3] mtd: physmap: Add support for RAM reserved memory regions
Date: Mon, 17 Nov 2025 18:00:16 +0100 [thread overview]
Message-ID: <20251117-mtd-memregion-v1-3-7b35611c79a6@bootlin.com> (raw)
In-Reply-To: <20251117-mtd-memregion-v1-0-7b35611c79a6@bootlin.com>
MTD fixed-partitions can now be exposed for reserved RAM regions, not
just ROM reg regions. This is achieved by using a memory-region
phandle to reference the reserved RAM region instead of the reg
property.
Based on the work of Muhammad Musa <muhammad.musa@intel.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
drivers/mtd/maps/physmap-core.c | 56 ++++++++++++++++++++++++++++++++++-------
1 file changed, 47 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c
index 2bd7a1af898c9..f084f6f34d611 100644
--- a/drivers/mtd/maps/physmap-core.c
+++ b/drivers/mtd/maps/physmap-core.c
@@ -39,6 +39,7 @@
#include <linux/mtd/cfi_endian.h>
#include <linux/io.h>
#include <linux/of.h>
+#include <linux/of_reserved_mem.h>
#include <linux/pm_runtime.h>
#include <linux/gpio/consumer.h>
@@ -263,6 +264,14 @@ static const struct of_device_id of_flash_match[] = {
.type = "rom",
.compatible = "direct-mapped"
},
+ {
+ .compatible = "mtd-mem",
+ .data = "map_ram",
+ },
+ {
+ .compatible = "mtd-memro",
+ .data = "map_rom",
+ },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, of_flash_match);
@@ -446,8 +455,9 @@ static int physmap_flash_pdata_init(struct platform_device *dev)
static int physmap_flash_probe(struct platform_device *dev)
{
struct physmap_flash_info *info;
- int err = 0;
- int i;
+ struct resource *res_array;
+ int err = 0, is_rsvd_mem = 0, nreg = 0;
+ int i, curr_reg;
if (!dev->dev.of_node && !dev_get_platdata(&dev->dev))
return -EINVAL;
@@ -459,9 +469,13 @@ static int physmap_flash_probe(struct platform_device *dev)
while (platform_get_resource(dev, IORESOURCE_MEM, info->nmaps))
info->nmaps++;
- if (!info->nmaps)
- return -ENODEV;
-
+ if (!info->nmaps) {
+ info->nmaps = of_reserved_mem_region_total_count(dev->dev.of_node);
+ if (info->nmaps > 0)
+ is_rsvd_mem = 1;
+ else
+ return -ENODEV;
+ }
info->maps = devm_kzalloc(&dev->dev,
sizeof(*info->maps) * info->nmaps,
GFP_KERNEL);
@@ -503,7 +517,23 @@ static int physmap_flash_probe(struct platform_device *dev)
for (i = 0; i < info->nmaps; i++) {
struct resource *res;
- info->maps[i].virt = devm_platform_get_and_ioremap_resource(dev, i, &res);
+ if (is_rsvd_mem) {
+ if (nreg <= i) {
+ int cnt = of_reserved_mem_region_to_resource_array(&dev->dev,
+ dev->dev.of_node, i, &res_array);
+ if (cnt < 0) {
+ err = cnt;
+ goto err_out;
+ }
+ nreg += cnt;
+ curr_reg = 0;
+ }
+ res = &res_array[curr_reg++];
+ info->maps[i].virt = devm_ioremap_resource(&dev->dev, res);
+ } else {
+ info->maps[i].virt = devm_platform_get_and_ioremap_resource(dev, i, &res);
+ }
+
if (IS_ERR(info->maps[i].virt)) {
err = PTR_ERR(info->maps[i].virt);
goto err_out;
@@ -519,9 +549,17 @@ static int physmap_flash_probe(struct platform_device *dev)
info->maps[i].phys = res->start;
info->win_order = fls64(resource_size(res)) - 1;
- info->maps[i].size = BIT(info->win_order +
- (info->gpios ?
- info->gpios->ndescs : 0));
+ /* When using a memory region, the size is not necessarily a
+ * power of 2, so win_order is not applicable. Since GPIOs are
+ * unavailable in this context, directly using the region's size
+ * is safe.
+ */
+ if (is_rsvd_mem)
+ info->maps[i].size = resource_size(res);
+ else
+ info->maps[i].size = BIT(info->win_order +
+ (info->gpios ?
+ info->gpios->ndescs : 0));
info->maps[i].map_priv_1 = (unsigned long)dev;
--
2.51.0
prev parent reply other threads:[~2025-11-17 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 17:00 [PATCH 0/3] MTD physmap: Adding reserved RAM support and fixing reserved_mem limitations Gregory CLEMENT
2025-11-17 17:00 ` [PATCH 1/3] of: reserved_mem: Support multiple 'reg' entries for memory-region Gregory CLEMENT
2025-11-17 18:04 ` Rob Herring
2025-11-17 17:00 ` [PATCH 2/3] dt-bindings: mtd: physmap: Allow using memory-region to access memory resources Gregory CLEMENT
2025-11-17 17:59 ` Rob Herring
2025-11-19 9:47 ` Gregory CLEMENT
2025-11-17 17:00 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117-mtd-memregion-v1-3-7b35611c79a6@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=benoit.monin@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).