* [PATCH] arm64: dts: qcom: kodiak: Add memory region for audiopd @ 2025-11-14 5:56 Jianping Li 2025-11-14 11:11 ` Dmitry Baryshkov 2025-11-17 7:08 ` [PATCH v2] " Jianping Li 0 siblings, 2 replies; 6+ messages in thread From: Jianping Li @ 2025-11-14 5:56 UTC (permalink / raw) To: andersson, konradybcio, robh, krzk+dt, conor+dt Cc: Jianping Li, ekansh.gupta, linux-arm-msm, devicetree, linux-kernel Add reserved memory region for audio PD dynamic loading and remote heap requirement. Also add LPASS and ADSP_HEAP VMIDs. Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi index 3ef61af2ed8a..0cda9af98dd2 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { qcom,client-id = <1>; qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>; }; + + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { + reg = <0x0 0x9cb80000 0x0 0x800000>; + no-map; + }; }; cpus { @@ -4139,6 +4144,9 @@ fastrpc { qcom,glink-channels = "fastrpcglink-apps-dsp"; label = "adsp"; qcom,non-secure-domain; + memory-region = <&adsp_rpc_remote_heap_mem>; + qcom,vmids = <QCOM_SCM_VMID_LPASS + QCOM_SCM_VMID_ADSP_HEAP>; #address-cells = <1>; #size-cells = <0>; -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: kodiak: Add memory region for audiopd 2025-11-14 5:56 [PATCH] arm64: dts: qcom: kodiak: Add memory region for audiopd Jianping Li @ 2025-11-14 11:11 ` Dmitry Baryshkov 2025-11-17 7:08 ` [PATCH v2] " Jianping Li 1 sibling, 0 replies; 6+ messages in thread From: Dmitry Baryshkov @ 2025-11-14 11:11 UTC (permalink / raw) To: Jianping Li Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, ekansh.gupta, linux-arm-msm, devicetree, linux-kernel On Fri, Nov 14, 2025 at 01:56:39PM +0800, Jianping Li wrote: > Add reserved memory region for audio PD dynamic loading and remote > heap requirement. Also add LPASS and ADSP_HEAP VMIDs. > > Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi > index 3ef61af2ed8a..0cda9af98dd2 100644 > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { > qcom,client-id = <1>; > qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>; > }; > + > + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { > + reg = <0x0 0x9cb80000 0x0 0x800000>; > + no-map; > + }; > }; > > cpus { > @@ -4139,6 +4144,9 @@ fastrpc { > qcom,glink-channels = "fastrpcglink-apps-dsp"; > label = "adsp"; > qcom,non-secure-domain; > + memory-region = <&adsp_rpc_remote_heap_mem>; > + qcom,vmids = <QCOM_SCM_VMID_LPASS > + QCOM_SCM_VMID_ADSP_HEAP>; Wrong indentation. Please align vertically (or fix Tab size to be 8 in your editor). > #address-cells = <1>; > #size-cells = <0>; > > -- > 2.43.0 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] arm64: dts: qcom: kodiak: Add memory region for audiopd 2025-11-14 5:56 [PATCH] arm64: dts: qcom: kodiak: Add memory region for audiopd Jianping Li 2025-11-14 11:11 ` Dmitry Baryshkov @ 2025-11-17 7:08 ` Jianping Li 2025-11-18 15:39 ` Bjorn Andersson 1 sibling, 1 reply; 6+ messages in thread From: Jianping Li @ 2025-11-17 7:08 UTC (permalink / raw) To: andersson, konradybcio, robh, krzk+dt, conor+dt Cc: Jianping Li, ekansh.gupta, linux-arm-msm, devicetree, linux-kernel Add reserved memory region for audio PD dynamic loading and remote heap requirement. Also add LPASS and ADSP_HEAP VMIDs. Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com> --- Patch v1: https://lore.kernel.org/all/20251114055639.1050-1-jianping.li@oss.qualcomm.com/ Changes in v2: - Fixed the alignment issue of the qcom,vmids properties, aligning the values in the second row with the first row. --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi index 3ef61af2ed8a..7957a9151055 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { qcom,client-id = <1>; qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>; }; + + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { + reg = <0x0 0x9cb80000 0x0 0x800000>; + no-map; + }; }; cpus { @@ -4139,6 +4144,9 @@ fastrpc { qcom,glink-channels = "fastrpcglink-apps-dsp"; label = "adsp"; qcom,non-secure-domain; + memory-region = <&adsp_rpc_remote_heap_mem>; + qcom,vmids = <QCOM_SCM_VMID_LPASS + QCOM_SCM_VMID_ADSP_HEAP>; #address-cells = <1>; #size-cells = <0>; -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: kodiak: Add memory region for audiopd 2025-11-17 7:08 ` [PATCH v2] " Jianping Li @ 2025-11-18 15:39 ` Bjorn Andersson 2025-11-20 9:08 ` Jianping Li 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Andersson @ 2025-11-18 15:39 UTC (permalink / raw) To: Jianping Li Cc: konradybcio, robh, krzk+dt, conor+dt, ekansh.gupta, linux-arm-msm, devicetree, linux-kernel On Mon, Nov 17, 2025 at 03:08:19PM +0800, Jianping Li wrote: Please don't send new versions as replies to older ones, and please adopt b4, it will take care of these practicalities for you. > Add reserved memory region for audio PD dynamic loading and remote > heap requirement. Also add LPASS and ADSP_HEAP VMIDs. > > Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com> > --- > Patch v1: https://lore.kernel.org/all/20251114055639.1050-1-jianping.li@oss.qualcomm.com/ > Changes in v2: > - Fixed the alignment issue of the qcom,vmids properties, aligning > the values in the second row with the first row. > --- > arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi > index 3ef61af2ed8a..7957a9151055 100644 > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { > qcom,client-id = <1>; > qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>; > }; > + > + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { > + reg = <0x0 0x9cb80000 0x0 0x800000>; > + no-map; > + }; Is the placement of this carveout hard code somewhere in non-HLOS software? If so, its location and size universal across all Kodiak-based devices? Also, the presence of arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi tells me that we have different audio stacks in play on Kodiak. Does all of them have the same PD loading capabilities/needs? PS. Others might ask these same questions in the future (I will probably wonder in 6 months from now...), so let's make sure the git history carries the answers to why things look the way they do. Thanks, Bjorn > }; > > cpus { > @@ -4139,6 +4144,9 @@ fastrpc { > qcom,glink-channels = "fastrpcglink-apps-dsp"; > label = "adsp"; > qcom,non-secure-domain; > + memory-region = <&adsp_rpc_remote_heap_mem>; > + qcom,vmids = <QCOM_SCM_VMID_LPASS > + QCOM_SCM_VMID_ADSP_HEAP>; > #address-cells = <1>; > #size-cells = <0>; > > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: kodiak: Add memory region for audiopd 2025-11-18 15:39 ` Bjorn Andersson @ 2025-11-20 9:08 ` Jianping Li 2025-11-20 13:35 ` Bjorn Andersson 0 siblings, 1 reply; 6+ messages in thread From: Jianping Li @ 2025-11-20 9:08 UTC (permalink / raw) To: Bjorn Andersson, Mohammad Rafi Shaik Cc: konradybcio, robh, krzk+dt, conor+dt, ekansh.gupta, linux-arm-msm, devicetree, linux-kernel On 11/18/2025 11:39 PM, Bjorn Andersson wrote: > On Mon, Nov 17, 2025 at 03:08:19PM +0800, Jianping Li wrote: > > Please don't send new versions as replies to older ones, and please > adopt b4, it will take care of these practicalities for you. Ack. I'll fix this going forward. > >> Add reserved memory region for audio PD dynamic loading and remote >> heap requirement. Also add LPASS and ADSP_HEAP VMIDs. >> >> Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com> >> --- >> Patch v1: https://lore.kernel.org/all/20251114055639.1050-1-jianping.li@oss.qualcomm.com/ >> Changes in v2: >> - Fixed the alignment issue of the qcom,vmids properties, aligning >> the values in the second row with the first row. >> --- >> arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> index 3ef61af2ed8a..7957a9151055 100644 >> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { >> qcom,client-id = <1>; >> qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>; >> }; >> + >> + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { >> + reg = <0x0 0x9cb80000 0x0 0x800000>; >> + no-map; >> + }; > Is the placement of this carveout hard code somewhere in non-HLOS > software? If so, its location and size universal across all Kodiak-based > devices? This information is not hard-coded on non-HLOS. Any region(irrespective of placement) allocated by fastrpc is moved to LPASS using qcom_scm calls. > Also, the presence of arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi > tells me that we have different audio stacks in play on Kodiak. Does all > of them have the same PD loading capabilities/needs? This DT looks to be audioreach specific. The one I'm adding is mostly used for audio PD dynamic loading purpose. Adding @Mohammad Rafi to give more details about audioreach. > > > PS. Others might ask these same questions in the future (I will probably > wonder in 6 months from now...), so let's make sure the git history > carries the answers to why things look the way they do. Ack. > > Thanks, > Bjorn > >> }; >> >> cpus { >> @@ -4139,6 +4144,9 @@ fastrpc { >> qcom,glink-channels = "fastrpcglink-apps-dsp"; >> label = "adsp"; >> qcom,non-secure-domain; >> + memory-region = <&adsp_rpc_remote_heap_mem>; >> + qcom,vmids = <QCOM_SCM_VMID_LPASS >> + QCOM_SCM_VMID_ADSP_HEAP>; >> #address-cells = <1>; >> #size-cells = <0>; >> >> -- >> 2.43.0 >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: kodiak: Add memory region for audiopd 2025-11-20 9:08 ` Jianping Li @ 2025-11-20 13:35 ` Bjorn Andersson 0 siblings, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2025-11-20 13:35 UTC (permalink / raw) To: Jianping Li Cc: Mohammad Rafi Shaik, konradybcio, robh, krzk+dt, conor+dt, ekansh.gupta, linux-arm-msm, devicetree, linux-kernel On Thu, Nov 20, 2025 at 05:08:37PM +0800, Jianping Li wrote: > > On 11/18/2025 11:39 PM, Bjorn Andersson wrote: > > On Mon, Nov 17, 2025 at 03:08:19PM +0800, Jianping Li wrote: > > > > Please don't send new versions as replies to older ones, and please > > adopt b4, it will take care of these practicalities for you. > > Ack. I'll fix this going forward. > Thank you. FYI, There are instructions on go/upstream on how to start using b4 for patches in-progress. > > > > > Add reserved memory region for audio PD dynamic loading and remote > > > heap requirement. Also add LPASS and ADSP_HEAP VMIDs. > > > > > > Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com> > > > --- > > > Patch v1: https://lore.kernel.org/all/20251114055639.1050-1-jianping.li@oss.qualcomm.com/ > > > Changes in v2: > > > - Fixed the alignment issue of the qcom,vmids properties, aligning > > > the values in the second row with the first row. > > > --- > > > arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi > > > index 3ef61af2ed8a..7957a9151055 100644 > > > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > > > @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { > > > qcom,client-id = <1>; > > > qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>; > > > }; > > > + > > > + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { > > > + reg = <0x0 0x9cb80000 0x0 0x800000>; > > > + no-map; > > > + }; > > Is the placement of this carveout hard code somewhere in non-HLOS > > software? If so, its location and size universal across all Kodiak-based > > devices? > > This information is not hard-coded on non-HLOS. Any region(irrespective of placement) > allocated by fastrpc is moved to LPASS using qcom_scm calls. > Then you can replace reg = <0x0 0x9cb80000 0x0 0x800000> with size = <0x0 0x800000>. I'm assuming that this is subject to address-bit restrictions, so you probably need alloc-ranges = <0 0 1 0> as well though. > > Also, the presence of arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi > > tells me that we have different audio stacks in play on Kodiak. Does all > > of them have the same PD loading capabilities/needs? > > This DT looks to be audioreach specific. The one I'm adding is mostly used for audio PD > dynamic loading purpose. Adding @Mohammad Rafi to give more details about audioreach. > So, you're saying that we do dynamic audio PD loading in all Kodiak devices (LA, LC, LE, WP), and they all use about 8MB of RAM for this? Regards, Bjorn > > > > > > PS. Others might ask these same questions in the future (I will probably > > wonder in 6 months from now...), so let's make sure the git history > > carries the answers to why things look the way they do. > > Ack. > > > > > Thanks, > > Bjorn > > > > > }; > > > cpus { > > > @@ -4139,6 +4144,9 @@ fastrpc { > > > qcom,glink-channels = "fastrpcglink-apps-dsp"; > > > label = "adsp"; > > > qcom,non-secure-domain; > > > + memory-region = <&adsp_rpc_remote_heap_mem>; > > > + qcom,vmids = <QCOM_SCM_VMID_LPASS > > > + QCOM_SCM_VMID_ADSP_HEAP>; > > > #address-cells = <1>; > > > #size-cells = <0>; > > > -- > > > 2.43.0 > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-11-20 13:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-14 5:56 [PATCH] arm64: dts: qcom: kodiak: Add memory region for audiopd Jianping Li 2025-11-14 11:11 ` Dmitry Baryshkov 2025-11-17 7:08 ` [PATCH v2] " Jianping Li 2025-11-18 15:39 ` Bjorn Andersson 2025-11-20 9:08 ` Jianping Li 2025-11-20 13:35 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).