From: Arun Muthusamy <arun.muthusamy@gaisler.com>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mkl@pengutronix.de, mailhol@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-can@vger.kernel.org, Daniel Hellstrom <daniel@gaisler.com>,
Arun Muthusamy <arun.muthusamy@gaisler.com>
Subject: [PATCH 06/10] can: grcan: optimize DMA by 32-bit accesses
Date: Tue, 18 Nov 2025 10:21:11 +0100 [thread overview]
Message-ID: <20251118092115.3455-7-arun.muthusamy@gaisler.com> (raw)
In-Reply-To: <20251118092115.3455-1-arun.muthusamy@gaisler.com>
From: Daniel Hellstrom <daniel@gaisler.com>
Optimizes DMA transfers in the GRCAN driver by reorganizing
data handling to use 32-bit accesses instead of individual
byte accesses.
Signed-off-by: Arun Muthusamy <arun.muthusamy@gaisler.com>
Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
---
drivers/net/can/grcan.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c
index b9b0dd7d53f6..e367581faa57 100644
--- a/drivers/net/can/grcan.c
+++ b/drivers/net/can/grcan.c
@@ -1287,7 +1287,7 @@ static int grcan_receive(struct net_device *dev, int budget)
struct sk_buff *skb;
u32 wr, rd, startrd;
u32 *slot;
- u32 i, rtr, eff, j, shift;
+ u32 rtr, eff;
int work_done = 0;
rd = grcan_read_reg(®s->rxrd);
@@ -1323,10 +1323,10 @@ static int grcan_receive(struct net_device *dev, int budget)
if (rtr) {
cf->can_id |= CAN_RTR_FLAG;
} else {
- for (i = 0; i < cf->len; i++) {
- j = GRCAN_MSG_DATA_SLOT_INDEX(i);
- shift = GRCAN_MSG_DATA_SHIFT(i);
- cf->data[i] = (u8)(slot[j] >> shift);
+ if (cf->can_dlc > 0) {
+ *(u32 *)(cf->data) = slot[2];
+ if (cf->can_dlc > 4)
+ *(u32 *)(cf->data + 4) = slot[3];
}
stats->rx_bytes += cf->len;
@@ -1466,8 +1466,7 @@ static netdev_tx_t grcan_start_xmit(struct sk_buff *skb,
u32 id, txwr, txrd, space, txctrl;
int slotindex;
u32 *slot;
- u32 i, rtr, eff, dlc, tmp, err;
- int j, shift;
+ u32 rtr, eff, dlc, tmp, err;
unsigned long flags;
u32 oneshotmode = priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT;
@@ -1520,10 +1519,10 @@ static netdev_tx_t grcan_start_xmit(struct sk_buff *skb,
slot[1] = ((dlc << GRCAN_MSG_DLC_BIT) & GRCAN_MSG_DLC);
slot[2] = 0;
slot[3] = 0;
- for (i = 0; i < dlc; i++) {
- j = GRCAN_MSG_DATA_SLOT_INDEX(i);
- shift = GRCAN_MSG_DATA_SHIFT(i);
- slot[j] |= cf->data[i] << shift;
+ if (dlc > 0) {
+ slot[2] = *(u32 *)(cf->data); /* data aligned 64-bit */
+ if (dlc > 4)
+ slot[3] = *(u32 *)(cf->data + 4);
}
/* Checking that channel has not been disabled. These cases
--
2.51.0
next prev parent reply other threads:[~2025-11-18 9:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 9:21 [PATCH 00/10] can: grcan: Enhance driver with CANFD Support and Improvements Arun Muthusamy
2025-11-18 9:21 ` [PATCH 01/10] dt-bindings: Add vendor prefix for Frontgrade Gaisler AB Arun Muthusamy
2025-11-18 10:56 ` Krzysztof Kozlowski
2025-11-18 9:21 ` [PATCH 02/10] dt-bindings: net: can: grcan: Convert GRCAN CAN controllers binding from txt to YAML Arun Muthusamy
2025-11-18 11:01 ` Krzysztof Kozlowski
2025-11-24 9:37 ` Arun Muthusamy
2025-11-24 11:28 ` Krzysztof Kozlowski
2025-12-11 10:11 ` Arun Muthusamy
2025-11-18 9:21 ` [PATCH 03/10] MAINTAINERS: Add entry for GRCAN CAN network driver Arun Muthusamy
2025-11-18 9:21 ` [PATCH 04/10] can: grcan: Add clock handling Arun Muthusamy
2025-11-18 11:01 ` Krzysztof Kozlowski
2025-11-24 9:46 ` Arun Muthusamy
2025-11-24 11:10 ` Krzysztof Kozlowski
2025-11-18 9:21 ` [PATCH 05/10] can: grcan: add FD capability detection and nominal bit-timing Arun Muthusamy
2025-11-21 10:52 ` Marc Kleine-Budde
2025-11-18 9:21 ` Arun Muthusamy [this message]
2025-11-21 11:00 ` [PATCH 06/10] can: grcan: optimize DMA by 32-bit accesses Marc Kleine-Budde
2025-11-18 9:21 ` [PATCH 07/10] can: grcan: set DMA mask for GRCAN and GRCANFD to 32-bit Arun Muthusamy
2025-11-21 12:46 ` Marc Kleine-Budde
2025-11-18 9:21 ` [PATCH 08/10] can: grcan: Add saving and restoring of CAN FD baud-rate registers Arun Muthusamy
2025-11-21 12:50 ` Marc Kleine-Budde
2025-12-11 9:13 ` Arun Muthusamy
2025-12-11 11:37 ` Marc Kleine-Budde
2025-11-18 9:21 ` [PATCH 09/10] can: grcan: Reserve space between cap and next register to align with address layout Arun Muthusamy
2025-11-18 9:21 ` [PATCH 10/10] can: grcan: Add CANFD support alongside legacy CAN Arun Muthusamy
2025-11-21 13:03 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118092115.3455-7-arun.muthusamy@gaisler.com \
--to=arun.muthusamy@gaisler.com \
--cc=conor+dt@kernel.org \
--cc=daniel@gaisler.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).