devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] two small fixes for imx8qm-mek board
@ 2025-11-19  3:22 Haibo Chen
  2025-11-19  3:22 ` [PATCH v2 1/2] arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level Haibo Chen
  2025-11-19  3:22 ` [PATCH v2 2/2] arm64: dts: add off-on-delay-us for usdhc2 regulator Haibo Chen
  0 siblings, 2 replies; 4+ messages in thread
From: Haibo Chen @ 2025-11-19  3:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Dong Aisheng, Frank Li
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Haibo Chen

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
Changes in v2:
- PATCH 1: add fix tag
- PATCH 2: add Frank's ack.
- Link to v1: https://lore.kernel.org/r/20251118-dts-imx8qm-v1-0-63e226ffe512@nxp.com

---
Haibo Chen (2):
      arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level
      arm64: dts: add off-on-delay-us for usdhc2 regulator

 arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 187dac290bfd0741b9d7d5490af825c33fd9baa4
change-id: 20251118-dts-imx8qm-7bafa38718ea

Best regards,
-- 
Haibo Chen <haibo.chen@nxp.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level
  2025-11-19  3:22 [PATCH v2 0/2] two small fixes for imx8qm-mek board Haibo Chen
@ 2025-11-19  3:22 ` Haibo Chen
  2025-11-19 16:18   ` Frank Li
  2025-11-19  3:22 ` [PATCH v2 2/2] arm64: dts: add off-on-delay-us for usdhc2 regulator Haibo Chen
  1 sibling, 1 reply; 4+ messages in thread
From: Haibo Chen @ 2025-11-19  3:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Dong Aisheng, Frank Li
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Haibo Chen

light sensor isl29023 share the interrupt with lsm303arg, but these
two devices use different interrupt type. According to the datasheet
of these two devides, both support low level trigger type, so correct
the interrupt type here to avoid the following error log:

  irq: type mismatch, failed to map hwirq-11 for gpio@5d0c0000!

Fixes: 9918092cbb0e ("arm64: dts: imx8qm-mek: add i2c0 and children devices")
Fixes: 1d8a9f043a77 ("arm64: dts: imx8: use defines for interrupts")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
index 779d9f78fb8196b04c41516963f16ece082360e3..667ba2fea8678215c611dc0ca19e8fbc397f9273 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
@@ -576,7 +576,7 @@ light-sensor@44 {
 		compatible = "isil,isl29023";
 		reg = <0x44>;
 		interrupt-parent = <&lsio_gpio4>;
-		interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
 	};
 
 	pressure-sensor@60 {

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm64: dts: add off-on-delay-us for usdhc2 regulator
  2025-11-19  3:22 [PATCH v2 0/2] two small fixes for imx8qm-mek board Haibo Chen
  2025-11-19  3:22 ` [PATCH v2 1/2] arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level Haibo Chen
@ 2025-11-19  3:22 ` Haibo Chen
  1 sibling, 0 replies; 4+ messages in thread
From: Haibo Chen @ 2025-11-19  3:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Dong Aisheng, Frank Li
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Haibo Chen

For SD card, according to the spec requirement, for sd card power reset
operation, it need sd card supply voltage to be lower than 0.5v and keep
over 1ms, otherwise, next time power back the sd card supply voltage to
3.3v, sd card can't support SD3.0 mode again.

To match such requirement on imx8qm-mek board, add 4.8ms delay between
sd power off and power on.

Fixes: 307fd14d4b14 ("arm64: dts: imx: add imx8qm mek support")
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
index 667ba2fea8678215c611dc0ca19e8fbc397f9273..f1b0563d3a09044dda30627a62de5707b53f021a 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
@@ -263,6 +263,7 @@ reg_usdhc2_vmmc: usdhc2-vmmc {
 		regulator-max-microvolt = <3000000>;
 		gpio = <&lsio_gpio4 7 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
+		off-on-delay-us = <4800>;
 	};
 
 	reg_audio: regulator-audio {

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level
  2025-11-19  3:22 ` [PATCH v2 1/2] arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level Haibo Chen
@ 2025-11-19 16:18   ` Frank Li
  0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-11-19 16:18 UTC (permalink / raw)
  To: Haibo Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Dong Aisheng, devicetree, imx, linux-arm-kernel, linux-kernel

On Wed, Nov 19, 2025 at 11:22:39AM +0800, Haibo Chen wrote:
> light sensor isl29023 share the interrupt with lsm303arg, but these
> two devices use different interrupt type. According to the datasheet
> of these two devides, both support low level trigger type, so correct
> the interrupt type here to avoid the following error log:
>
>   irq: type mismatch, failed to map hwirq-11 for gpio@5d0c0000!
>
> Fixes: 9918092cbb0e ("arm64: dts: imx8qm-mek: add i2c0 and children devices")
> Fixes: 1d8a9f043a77 ("arm64: dts: imx8: use defines for interrupts")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> index 779d9f78fb8196b04c41516963f16ece082360e3..667ba2fea8678215c611dc0ca19e8fbc397f9273 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> @@ -576,7 +576,7 @@ light-sensor@44 {
>  		compatible = "isil,isl29023";
>  		reg = <0x44>;
>  		interrupt-parent = <&lsio_gpio4>;
> -		interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>  	};
>
>  	pressure-sensor@60 {
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-19 16:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-19  3:22 [PATCH v2 0/2] two small fixes for imx8qm-mek board Haibo Chen
2025-11-19  3:22 ` [PATCH v2 1/2] arm64: dts: imx8qm-mek: correct the light sensor interrupt type to low level Haibo Chen
2025-11-19 16:18   ` Frank Li
2025-11-19  3:22 ` [PATCH v2 2/2] arm64: dts: add off-on-delay-us for usdhc2 regulator Haibo Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).