From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenliang Yan <wenliang202407@163.com>
Cc: linux@roeck-us.net, Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] dt-bindings: hwmon: ti,ina3221: Add SQ52210
Date: Wed, 19 Nov 2025 08:22:38 +0100 [thread overview]
Message-ID: <20251119-tremendous-skunk-of-science-aab7fb@kuoka> (raw)
In-Reply-To: <20251118125148.95603-2-wenliang202407@163.com>
On Tue, Nov 18, 2025 at 07:51:41AM -0500, Wenliang Yan wrote:
> Add a compatible string for sq52210. The sq52210 is forward compatible
forward?
> with INA3221 and incorporates alert registers to implement four
But this suggests opposite.
Your driver changes confirm that even more - it is not forward
compatible. And in other way why wouldn't compatibility be expressed in
the bindings?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-19 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 12:51 [PATCH v2 0/8] hwmon: (ina3221) Various improvement and add support for SQ52210 Wenliang Yan
2025-11-18 12:51 ` [PATCH v2 1/8] dt-bindings: hwmon: ti,ina3221: Add SQ52210 Wenliang Yan
2025-11-19 7:22 ` Krzysztof Kozlowski [this message]
2025-11-19 9:06 ` Wenliang Yan
2025-11-19 9:17 ` Krzysztof Kozlowski
2025-11-20 6:10 ` Wenliang Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119-tremendous-skunk-of-science-aab7fb@kuoka \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).