From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4312F20C00C; Thu, 20 Nov 2025 00:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763599665; cv=none; b=fqnALqT3a07bZL4X+2VYYmAGmsMvhFetrCqDulX2LSXOqocuwB3pyP/jl/7TGPiesrAKPIX6vl+4podT7Zpr5d4oC0sZnK27PLvnSdgTN0kcNyDBTFkU9OJvoUp6j4EcYmI7FFlB0a0MbywlK2gYiDn9jIPs4x1nn0r+2+vSX4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763599665; c=relaxed/simple; bh=/Z2MAozJnU/LYuNLYNctu23sEUYxIs/9YPAdnmPT4PQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H0risJEoyfSeLjEkavsTouX6u9t440FBnM4KXEF2kEApdsifBCVN/PlMNQwkCUxYLRWN0ej3smkXZLwCY07NmsAW6LsG47eX+7TRC6FJcvfZP4qG/QmlQEIf1I0sdV+aGRtVCZKNnYaYwa8nb8YoN8bwRP8l4eyiTsOCrBAEdHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A0a9AQ/Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A0a9AQ/Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CABBC4CEF5; Thu, 20 Nov 2025 00:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763599664; bh=/Z2MAozJnU/LYuNLYNctu23sEUYxIs/9YPAdnmPT4PQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A0a9AQ/Qmx4jMEFAgLrq3xe8iw45ICswS3k4qtjFM5dOQwoiVX+cJPX2VlnyoRIy/ K5Hwr+lg9UG00h481Jem88rTyyTruJ3CVKXqfFka8x/R2usbysdZm0UyHXlcnTVRmu gqdTnWBQQVmjHDGN9a9M2iaWIcIdlRtn0z+eqRVkHyUlFBajdgcADHtSvu9axoSy1r r47SrRNhOa8aMNWZ+KK+c+UtNhuIo6J9R3Gp1/ritXWHWQqD5AD+ORJtJPhBDS/d6l tB9QeKGGjVdDBnYhrRp7ZTT0KY9W4yk1CCwfBAEOE4hJbOroV/OkY23VFql3dU0F18 rgmUdAyCZa5Rw== Date: Thu, 20 Nov 2025 00:47:39 +0000 From: Conor Dooley To: Emil Renner Berthing Cc: Hal Feng , E Shattow , Albert Ou , Bjorn Helgaas , Conor Dooley , Heinrich Schuchardt , Krzysztof Kozlowski , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manivannan Sadhasivam , Palmer Dabbelt , Paul Walmsley , "Rafael J . Wysocki" , Rob Herring , Viresh Kumar , "devicetree@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board Message-ID: <20251120-ambiguity-obsessive-b4ebf225d293@spud> References: <4a55301a-ef7e-4b47-8151-621cfba36ddd@freeshell.de> <20251118-throwing-marina-14a87d65465a@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HczvwQk9dFBg2zrj" Content-Disposition: inline In-Reply-To: --HczvwQk9dFBg2zrj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 19, 2025 at 05:27:30AM -0800, Emil Renner Berthing wrote: > Quoting Conor Dooley (2025-11-19 00:10:08) > > On Tue, Nov 18, 2025 at 02:12:58AM +0000, Hal Feng wrote: > > > > All, > > > > > > > > I repeat that the suggestion was made months ago (by Hal) to split = out the > > > > OPP tables per-board from the period of time when I was complaining= about > > > > 1.5GHz JH-7110 operation pushing TDP into over-temperature thermal = limit > > > > on Milk-V Mars CM SoM. > > > > > > > > Whether or not JH7110S is a new compatible should follow precedence= in > > > > Linux development. JH-7110S is evidently the same tape-out as JH-71= 10 and > > > > however you deal with that in Linux is the appropriate way to deal = with that > > > > here. Selection of OPP table for correct operation will be determin= ed by > > > > bootloader, where, it is demonstrated by patch series sent to U-Boot > > > > upstream to be selected ** per-board ** based on EEPROM content as = if it > > > > was any other JH-7110 board deciding dts based on EEPROM content. G= iven > > > > that it is the same tape-out I do not find a valid justification fo= r a new > > > > compatible in the stack of adjacent software besides going along wi= th some > > > > kind of marketing-driven answer about whether or not this is a new = SoC. > > > > > > > > What I care about now is that the VisionFive 2 Lite series is in go= od enough > > > > shape and there's a possibility to act on this months-old suggestio= n to split out > > > > the OPP tables which as we have confirmed the JH7110S is the same S= oC as > > > > JH7110 it makes a lot of sense to do. > > > > > > > > How is it supposed to work for binned silicon in Linux? > > > > > > Hi, Conor, Emil, > > > > > > What do you think about this? Hope to hear from you. > > > > Can someone just give me a yes/no question out of this thread? I'm not > > really immediately sure what's being asked of me. What exactly do you > > want to do with the opp-tables? "Split out" isn't super clear. Does that > > mean into board files? I am guessing it does, since you're saying that a > > particular board cannot support the 1.5 GHz mode. It's not unusual > > though to use delete node for unsupported opp-table entries, could that > > be done instead? >=20 > Yes, as far as I can tell we should be able to just add the board descrip= tion > like this: >=20 > jh7110.dtsi # JH7110 SoC description > |- jh7110-common.dtsi # Peripherals common to all JH7110 boards > |- jh7110-starfive-visionfive-2.dtsi # Peripherals common to VF2 boar= ds > | |- # Final VF2 board descriptions > |- jh7110-milkv-marscm.dtsi # Peripherals common to Mars CM boards > | |- # Final Mars CM board descriptions > |- # Other JH7110 board descriptions > + |- jh7110-starfive-visionfive-2-lite.dts >=20 > and have it do >=20 > &cpu_opp { > /delete-node/ opp-375000000; > /delete-node/ opp-500000000; > /delete-node/ opp-750000000; > /delete-node/ opp-1500000000; >=20 > opp-312500000 { > opp-hz =3D /bits/ 64 <312500000>; > opp-microvolt =3D <800000>; > }; > opp-417000000 { > opp-hz =3D /bits/ 64 <417000000>; > opp-microvolt =3D <800000>; > }; > opp-625000000 { > opp-hz =3D /bits/ 64 <625000000>; > opp-microvolt =3D <800000>; > }; > opp-1250000000 { > opp-hz =3D /bits/ 64 <1250000000>; > opp-microvolt =3D <1000000>; > }; > }; >=20 > This seems to be the minimal amount of changes needed. I looked through t= he > latest OpenSBI and it does match "starfive,jh7110s", but it treats it exa= ctly > the same as "starfive,jh7110" and Hal have not really given any other rea= son > we'd need new compatible strings. FWIW, chucking in the extra compatible is pretty straightforward if there's a respin to adjust to the above file layout, so can probably just go and do it. > E: I know this doesn't split out the opp table like you suggested, but I = think > that can come later if needed. Let's just start with the minimal amount of > changes to get the VF2 Lite supported. >=20 > Hal: Do you think this could work? You might need a patch to move some mmc > properties out of jh7110-common.dtsi I'm going to consider this "Changes Requested" then, and I'll expect another version with the file layout above. I was starting on my 6.19 PRs today, and I remembered that I actually have some dts material for the second week of the merge window, so you've got an extra week out of that Hal before it'd be 6.20 content instead. Cheers, Conor. --HczvwQk9dFBg2zrj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaR5lKwAKCRB4tDGHoIJi 0oBcAP48VjJAVIyq9kjFr/K/aTwxVR0ytZbmiCj2Yw4bGqqWWwD7B2lP8xHnX6C0 KOZFF18PpPgtMTG5AzDsCkU8YfJRbQ0= =YKzs -----END PGP SIGNATURE----- --HczvwQk9dFBg2zrj--