[PATCH 1/2] dt-bindings: net: allow the Agilex5 ethernet to have a fallback

[PATCH 1/2] dt-bindings: net: allow the Agilex5 ethernet to have a fallback

[Dinh Nguyen]

Add the generic "snps,dwxgmac" as a fallback binding for the Agilex5
ethernet controller.

Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
 Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index fc445ad5a1f1..b53847a2d953 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -46,6 +46,7 @@ properties:
       - items:
           - const: altr,socfpga-stmmac-agilex5
           - const: snps,dwxgmac-2.10
+          - const: snps,dwxgmac
 
   clocks:
     minItems: 1
-- 
2.42.0.411.g813d9a9188

[PATCH 2/2] arm64: dts: intel: agilex5: Add fallback compatible for XGMAC

[Dinh Nguyen]

From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>

commit 343ea11a2fe3 ("arm64: dts: Agilex5 Add gmac nodes to DTSI for
Agilex5") added the support for the platform specific GMAC controler on
Agilex5. We also need to have a fallback generic compatible, "snps,dwxgmac"
so the driver can load correctly in cases when the specific compatible
is missing.

Fixes: 343ea11a2fe3 ("arm64: dts: Agilex5 Add gmac nodes to DTSI for Agilex5")
Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index 04e99cd7e74b..83581e7a85ab 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -489,7 +489,8 @@ qspi: spi@108d2000 {
 
 		gmac0: ethernet@10810000 {
 			compatible = "altr,socfpga-stmmac-agilex5",
-				     "snps,dwxgmac-2.10";
+				     "snps,dwxgmac-2.10",
+				     "snps,dwxgmac";
 			reg = <0x10810000 0x3500>;
 			interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
@@ -601,7 +602,8 @@ queue7 {
 
 		gmac1: ethernet@10820000 {
 			compatible = "altr,socfpga-stmmac-agilex5",
-				     "snps,dwxgmac-2.10";
+				     "snps,dwxgmac-2.10",
+				     "snps,dwxgmac";
 			reg = <0x10820000 0x3500>;
 			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
@@ -713,7 +715,8 @@ queue7 {
 
 		gmac2: ethernet@10830000 {
 			compatible = "altr,socfpga-stmmac-agilex5",
-				     "snps,dwxgmac-2.10";
+				     "snps,dwxgmac-2.10",
+				     "snps,dwxgmac";
 			reg = <0x10830000 0x3500>;
 			interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
-- 
2.42.0.411.g813d9a9188

Re: [PATCH 1/2] dt-bindings: net: allow the Agilex5 ethernet to have a fallback

[Krzysztof Kozlowski]

On Wed, Nov 19, 2025 at 08:58:19PM -0600, Dinh Nguyen wrote:
> Add the generic "snps,dwxgmac" as a fallback binding for the Agilex5
> ethernet controller.
> 

I can see that from the diff, but I do not understand why.

We do not want generic compatibles, so obviously you should explain here
WHY we would accept something we do not want....

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: intel: agilex5: Add fallback compatible for XGMAC

[Krzysztof Kozlowski]

On Wed, Nov 19, 2025 at 08:58:20PM -0600, Dinh Nguyen wrote:
> From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
> 
> commit 343ea11a2fe3 ("arm64: dts: Agilex5 Add gmac nodes to DTSI for
> Agilex5") added the support for the platform specific GMAC controler on
> Agilex5. We also need to have a fallback generic compatible, "snps,dwxgmac"
> so the driver can load correctly in cases when the specific compatible
> is missing.

This is wrong. The specific compatible is not missing so you describe
impossible condition. We do not write code for impossible condition.

Best regards,
Krzysztof