devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Joan-Na-adi <joan.na.devcode@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Joan Na <joan.na@analog.com>
Subject: Re: [PATCH v6 1/2] regulator: dt-bindings: Add MAX77675 regulator
Date: Thu, 20 Nov 2025 09:03:43 -0600	[thread overview]
Message-ID: <20251120150343.GA1256330-robh@kernel.org> (raw)
In-Reply-To: <20251120125449.26530-2-joan.na@analog.com>

On Thu, Nov 20, 2025 at 09:54:48PM +0900, Joan-Na-adi wrote:
> From: Joan Na <joan.na@analog.com>
> 
> Add device tree binding YAML schema for the Maxim MAX77675 PMIC regulator.
> 
> Signed-off-by: Joan Na <joan.na@analog.com>
> ---
>  .../bindings/regulator/adi,max77675.yaml      | 188 ++++++++++++++++++
>  1 file changed, 188 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77675.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/adi,max77675.yaml b/Documentation/devicetree/bindings/regulator/adi,max77675.yaml
> new file mode 100644
> index 000000000000..54cbbd59ff5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,max77675.yaml
> @@ -0,0 +1,188 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,max77675.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX77675 PMIC Regulator
> +
> +maintainers:
> +  - Joan Na <joan.na@analog.com>
> +
> +description:
> +  The MAX77675 is a Power Management IC providing four switching buck
> +  regulators (SBB0–SBB3) accessible via I2C. It supports configuration
> +  of output voltages and enable controls for each regulator.
> +
> +allOf:
> +  - $ref: /schemas/input/input.yaml
> +  - $ref: /schemas/pinctrl/pincfg-node.yaml
> +
> +properties:
> +  compatible:
> +    const: adi,max77675
> +
> +  reg:
> +    maxItems: 1
> +
> +  reset-time-sec:
> +    description: Manual reset time in seconds
> +    enum: [4, 8, 12, 16]
> +    default: 4
> +
> +  bias-disable:
> +    type: boolean
> +    description: Disable internal pull-up for EN pin
> +    default: false

'default' does not make sense for boolean properties. default is how 
should the s/w handle the property not being present. That's always 
false for booleans and can't possibly be true as you have below.

With those dropped everywhere,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

  reply	other threads:[~2025-11-20 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 12:54 [PATCH v6 0/2] Add support for MAX77675 device Joan-Na-adi
2025-11-20 12:54 ` [PATCH v6 1/2] regulator: dt-bindings: Add MAX77675 regulator Joan-Na-adi
2025-11-20 15:03   ` Rob Herring [this message]
2025-11-24  6:20     ` Joan Na
2025-11-20 12:54 ` [PATCH v6 2/2] regulator: max77675: Add MAX77675 regulator driver Joan-Na-adi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120150343.GA1256330-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joan.na.devcode@gmail.com \
    --cc=joan.na@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).