devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Cc: kernel@oss.qualcomm.com, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Bjorn Andersson <andersson@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Subbaraman Narayanamurthy
	<subbaraman.narayanamurthy@oss.qualcomm.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage
Date: Thu, 20 Nov 2025 10:13:06 -0600	[thread overview]
Message-ID: <20251120161306.GA1468415-robh@kernel.org> (raw)
In-Reply-To: <20251119-lpg_triled_fix-v3-1-84b6dbdc774a@oss.qualcomm.com>

On Wed, Nov 19, 2025 at 02:06:42PM +0800, Fenglin Wu wrote:
> LPG channels can be used for only outputting PWM signals by routing to
> PMIC GPIOs without enabling TRILED. Explain this usage in the description
> for better clarity.
> 
> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 841a0229c472a4764426d25d9dbb900adc20fc11..c4b7e57b251845a6970b34bc9ae0c00647b1bf96 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -13,6 +13,11 @@ description: >
>    The Qualcomm Light Pulse Generator consists of three different hardware blocks;
>    a ramp generator with lookup table (LUT), the light pulse generator and a three
>    channel current sink. These blocks are found in a wide range of Qualcomm PMICs.
> +  The light pulse generator (LPG) can also be used independently to output PWM

Is this a separate paragraph or the same paragraph? The former needs a 
blank line.

Acked-by: Rob Herring (Arm) <robh@kernel.org>

> +  signal for standard PWM applications. In this scenario, the LPG output should
> +  be routed to a specific PMIC GPIO by setting the GPIO pin mux to the special
> +  functions indicated in the datasheet, the TRILED driver for the channel will
> +  not be enabled in this configuration.
>  
>  properties:
>    compatible:
> 
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2025-11-20 16:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19  6:06 [PATCH v3 0/2] leds: rgb: lpg: Don't enable TRILED when configuring PWM Fenglin Wu via B4 Relay
2025-11-19  6:06 ` [PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage Fenglin Wu via B4 Relay
2025-11-19 21:51   ` Bjorn Andersson
2025-11-20 16:13   ` Rob Herring [this message]
2025-11-19  6:06 ` [PATCH v3 2/2] leds: rgb: leds-qcom-lpg: Don't enable TRILED when configuring PWM Fenglin Wu via B4 Relay
2025-11-19 21:52   ` Bjorn Andersson
2025-11-20 15:25 ` [PATCH v3 0/2] leds: rgb: lpg: " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120161306.GA1468415-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fenglin.wu@oss.qualcomm.com \
    --cc=kernel@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=pavel@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=subbaraman.narayanamurthy@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).