From: Conor Dooley <conor@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>,
Peter Rosin <peda@axentia.se>, Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
devicetree@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org,
David Lechner <dlechner@baylibre.com>
Subject: Re: [PATCH 1/2] dt-bindings: mux: gpio-mux: add support for ADG1712
Date: Fri, 21 Nov 2025 18:25:28 +0000 [thread overview]
Message-ID: <20251121-privatize-decibel-72a37d50d269@spud> (raw)
In-Reply-To: <176373269741.263545.10849918874919174841.robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2410 bytes --]
On Fri, Nov 21, 2025 at 07:44:57AM -0600, Rob Herring (Arm) wrote:
>
> On Fri, 21 Nov 2025 11:57:31 +0000, Antoniu Miclaus wrote:
> > Add support for the Analog Devices ADG1712 quad SPST switch to the
> > existing GPIO multiplexer bindings. The ADG1712 contains four
> > independent single-pole/single-throw (SPST) switches, each controlled
> > by a dedicated GPIO pin.
> >
> > Unlike traditional multiplexers that use GPIOs as binary-encoded
> > selectors, the ADG1712 treats each GPIO as a direct switch controller.
> > The mux state represents the combination of all four switches, with
> > values from 0-15 corresponding to different switch combinations.
> >
> > For example, state 5 (binary 0101) represents:
> > - SW1: ON (GPIO0 = 1)
> > - SW2: OFF (GPIO1 = 0)
> > - SW3: ON (GPIO2 = 1)
> > - SW4: OFF (GPIO3 = 0)
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> > .../devicetree/bindings/mux/gpio-mux.yaml | 24 ++++++++++++++++++-
> > 1 file changed, 23 insertions(+), 1 deletion(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mux/gpio-mux.example.dtb: switch-controller (adi,adg1712): $nodename:0: 'switch-controller' does not match '^mux-controller(@.*|-([0-9]|[1-9][0-9]+))?$'
> from schema $id: http://devicetree.org/schemas/mux/mux-controller.yaml
There's a patch relaxing this restriction here:
https://lore.kernel.org/all/cb7c28ccf3a1b136e793b48720f816de7d5f75b2.1763737324.git.tommaso.merciai.xr@bp.renesas.com/
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251121115750.20119-2-antoniu.miclaus@analog.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-11-21 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 11:57 [PATCH 0/2] mux: gpio: add support for ADG1712 quad SPST switch Antoniu Miclaus
2025-11-21 11:57 ` [PATCH 1/2] dt-bindings: mux: gpio-mux: add support for ADG1712 Antoniu Miclaus
2025-11-21 13:44 ` Rob Herring (Arm)
2025-11-21 18:25 ` Conor Dooley [this message]
2025-11-21 11:57 ` [PATCH 2/2] mux: gpio: add support for ADG1712 quad SPST switch Antoniu Miclaus
2025-11-21 14:30 ` [PATCH 0/2] " David Lechner
2025-11-21 22:54 ` Peter Rosin
2025-11-26 14:44 ` Miclaus, Antoniu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121-privatize-decibel-72a37d50d269@spud \
--to=conor@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=johan+linaro@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox