From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5D6272E6E for ; Fri, 21 Nov 2025 20:55:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763758553; cv=none; b=cku4ew0Rw7qa3PAiVCIBN7NtQy5XXRdU7WuXtJqvPfG0rjdWh7j3dXecn8j5ffZiyMJ/z2BtZEO6GfReba/snwORdPVoF57LrpIXAyTXTZdwyxJvG9tO4pjiJXnlsreatwsJCMe5SHjjXyuszSzPzperp1dE5ASjBpv4A99t3aY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763758553; c=relaxed/simple; bh=lYUK59Z9lErXRf5Bg+aGnzF3C82gccjJNbgCi2t10u4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=moBJ7GCAKm17XApsWTYk6g4+3VgE94zsH2Nx1EBRcIqn1PQiQY1QRhifFvJCTZ3I70BuLDwzqjcq3+MujOBHosQOjCgcW+3PKv8P3xHACWbWfIgIcEPgH4u0Y4bKM8/tnkFPb+ghHYL6a8AB+Y4KJMCvm9TBnpBVS7MUvgZMqWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h42BLlMM; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h42BLlMM" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42b2de74838so206142f8f.2 for ; Fri, 21 Nov 2025 12:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763758550; x=1764363350; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SWLVJDOcbRGYcqao1ONr0boRiS6rHHZNiYodJCrm44Y=; b=h42BLlMMyKXqPMLsi4gNQ2+Ng3XSpkwmx0dC8ZAE2SnutTlyVFr9pY8+RilB9q+2d/ HLxqtROSm0f1pebN7bNkNt6mHaYLXCkVEgAa9sL3UurrK4mIXrxbMsOxwEXrafDO9egE 6suiAh9LszwJLTOOQayGxo49dWcQeGWLESyEXmTbhKRCVHW6w16KErywrUhFEY4o+EVs hKo+A+L87Fk5NmIC++Z7ox6IJ21nO/uSZQhYDw2ZEmWAtfWYr0grW/N+cP9ZmirQcPCf FeCJzutmNv/w9cdXxaoSDLwnRMCfQ2g6A4+lXPY3D+kf8LQEGaPk2MrsG1UAQDm0R4s3 +nVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763758550; x=1764363350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SWLVJDOcbRGYcqao1ONr0boRiS6rHHZNiYodJCrm44Y=; b=N/qtRaJ0aUpLBjaT7lIR/oH+GJbraNGS+medOtCQ2pxhXdqiuF2eudZYFPEFCLgrO+ 7RBCJKyS2uFSqZ6sWwvIKsQxCbaSJYxkeRZQeFwpIgc3j0IdkTUiN+4PKWzNNVR/BLQG zxM+hoNSWkjs4tTBoZvBUMQtUd+YXixYPdweUaL4RV5QmpScY7K/Z1e2qnhYzWLnIvub f7MqsB+qzT9n/FZsAVLF608blyeg5kXIRz7hTnQaom00iH1r4e4nHXdQYVb1oVFZdwMk SBQU2tWQaRqgCTmE65CdHPuLbT3rAyt432ay+fRx4//dmgRCmF//bJWjZG/i0l64GSCp XTKw== X-Forwarded-Encrypted: i=1; AJvYcCXR8+IWQeDURrLvW/36p5T2SsN8tb5jF7h4TxT5KYjP6XPkFxOMalG/csTo+sob6YRxprwvrh5fZoFb@vger.kernel.org X-Gm-Message-State: AOJu0YzBQf5KChiNLNRGx5fN9L3y3LgKPfXTiq7yM32HaIR+pVZd5ULv ZRoPTrlsYaieu9l7rEDvxJ3+JoUDCSfyW46ojeK0+hX5ba60cuvTSqqb X-Gm-Gg: ASbGncv5Q3ChX4o4obF91dUf5sAMn+LpQ7/cDcIWTIQmwUBwtjn55hNyURoOgvidvaz eQRCVHduOQ3r3/IUilzzMJ/c3dWkH10EgbqZaweeqptQofZBDRxjFiamh2B3c2ad2x2r5ArKpYB Wu081/XgcY1fxml1PhjPgQTJmRuj28rpQigOu63LTmt9X3Q0/1x+IY9iSJ1PosnazFQzY6V1kQU 3OrQEK4jHYjuBl/8HPVSj1WdFHtSiwLPKmZ+71+aMktxroeuAyP07JodTO63JIN9R2szTO3aCZX DO15XRiUR4v/R3JYdkT/uz2gGA8IC4bahp2tB9K/aDy83g4S0a0WBoKysbRyFf/ReG+Y6Z/WIj2 thxzsoSYNcc+EiFdyOWD3rTRxO15UQ1JT5259GWEe5RI350x8b4CM8V8+eHHbGrzFNdXe73u19G 8y0WA= X-Google-Smtp-Source: AGHT+IEpBti2Vot/ywXlhz/7XNq56k24q9qvbPMpnhnia8lGLDa9AtxVQGq2oXuumoaffzRpt9mvgQ== X-Received: by 2002:a05:6000:1ac9:b0:429:c851:69bb with SMTP id ffacd0b85a97d-42cc3f99224mr1830789f8f.5.1763758549737; Fri, 21 Nov 2025 12:55:49 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:b19f:2efa:e88a:a382]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e556sm12847859f8f.5.2025.11.21.12.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 12:55:48 -0800 (PST) Date: Fri, 21 Nov 2025 22:55:46 +0200 From: Vladimir Oltean To: Prabhakar Cc: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Philipp Zabel , Russell King , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH net-next 08/11] net: dsa: rzn1-a5psw: Make DSA tag protocol configurable via OF data Message-ID: <20251121205546.6bqpo2bn5sp3uxxu@skbuf> References: <20251121113553.2955854-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-9-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121113553.2955854-9-prabhakar.mahadev-lad.rj@bp.renesas.com> On Fri, Nov 21, 2025 at 11:35:34AM +0000, Prabhakar wrote: > From: Lad Prabhakar > > Update the RZN1 A5PSW driver to obtain the DSA tag protocol from > device-specific data instead of using a hard-coded value. Add a new > `tag_proto` field to `struct a5psw_of_data` and use it in > `a5psw_get_tag_protocol()` to return the appropriate protocol for > each SoC. > > This allows future SoCs such as RZ/T2H and RZ/N2H, which use the > DSA_TAG_PROTO_RZT2H_ETHSW tag format, to share the same driver > infrastructure without code duplication. Again the twitching when reading the commit title. I thought this has something to do with the "dsa-tag-protocol" property from Documentation/devicetree/bindings/net/dsa/dsa-port.yaml. The tagger *is* runtime-configurable if you implement the ds->ops->change_tag_protocol() API, and it's also possible to trigger that API function from OF properties. But this is not what the patch does, so it is confusing. I think it would be more natural to say "choose tagging protocol based on compatible string". > Signed-off-by: Lad Prabhakar > --- Anyway I'm not reviewing this commit until the reason why you added a new name for this tagger becomes completely clear.