Devicetree
 help / color / mirror / Atom feed
From: Akhil P Oommen <akhilpo@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
	Sean Paul <sean@poorly.run>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Jessica Zhang <jesszhan0024@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>
Subject: [PATCH v3 1/6] drm/msm/a6xx: Retrieve gmu core range by index
Date: Sat, 22 Nov 2025 03:22:15 +0530	[thread overview]
Message-ID: <20251122-qcs615-spin-2-v3-1-9f4d4c87f51d@oss.qualcomm.com> (raw)
In-Reply-To: <20251122-qcs615-spin-2-v3-0-9f4d4c87f51d@oss.qualcomm.com>

Some GPUs like A612 doesn't use a named register range resource. This
is because the reg-name property is discouraged when there is just a
single resource.

To address this, retrieve the 'gmu' register range by its index. It is
always guaranteed to be at index 0.

Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
 drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 5903cd891b49..9662201cd2e9 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -2029,21 +2029,19 @@ static int cxpd_notifier_cb(struct notifier_block *nb,
 	return 0;
 }
 
-static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev,
-		const char *name, resource_size_t *start)
+static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, resource_size_t *start)
 {
+	struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	void __iomem *ret;
-	struct resource *res = platform_get_resource_byname(pdev,
-			IORESOURCE_MEM, name);
 
 	if (!res) {
-		DRM_DEV_ERROR(&pdev->dev, "Unable to find the %s registers\n", name);
+		DRM_DEV_ERROR(&pdev->dev, "Unable to find the gmu core registers\n");
 		return ERR_PTR(-EINVAL);
 	}
 
 	ret = ioremap(res->start, resource_size(res));
 	if (!ret) {
-		DRM_DEV_ERROR(&pdev->dev, "Unable to map the %s registers\n", name);
+		DRM_DEV_ERROR(&pdev->dev, "Unable to map the gmu core registers\n");
 		return ERR_PTR(-EINVAL);
 	}
 
@@ -2085,7 +2083,7 @@ int a6xx_gmu_wrapper_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
 	gmu->nr_clocks = ret;
 
 	/* Map the GMU registers */
-	gmu->mmio = a6xx_gmu_get_mmio(pdev, "gmu", &start);
+	gmu->mmio = a6xx_gmu_get_mmio(pdev, &start);
 	if (IS_ERR(gmu->mmio)) {
 		ret = PTR_ERR(gmu->mmio);
 		goto err_mmio;
@@ -2244,7 +2242,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
 		goto err_memory;
 
 	/* Map the GMU registers */
-	gmu->mmio = a6xx_gmu_get_mmio(pdev, "gmu", &start);
+	gmu->mmio = a6xx_gmu_get_mmio(pdev, &start);
 	if (IS_ERR(gmu->mmio)) {
 		ret = PTR_ERR(gmu->mmio);
 		goto err_memory;

-- 
2.51.0


  reply	other threads:[~2025-11-21 21:52 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 21:52 [PATCH v3 0/6] Support for Adreno 612 GPU - Respin Akhil P Oommen
2025-11-21 21:52 ` Akhil P Oommen [this message]
2025-11-21 22:43   ` [PATCH v3 1/6] drm/msm/a6xx: Retrieve gmu core range by index Dmitry Baryshkov
2025-11-22 13:38   ` Konrad Dybcio
2025-11-24 22:10     ` Akhil P Oommen
2025-12-04 13:10     ` Akhil P Oommen
2025-12-04 13:30       ` Konrad Dybcio
2025-12-04 14:34         ` Rob Clark
2025-12-05 12:03           ` Konrad Dybcio
2025-11-21 21:52 ` [PATCH v3 2/6] dt-bindings: display/msm: gpu: Document A612 GPU Akhil P Oommen
2025-11-22 11:02   ` Krzysztof Kozlowski
2025-11-24 21:39     ` Akhil P Oommen
2025-11-25  7:58       ` Krzysztof Kozlowski
2025-11-28 10:29         ` Akhil P Oommen
2025-11-29  9:21           ` Krzysztof Kozlowski
2025-11-21 21:52 ` [PATCH v3 3/6] dt-bindings: display/msm/rgmu: Document A612 RGMU Akhil P Oommen
2025-11-22 11:03   ` Krzysztof Kozlowski
2025-11-21 21:52 ` [PATCH v3 4/6] arm64: dts: qcom: sm6150: add the GPU SMMU node Akhil P Oommen
2025-11-21 22:32   ` Dmitry Baryshkov
2025-11-22 13:59   ` Konrad Dybcio
2025-11-21 21:52 ` [PATCH v3 5/6] arm64: dts: qcom: sm6150: Add gpu and rgmu nodes Akhil P Oommen
2025-11-21 22:43   ` Dmitry Baryshkov
2025-11-22 14:03   ` Konrad Dybcio
2025-11-26  0:42     ` Dmitry Baryshkov
2025-12-04 10:13       ` Akhil P Oommen
2025-12-04 13:31         ` Konrad Dybcio
2025-12-05 13:41           ` Akhil P Oommen
2025-12-05 13:52             ` Konrad Dybcio
2025-12-05 14:05               ` Akhil P Oommen
2025-12-17 12:31                 ` Konrad Dybcio
2025-12-04 14:19         ` Dmitry Baryshkov
2025-12-05 10:29           ` Akhil P Oommen
2025-12-05 20:34             ` Dmitry Baryshkov
2025-12-10 21:10               ` Akhil P Oommen
2025-12-11  0:36                 ` Dmitry Baryshkov
2025-12-11 11:12                   ` Akhil P Oommen
2025-12-11 11:52                     ` Akhil P Oommen
2025-12-11 13:26                       ` Dmitry Baryshkov
2025-12-11 19:31                         ` Akhil P Oommen
2025-12-12 19:28                           ` Dmitry Baryshkov
2025-12-22  7:19                             ` Akhil P Oommen
2025-12-22  9:15                               ` Dmitry Baryshkov
2025-12-22 10:54                                 ` Akhil P Oommen
2025-12-22 11:24                                   ` Dmitry Baryshkov
2025-12-22 18:29                                     ` Akhil P Oommen
2025-12-24  0:37                                       ` Dmitry Baryshkov
2025-11-21 21:52 ` [PATCH v3 6/6] arm64: dts: qcom: qcs615-ride: Enable Adreno 612 GPU Akhil P Oommen
2025-11-21 22:44   ` Dmitry Baryshkov
2025-11-24 14:28 ` [PATCH v3 0/6] Support for Adreno 612 GPU - Respin Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251122-qcs615-spin-2-v3-1-9f4d4c87f51d@oss.qualcomm.com \
    --to=akhilpo@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox