From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389DD2BDC01 for ; Sat, 22 Nov 2025 05:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763787644; cv=none; b=IHZ9Hn7emMwiPYgVO6wigMru1Xh4HJc7d6WNoskyIJhfnpzwmq+BSjrYWOtktNgVYq5Klf9R3FeSkIvXQR28+jNr+dg/TyXdPjtBvNTbADjHABn+vx3IgywbpJJjfaBBRTlue43or4dlvuAPcG+3a7WPIQpeJh8fR8TwRcqsLQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763787644; c=relaxed/simple; bh=cwIEc0HF5caawSt6gOxOI+pMExQY63TqviBqzRA+S28=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ejkMevqmKxu+Q+xTdR7Ahg3AuID7RnuvHr8XAGfNhftucep8C50y77VvVOGXjJs470EFn1SYc40xBVxgd4aAv8nUCZMqNL+wrZsqsqy8YxVhXVLRmI2+6SMcdmwTGvrplusYudnP+dFrgtd/AlT4yWzcH0KthUlIzvZFN6jkbg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jtx8FVeM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bk5dVVa/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jtx8FVeM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bk5dVVa/" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AM4YOBg1760842 for ; Sat, 22 Nov 2025 05:00:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=OykaP3QXAEq G4yI9kL9Noaj3OcsMMG9dgRdTlVS4bzE=; b=Jtx8FVeM4gSL3KVXYJA7rVkDVUX 4ovtx7+yA/0WZBL5xT4EuLcSQNCh8ChwYzfb16fpQjWE5RL6VJIH6x8SvPFgju7v cy/fxdGQVka/nHNME1A0L2XkCN+nMUeXVjes6VzCxgYIdQZyk3GOUGtsgi9JaXD4 XfRuo9bhe/T5Xp3Scqi87Gjy39J48Rcvx25+gRPxSrNvqStRadBuZsmXSJ3/Tk0i wu5galeIkVLy/clHi3PoFgL1jzwNJW4PFBjZyhKNtuSUbS3vmu9NBPQOw51m4zQh 6fkKZwuSPU0jmCoovmFwwionx0Y+fHOVbwDYbL+ubLi84pwhUPrm87Xuu0g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak691g1cd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 22 Nov 2025 05:00:42 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-299d221b749so70746095ad.3 for ; Fri, 21 Nov 2025 21:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763787641; x=1764392441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OykaP3QXAEqG4yI9kL9Noaj3OcsMMG9dgRdTlVS4bzE=; b=bk5dVVa/30F7K3qseNbgR69ybf5b8CLgH/ZaZ/T3+d3Tchaw2FeJHlNZtoSaCfTqrG 37XCdaR1nsKnqyUJcHymSk9frnmI9C4ocq/vStGbCFHjRRC8nfcyXx9r4I+aO+OdQwlp +A7z+YW5CgKB7dGHmPILulEkIlpO7ul3hC0AGnZBNR6uSp7qipBj+VylrKIvJ5UqTbHr 60Ao/TcVKCToE82lEIS8540e1aNrBJVAATJh93+H5D8RAVqqT3PwZ8etjCK6yO2TNdHd YTjbWKf5RBVApoqw/WUkOYkPQzNmoOuBUvWXr0Q9FBKuiseoEtbFOJSvB/lJUpJfXY0P 14MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763787641; x=1764392441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OykaP3QXAEqG4yI9kL9Noaj3OcsMMG9dgRdTlVS4bzE=; b=m3rjSpRZiIHHV07pX6kbO9g+Bh4SZomvZiB141FDRAhCYnqrcx12soaab1NvxSdpf4 PIFBPyfq9vzySCL0UnaTeM0u3B/NuDujt414J3LkUCCM1B0Azk7Z/N2wx963ENFmUkma uuIYsWkmr5H4Gmy8t/82yQ2CZKq5ECdsbX3JLXNX4a09xMVq3pOfaYTk0InEaBDTjFR8 QbK9w1KHVT/UbN9z6GFlair22yAZSHDYfnxjdjUYw6iYO2DV/U6UXy9XODkukgcu+jrp L54ZS546jetHgCo2N4h2vHcDM50rHjMmFQtRc5YFc8jAijFSpYVi384E4DUX+m8z82Z9 O8Bg== X-Forwarded-Encrypted: i=1; AJvYcCVj+GM+3+30KB1FFksmVXF74l/sU/xclHXUR4IrL0vwElVjLff85tArHbw7UGiKaMiloeZ7IRC2DTep@vger.kernel.org X-Gm-Message-State: AOJu0YyoShyYZcr2yBw82q0fizyiKOKM61F0Qz+dwhhsGCY5S7vQ4j/S iQ/LOLM6+qw+RTWFqP+Ptulad2dLPRxN7+CJv0of+5Vz1YONETSp6ZH0XR2HHiyNLHi47Rj8YYG cZxjl6Mqhg8y+rG01z/hIOFvDBczgVWeFoN2lb/iU2UV2PvtW+h5ypHIpAWJdMh99 X-Gm-Gg: ASbGncvE7cH+Rn3EatI8YOHmQ8086u9Lo3aStFKk/1FcUpQWMBDB+4MgvTuNAp5z/sK jm37oVmqZpmueogDjz6UIkW+jfLcGi8mHDhhH5b5DAiXobFVF1sD2GkR8zCAByUodiZJ1V4CwaI 9hiK3IDl7+DzGzibfrYdM7ZcrMDbvsY9Udb2LXnlwQ1Eds7pVkmIl4qa1SUvI1YVpJAefmmdHQN FC9gl2waUdewgV8nxZcOcQCxPp5jKnExpksYZLO2D2Fj5aL6OM931BWAw8SnyGUTwlPCuNFoe+f Fzy0igfuzEs3E6Fqv0XRlvZXme99YvHcPflTaFvvCAu0+S9hkfSwrvNHn6baRn+U5oDnfZeCmyb ZfA5f9XxU6flUWj7HTKTtq2BrbPs35WmzOkfK3yxSICA= X-Received: by 2002:a17:902:ebc1:b0:27e:f018:d312 with SMTP id d9443c01a7336-29b6c3c71c1mr57439075ad.1.1763787641081; Fri, 21 Nov 2025 21:00:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzaJB3tETHFGPKwtS5H4CJ4sdq+g/8P4mFhp+moshcF5KdpfshYLuqDo5fwCI563FmZq1eIg== X-Received: by 2002:a17:902:ebc1:b0:27e:f018:d312 with SMTP id d9443c01a7336-29b6c3c71c1mr57438695ad.1.1763787640449; Fri, 21 Nov 2025 21:00:40 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b138c08sm70688725ad.25.2025.11.21.21.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 21:00:40 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: psodagud@quicinc.com, djaggi@quicinc.com, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com, quic_arandive@quicinc.com, quic_shazhuss@quicinc.com, Konrad Dybcio Subject: [PATCH v1 01/12] soc: qcom: geni-se: Refactor geni_icc_get() and make qup-memory ICC path optional Date: Sat, 22 Nov 2025 10:30:07 +0530 Message-Id: <20251122050018.283669-2-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251122050018.283669-1-praveen.talari@oss.qualcomm.com> References: <20251122050018.283669-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Be3VE7t2 c=1 sm=1 tr=0 ts=6921437a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=GTpMjWLy6HWSKpZSgkwA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 0VSMAQ4NIy0Rus2pnJ-J7YmKoATHzQWt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDAzNiBTYWx0ZWRfXy4b18nnrfcMm tJ5lZqfGh86F9QkhmVMd/8Cg56PMjzbGnD0pe+QDI4p7UHcA4q2673zfX/hivAYreELo+WBc0qp GjjnwnkUJ31hHBFX0/esPiyOHYxjwY1bdOdGxC80WlygsEnoYmz/aZKp4jBqnry1EUpvEgKQOJI 3rse/s7DUcm4ikYdht18N6lAJh8fjYMWDnPUz/Gev7/oO8upgcv8B+qnnT+i4ky4UOv72jX68GA ywTbutR1NavpaeY9OUlfGPp2bLFiOaZpJ6JN90bWvjGTG0GO8qZ7ERcyUw3qKe6FQXEaZerWj/G NtRCn3Nq7QSK0/WudCXDD4bBGemDasyYd5EBUwMFpKTHsdPLGiPNCNe060CKdWmPwkaC4Ye8NQj +DK8gSue1SPgHlR0XY5hitUWTYgcxw== X-Proofpoint-GUID: 0VSMAQ4NIy0Rus2pnJ-J7YmKoATHzQWt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-22_01,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511220036 Refactor the geni_icc_get() function to replace the loop-based ICC path initialization with explicit handling of each interconnect path. This improves code readability and allows for different error handling per path type. The "qup-core" and "qup-config" paths remain mandatory, while "qup-memory" is now optional and skipped if not defined in DT. Co-developed-by: Konrad Dybcio Signed-off-by: Konrad Dybcio Signed-off-by: Praveen Talari --- drivers/soc/qcom/qcom-geni-se.c | 36 +++++++++++++++++---------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index cd1779b6a91a..b6167b968ef6 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -899,30 +899,32 @@ EXPORT_SYMBOL_GPL(geni_se_rx_dma_unprep); int geni_icc_get(struct geni_se *se, const char *icc_ddr) { - int i, err; - const char *icc_names[] = {"qup-core", "qup-config", icc_ddr}; + struct geni_icc_path *icc_paths = se->icc_paths; if (has_acpi_companion(se->dev)) return 0; - for (i = 0; i < ARRAY_SIZE(se->icc_paths); i++) { - if (!icc_names[i]) - continue; - - se->icc_paths[i].path = devm_of_icc_get(se->dev, icc_names[i]); - if (IS_ERR(se->icc_paths[i].path)) - goto err; + icc_paths[GENI_TO_CORE].path = devm_of_icc_get(se->dev, "qup-core"); + if (IS_ERR(icc_paths[GENI_TO_CORE].path)) + return dev_err_probe(se->dev, PTR_ERR(icc_paths[GENI_TO_CORE].path), + "Failed to get 'qup-core' ICC path\n"); + + icc_paths[CPU_TO_GENI].path = devm_of_icc_get(se->dev, "qup-config"); + if (IS_ERR(icc_paths[CPU_TO_GENI].path)) + return dev_err_probe(se->dev, PTR_ERR(icc_paths[CPU_TO_GENI].path), + "Failed to get 'qup-config' ICC path\n"); + + /* The DDR path is optional, depending on protocol and hw capabilities */ + icc_paths[GENI_TO_DDR].path = devm_of_icc_get(se->dev, "qup-memory"); + if (IS_ERR(icc_paths[GENI_TO_DDR].path)) { + if (PTR_ERR(icc_paths[GENI_TO_DDR].path) == -ENODATA) + icc_paths[GENI_TO_DDR].path = NULL; + else + return dev_err_probe(se->dev, PTR_ERR(icc_paths[GENI_TO_DDR].path), + "Failed to get 'qup-memory' ICC path\n"); } return 0; - -err: - err = PTR_ERR(se->icc_paths[i].path); - if (err != -EPROBE_DEFER) - dev_err_ratelimited(se->dev, "Failed to get ICC path '%s': %d\n", - icc_names[i], err); - return err; - } EXPORT_SYMBOL_GPL(geni_icc_get); -- 2.34.1