From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78F5B2FE58C; Sat, 22 Nov 2025 12:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763816387; cv=none; b=djCZd9QdBv9tq1L0bI+8OdAX3/YxSEFEQ0qwoDUI63g9Ju58bUbL4Co7LmG/yUtmAFZAVfz4uQA6E8g0K8Vg/YQZ1g/N5+gAHgFi3Zrlr9Z/Snm2wQs4dFID08QLHas66N8qT8B2y4aczbm0wM04InSBIL5TvwqI+Pxx3fqfINc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763816387; c=relaxed/simple; bh=lU8e23cemYXKiQz6hMY/07BBnKwPI1FxngRSfte8urw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M2yI5p1XGf0gYdKDGbIz0/75WwqJv2VcS8p2or5KQP//OfocROIf4qYL6Z+Ga/y6FjGSpBYY1ea6dzZMk4SKmghZGNhsdI6lx68PUJPnnJKBh9ZWBrnoxmU9ZPRFokMdcZiVrwvzHKwmhXVWPx70KAZI9FP7Es79BnjMRAcwyq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y3bEfjx8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y3bEfjx8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8410AC116D0; Sat, 22 Nov 2025 12:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763816387; bh=lU8e23cemYXKiQz6hMY/07BBnKwPI1FxngRSfte8urw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3bEfjx84UN2rXBcH2W4kC/VfiT7mbT8zFHnSzp6dvnrXy9r1I9uRvuLj42IbEjBO MF2ivrM+tas/zGgi6TZY6afpip/J/zkFDQkfF4GDePF7+ZtLF8aQaXEYrQ/tUtvHrf TeQbaq3zHs1j6VSAdDV+ONdOktwafZWejueow3UA= Date: Sat, 22 Nov 2025 13:59:36 +0100 From: Greg Kroah-Hartman To: Roy Luo Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?iso-8859-1?Q?Andr=E9?= Draszik , Tudor Ambarus , Thinh Nguyen , Philipp Zabel , Badhri Jagan Sridharan , Doug Anderson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Joy Chakraborty , Naveen Kumar Subject: Re: [PATCH v8 2/2] usb: dwc3: Add Google Tensor SoC DWC3 glue driver Message-ID: <2025112226-heave-refrain-53e6@gregkh> References: <20251122-controller-v8-0-e7562e0df658@google.com> <20251122-controller-v8-2-e7562e0df658@google.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251122-controller-v8-2-e7562e0df658@google.com> On Sat, Nov 22, 2025 at 09:32:06AM +0000, Roy Luo wrote: > Add support for the DWC3 USB controller found on Google Tensor G5 > (codename: laguna). The controller features dual-role functionality > and hibernation. > > The primary focus is implementing hibernation support in host mode, > enabling the controller to enter a low-power state (D3). This is > particularly relevant during system power state transition and > runtime power management for power efficiency. > Highlights: > - Align suspend callback with dwc3_suspend_common() for deciding > between a full teardown and hibernation in host mode. > - Integration with `psw` (power switchable) and `top` power domains, > managing their states and device links to support hibernation. > - A notifier callback dwc3_google_usb_psw_pd_notifier() for > `psw` power domain events to manage controller state > transitions to/from D3. > - Coordination of the `non_sticky` reset during power state > transitions, asserting it on D3 entry and deasserting on D0 entry > in hibernation scenario. > - Handling of high-speed and super-speed PME interrupts > that are generated by remote wakeup during hibernation. > > Co-developed-by: Joy Chakraborty > Signed-off-by: Joy Chakraborty > Co-developed-by: Naveen Kumar > Signed-off-by: Naveen Kumar > Signed-off-by: Roy Luo > --- > drivers/usb/dwc3/Kconfig | 13 + > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-google.c | 628 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 642 insertions(+) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 4925d15084f816d3ff92059b476ebcc799b56b51..f58c70dabf108878cbefe0abea88572d9ae81e26 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -200,4 +200,17 @@ config USB_DWC3_GENERIC_PLAT > the dwc3 child node in the device tree. > Say 'Y' or 'M' here if your platform integrates DWC3 in a similar way. > > +config USB_DWC3_GOOGLE > + tristate "Google Platform" > + depends on COMPILE_TEST > + depends on OF && COMMON_CLK && RESET_CONTROLLER Shouldn't this be: depends on (OF && COMMON_CLK && RESET_CONTROLLER) || COMPILE_TEST I shouldn't have to enable those options to just get a build test here, the apis should be properly stubbed out if those options are not enabled, right? thanks, greg k-h