[PATCH v3 0/2] riscv: dts: starfive: Add OrangePi RV board

[PATCH v3 0/2] riscv: dts: starfive: Add OrangePi RV board

[E Shattow]

Icenowy is busy and so with their permission I have applied v2 review
feedback. Additionally I revise the commit messages. This should now be in
good shape for -next

- E

Changes since v2:
- enable active high mmc1 card detect gpio
- drop delete-node from mmc0 reset pins following commit fa939a287224
  ("dts: starfive: jh7110-common: split out mmc0 reset pins from common 
  into boards")
- sort phy0 properties rx before tx
- revise commit description of SoC peripherals as list
- revise commit description of compatible binding

Changes in v2:
- Property order change mentioned in the review of v1.
- Added Wi-Fi (along with the always on VCC3V3_PCIE regulator, which is
  used to power up WIFI_3V3). The OOB IRQ is still not possible to use
  because of some incompatibility between StarFive pinctrl driver and
  brcmfmac.
- Removed the LED because it's in common DTSI.

Icenowy Zheng (2):
  dt-bindings: riscv: starfive: add xunlong,orangepi-rv
  riscv: dts: starfive: add Orange Pi RV

 .../devicetree/bindings/riscv/starfive.yaml   |  1 +
 arch/riscv/boot/dts/starfive/Makefile         |  1 +
 .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 76 +++++++++++++++++++
 3 files changed, 78 insertions(+)
 create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts


base-commit: 1088d49b626487777913079bef0db3adef4bfb4a
-- 
2.50.0

[PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[E Shattow]

From: Icenowy Zheng <uwu@icenowy.me>

Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based board.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: E Shattow <e@freeshell.de>
---
 Documentation/devicetree/bindings/riscv/starfive.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
index 04510341a71e..3fdeab9d8f08 100644
--- a/Documentation/devicetree/bindings/riscv/starfive.yaml
+++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
@@ -33,6 +33,7 @@ properties:
               - pine64,star64
               - starfive,visionfive-2-v1.2a
               - starfive,visionfive-2-v1.3b
+              - xunlong,orangepi-rv
           - const: starfive,jh7110
 
 additionalProperties: true
-- 
2.50.0

[PATCH v3 2/2] riscv: dts: starfive: add Orange Pi RV

[E Shattow]

From: Icenowy Zheng <uwu@icenowy.me>

Orange Pi RV is a SBC based on the StarFive VisionFive 2 board.

Orange Pi RV features:

- StarFive JH7110 SoC
- GbE port connected to JH7110 GMAC0 via YT8531 PHY
- 4x USB ports via VL805 PCIe USB controller connected to JH7110 pcie0
- M.2 M-key slot connected to JH7110 pcie1
- HDMI video output
- 3.5mm audio output
- Ampak AP6256 SDIO Wi-Fi/Bluetooth module on mmc0
- microSD slot on mmc1
- SPI NOR flash memory
- 24c02 EEPROM (read only by default)

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: E Shattow <e@freeshell.de>
---
 arch/riscv/boot/dts/starfive/Makefile         |  1 +
 .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts

diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile
index 62b659f89ba7..d34c8c79bc10 100644
--- a/arch/riscv/boot/dts/starfive/Makefile
+++ b/arch/riscv/boot/dts/starfive/Makefile
@@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-deepcomputing-fml13v01.dtb
 dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-mars.dtb
 dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-emmc.dtb
 dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-lite.dtb
+dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-orangepi-rv.dtb
 dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-pine64-star64.dtb
 dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-v1.2a.dtb
 dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-v1.3b.dtb
diff --git a/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
new file mode 100644
index 000000000000..16ec2767134e
--- /dev/null
+++ b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: GPL-2.0 OR MIT
+/*
+ * Copyright (C) 2025 Icenowy Zheng <uwu@icenowy.me>
+ */
+
+/dts-v1/;
+#include "jh7110-common.dtsi"
+
+/ {
+	model = "Xunlong Orange Pi RV";
+	compatible = "xunlong,orangepi-rv", "starfive,jh7110";
+
+	/* This regulator is always on by hardware */
+	reg_vcc3v3_pcie: regulator-vcc3v3-pcie {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3-pcie";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	wifi_pwrseq: wifi-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&sysgpio 62 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&gmac0 {
+	assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>;
+	assigned-clock-parents = <&aoncrg JH7110_AONCLK_GMAC0_RMII_RTX>;
+	starfive,tx-use-rgmii-clk;
+	status = "okay";
+};
+
+&mmc0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	cap-sd-highspeed;
+	mmc-pwrseq = <&wifi_pwrseq>;
+	vmmc-supply = <&reg_vcc3v3_pcie>;
+	vqmmc-supply = <&vcc_3v3>;
+	status = "okay";
+
+	ap6256: wifi@1 {
+		compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-fmac";
+		reg = <1>;
+		/* TODO: out-of-band IRQ on GPIO21 */
+	};
+};
+
+&mmc1 {
+	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_HIGH>;
+};
+
+&pcie0 {
+	status = "okay";
+};
+
+&pcie1 {
+	status = "okay";
+};
+
+&phy0 {
+	rx-internal-delay-ps = <1500>;
+	tx-internal-delay-ps = <1500>;
+	motorcomm,rx-clk-drv-microamp = <3970>;
+	motorcomm,rx-data-drv-microamp = <2910>;
+	motorcomm,tx-clk-adj-enabled;
+	motorcomm,tx-clk-10-inverted;
+	motorcomm,tx-clk-100-inverted;
+	motorcomm,tx-clk-1000-inverted;
+};
+
+&pwmdac {
+	status = "okay";
+};
-- 
2.50.0

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Krzysztof Kozlowski]

On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
> From: Icenowy Zheng <uwu@icenowy.me>
> 
> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based board.
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> Signed-off-by: E Shattow <e@freeshell.de>

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Re: [PATCH v3 2/2] riscv: dts: starfive: add Orange Pi RV

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 3985 bytes --]

On Sun, Nov 23, 2025 at 02:50:45PM -0800, E Shattow wrote:
> From: Icenowy Zheng <uwu@icenowy.me>
> 
> Orange Pi RV is a SBC based on the StarFive VisionFive 2 board.
> 
> Orange Pi RV features:
> 
> - StarFive JH7110 SoC
> - GbE port connected to JH7110 GMAC0 via YT8531 PHY
> - 4x USB ports via VL805 PCIe USB controller connected to JH7110 pcie0
> - M.2 M-key slot connected to JH7110 pcie1
> - HDMI video output
> - 3.5mm audio output
> - Ampak AP6256 SDIO Wi-Fi/Bluetooth module on mmc0
> - microSD slot on mmc1
> - SPI NOR flash memory
> - 24c02 EEPROM (read only by default)
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> Signed-off-by: E Shattow <e@freeshell.de>
> ---
>  arch/riscv/boot/dts/starfive/Makefile         |  1 +
>  .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 76 +++++++++++++++++++
>  2 files changed, 77 insertions(+)
>  create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> 
> diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile
> index 62b659f89ba7..d34c8c79bc10 100644
> --- a/arch/riscv/boot/dts/starfive/Makefile
> +++ b/arch/riscv/boot/dts/starfive/Makefile
> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-deepcomputing-fml13v01.dtb
>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-mars.dtb
>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-emmc.dtb
>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-lite.dtb
> +dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-orangepi-rv.dtb
>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-pine64-star64.dtb
>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-v1.2a.dtb
>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-v1.3b.dtb
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> new file mode 100644
> index 000000000000..16ec2767134e
> --- /dev/null
> +++ b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> @@ -0,0 +1,76 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> +/*
> + * Copyright (C) 2025 Icenowy Zheng <uwu@icenowy.me>
> + */
> +
> +/dts-v1/;
> +#include "jh7110-common.dtsi"
> +
> +/ {
> +	model = "Xunlong Orange Pi RV";
> +	compatible = "xunlong,orangepi-rv", "starfive,jh7110";
> +
> +	/* This regulator is always on by hardware */
> +	reg_vcc3v3_pcie: regulator-vcc3v3-pcie {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc3v3-pcie";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +	};
> +
> +	wifi_pwrseq: wifi-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&sysgpio 62 GPIO_ACTIVE_LOW>;
> +	};
> +};
> +
> +&gmac0 {
> +	assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>;
> +	assigned-clock-parents = <&aoncrg JH7110_AONCLK_GMAC0_RMII_RTX>;
> +	starfive,tx-use-rgmii-clk;
> +	status = "okay";
> +};
> +
> +&mmc0 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	cap-sd-highspeed;
> +	mmc-pwrseq = <&wifi_pwrseq>;
> +	vmmc-supply = <&reg_vcc3v3_pcie>;
> +	vqmmc-supply = <&vcc_3v3>;
> +	status = "okay";
> +
> +	ap6256: wifi@1 {
> +		compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-fmac";
> +		reg = <1>;
> +		/* TODO: out-of-band IRQ on GPIO21 */

What's up with this TODO? Why's the gpio not here? Missing binding
support, missing driver support?

> +	};
> +};
> +
> +&mmc1 {
> +	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&pcie0 {
> +	status = "okay";
> +};
> +
> +&pcie1 {
> +	status = "okay";
> +};
> +
> +&phy0 {
> +	rx-internal-delay-ps = <1500>;
> +	tx-internal-delay-ps = <1500>;
> +	motorcomm,rx-clk-drv-microamp = <3970>;
> +	motorcomm,rx-data-drv-microamp = <2910>;
> +	motorcomm,tx-clk-adj-enabled;
> +	motorcomm,tx-clk-10-inverted;
> +	motorcomm,tx-clk-100-inverted;
> +	motorcomm,tx-clk-1000-inverted;
> +};
> +
> +&pwmdac {
> +	status = "okay";
> +};
> -- 
> 2.50.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/2] riscv: dts: starfive: add Orange Pi RV

[Icenowy Zheng]

在 2025-11-24星期一的 11:07 +0000，Conor Dooley写道：
> On Sun, Nov 23, 2025 at 02:50:45PM -0800, E Shattow wrote:
> > From: Icenowy Zheng <uwu@icenowy.me>
> > 
> > Orange Pi RV is a SBC based on the StarFive VisionFive 2 board.
> > 
> > Orange Pi RV features:
> > 
> > - StarFive JH7110 SoC
> > - GbE port connected to JH7110 GMAC0 via YT8531 PHY
> > - 4x USB ports via VL805 PCIe USB controller connected to JH7110
> > pcie0
> > - M.2 M-key slot connected to JH7110 pcie1
> > - HDMI video output
> > - 3.5mm audio output
> > - Ampak AP6256 SDIO Wi-Fi/Bluetooth module on mmc0
> > - microSD slot on mmc1
> > - SPI NOR flash memory
> > - 24c02 EEPROM (read only by default)
> > 
> > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > Signed-off-by: E Shattow <e@freeshell.de>
> > ---
> >  arch/riscv/boot/dts/starfive/Makefile         |  1 +
> >  .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 76
> > +++++++++++++++++++
> >  2 files changed, 77 insertions(+)
> >  create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi-
> > rv.dts
> > 
> > diff --git a/arch/riscv/boot/dts/starfive/Makefile
> > b/arch/riscv/boot/dts/starfive/Makefile
> > index 62b659f89ba7..d34c8c79bc10 100644
> > --- a/arch/riscv/boot/dts/starfive/Makefile
> > +++ b/arch/riscv/boot/dts/starfive/Makefile
> > @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-
> > deepcomputing-fml13v01.dtb
> >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-mars.dtb
> >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-emmc.dtb
> >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-lite.dtb
> > +dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-orangepi-rv.dtb
> >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-pine64-star64.dtb
> >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-
> > v1.2a.dtb
> >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-
> > v1.3b.dtb
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> > b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> > new file mode 100644
> > index 000000000000..16ec2767134e
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> > @@ -0,0 +1,76 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2025 Icenowy Zheng <uwu@icenowy.me>
> > + */
> > +
> > +/dts-v1/;
> > +#include "jh7110-common.dtsi"
> > +
> > +/ {
> > +       model = "Xunlong Orange Pi RV";
> > +       compatible = "xunlong,orangepi-rv", "starfive,jh7110";
> > +
> > +       /* This regulator is always on by hardware */
> > +       reg_vcc3v3_pcie: regulator-vcc3v3-pcie {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "vcc3v3-pcie";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <3300000>;
> > +               regulator-always-on;
> > +       };
> > +
> > +       wifi_pwrseq: wifi-pwrseq {
> > +               compatible = "mmc-pwrseq-simple";
> > +               reset-gpios = <&sysgpio 62 GPIO_ACTIVE_LOW>;
> > +       };
> > +};
> > +
> > +&gmac0 {
> > +       assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>;
> > +       assigned-clock-parents = <&aoncrg
> > JH7110_AONCLK_GMAC0_RMII_RTX>;
> > +       starfive,tx-use-rgmii-clk;
> > +       status = "okay";
> > +};
> > +
> > +&mmc0 {
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
> > +       cap-sd-highspeed;
> > +       mmc-pwrseq = <&wifi_pwrseq>;
> > +       vmmc-supply = <&reg_vcc3v3_pcie>;
> > +       vqmmc-supply = <&vcc_3v3>;
> > +       status = "okay";
> > +
> > +       ap6256: wifi@1 {
> > +               compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-
> > fmac";
> > +               reg = <1>;
> > +               /* TODO: out-of-band IRQ on GPIO21 */
> 
> What's up with this TODO? Why's the gpio not here? Missing binding
> support, missing driver support?

Missing driver support in the pinctrl driver.

> 
> > +       };
> > +};
> > +
> > +&mmc1 {
> > +       cd-gpios = <&sysgpio 41 GPIO_ACTIVE_HIGH>;
> > +};
> > +
> > +&pcie0 {
> > +       status = "okay";
> > +};
> > +
> > +&pcie1 {
> > +       status = "okay";
> > +};
> > +
> > +&phy0 {
> > +       rx-internal-delay-ps = <1500>;
> > +       tx-internal-delay-ps = <1500>;
> > +       motorcomm,rx-clk-drv-microamp = <3970>;
> > +       motorcomm,rx-data-drv-microamp = <2910>;
> > +       motorcomm,tx-clk-adj-enabled;
> > +       motorcomm,tx-clk-10-inverted;
> > +       motorcomm,tx-clk-100-inverted;
> > +       motorcomm,tx-clk-1000-inverted;
> > +};
> > +
> > +&pwmdac {
> > +       status = "okay";
> > +};
> > -- 
> > 2.50.0
> > 

Re: [PATCH v3 2/2] riscv: dts: starfive: add Orange Pi RV

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 5597 bytes --]

On Mon, Nov 24, 2025 at 07:08:55PM +0800, Icenowy Zheng wrote:
> 在 2025-11-24星期一的 11:07 +0000，Conor Dooley写道：
> > On Sun, Nov 23, 2025 at 02:50:45PM -0800, E Shattow wrote:
> > > From: Icenowy Zheng <uwu@icenowy.me>
> > > 
> > > Orange Pi RV is a SBC based on the StarFive VisionFive 2 board.
> > > 
> > > Orange Pi RV features:
> > > 
> > > - StarFive JH7110 SoC
> > > - GbE port connected to JH7110 GMAC0 via YT8531 PHY
> > > - 4x USB ports via VL805 PCIe USB controller connected to JH7110
> > > pcie0
> > > - M.2 M-key slot connected to JH7110 pcie1
> > > - HDMI video output
> > > - 3.5mm audio output
> > > - Ampak AP6256 SDIO Wi-Fi/Bluetooth module on mmc0
> > > - microSD slot on mmc1
> > > - SPI NOR flash memory
> > > - 24c02 EEPROM (read only by default)
> > > 
> > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > > Signed-off-by: E Shattow <e@freeshell.de>
> > > ---
> > >  arch/riscv/boot/dts/starfive/Makefile         |  1 +
> > >  .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 76
> > > +++++++++++++++++++
> > >  2 files changed, 77 insertions(+)
> > >  create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi-
> > > rv.dts
> > > 
> > > diff --git a/arch/riscv/boot/dts/starfive/Makefile
> > > b/arch/riscv/boot/dts/starfive/Makefile
> > > index 62b659f89ba7..d34c8c79bc10 100644
> > > --- a/arch/riscv/boot/dts/starfive/Makefile
> > > +++ b/arch/riscv/boot/dts/starfive/Makefile
> > > @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-
> > > deepcomputing-fml13v01.dtb
> > >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-mars.dtb
> > >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-emmc.dtb
> > >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-lite.dtb
> > > +dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-orangepi-rv.dtb
> > >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-pine64-star64.dtb
> > >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-
> > > v1.2a.dtb
> > >  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-
> > > v1.3b.dtb
> > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> > > b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> > > new file mode 100644
> > > index 000000000000..16ec2767134e
> > > --- /dev/null
> > > +++ b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
> > > @@ -0,0 +1,76 @@
> > > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > > +/*
> > > + * Copyright (C) 2025 Icenowy Zheng <uwu@icenowy.me>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "jh7110-common.dtsi"
> > > +
> > > +/ {
> > > +       model = "Xunlong Orange Pi RV";
> > > +       compatible = "xunlong,orangepi-rv", "starfive,jh7110";
> > > +
> > > +       /* This regulator is always on by hardware */
> > > +       reg_vcc3v3_pcie: regulator-vcc3v3-pcie {
> > > +               compatible = "regulator-fixed";
> > > +               regulator-name = "vcc3v3-pcie";
> > > +               regulator-min-microvolt = <3300000>;
> > > +               regulator-max-microvolt = <3300000>;
> > > +               regulator-always-on;
> > > +       };
> > > +
> > > +       wifi_pwrseq: wifi-pwrseq {
> > > +               compatible = "mmc-pwrseq-simple";
> > > +               reset-gpios = <&sysgpio 62 GPIO_ACTIVE_LOW>;
> > > +       };
> > > +};
> > > +
> > > +&gmac0 {
> > > +       assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>;
> > > +       assigned-clock-parents = <&aoncrg
> > > JH7110_AONCLK_GMAC0_RMII_RTX>;
> > > +       starfive,tx-use-rgmii-clk;
> > > +       status = "okay";
> > > +};
> > > +
> > > +&mmc0 {
> > > +       #address-cells = <1>;
> > > +       #size-cells = <0>;
> > > +       cap-sd-highspeed;
> > > +       mmc-pwrseq = <&wifi_pwrseq>;
> > > +       vmmc-supply = <&reg_vcc3v3_pcie>;
> > > +       vqmmc-supply = <&vcc_3v3>;
> > > +       status = "okay";
> > > +
> > > +       ap6256: wifi@1 {
> > > +               compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-
> > > fmac";
> > > +               reg = <1>;
> > > +               /* TODO: out-of-band IRQ on GPIO21 */
> > 
> > What's up with this TODO? Why's the gpio not here? Missing binding
> > support, missing driver support?
> 
> Missing driver support in the pinctrl driver.

Provided Emil is okay with the patchset, I'll probably modify the
comment to mention what the todo depends on then.

> 
> > 
> > > +       };
> > > +};
> > > +
> > > +&mmc1 {
> > > +       cd-gpios = <&sysgpio 41 GPIO_ACTIVE_HIGH>;
> > > +};
> > > +
> > > +&pcie0 {
> > > +       status = "okay";
> > > +};
> > > +
> > > +&pcie1 {
> > > +       status = "okay";
> > > +};
> > > +
> > > +&phy0 {
> > > +       rx-internal-delay-ps = <1500>;
> > > +       tx-internal-delay-ps = <1500>;
> > > +       motorcomm,rx-clk-drv-microamp = <3970>;
> > > +       motorcomm,rx-data-drv-microamp = <2910>;
> > > +       motorcomm,tx-clk-adj-enabled;
> > > +       motorcomm,tx-clk-10-inverted;
> > > +       motorcomm,tx-clk-100-inverted;
> > > +       motorcomm,tx-clk-1000-inverted;
> > > +};
> > > +
> > > +&pwmdac {
> > > +       status = "okay";
> > > +};
> > > -- 
> > > 2.50.0
> > > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski wrote:
> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
> > From: Icenowy Zheng <uwu@icenowy.me>
> > 
> > Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based board.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > Signed-off-by: E Shattow <e@freeshell.de>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

It's from me, don't resubmit just to add it since it'll be me applying
anyway.

> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
> 
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/2] riscv: dts: starfive: add Orange Pi RV

[E Shattow]

On 11/24/25 05:21, Conor Dooley wrote:
> On Mon, Nov 24, 2025 at 07:08:55PM +0800, Icenowy Zheng wrote:
>> 在 2025-11-24星期一的 11:07 +0000，Conor Dooley写道：
>>> On Sun, Nov 23, 2025 at 02:50:45PM -0800, E Shattow wrote:
>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>
>>>> Orange Pi RV is a SBC based on the StarFive VisionFive 2 board.
>>>>
>>>> Orange Pi RV features:
>>>>
>>>> - StarFive JH7110 SoC
>>>> - GbE port connected to JH7110 GMAC0 via YT8531 PHY
>>>> - 4x USB ports via VL805 PCIe USB controller connected to JH7110
>>>> pcie0
>>>> - M.2 M-key slot connected to JH7110 pcie1
>>>> - HDMI video output
>>>> - 3.5mm audio output

>>>> - Ampak AP6256 SDIO Wi-Fi/Bluetooth module on mmc0

Discussion below about TODO comment and out-of-band IRQ applies to the
above featured device named in the commit message. I don't have this
board and so I reformat the commit message without adding statements
about what is working or not working compared to the VisionFive 2 common
features. There is certainly not a complete devicetree in this series to
enable the wireless connectivity features. I don't know about other
features, for example the audio and HDMI video output.

>>>> - microSD slot on mmc1
>>>> - SPI NOR flash memory
>>>> - 24c02 EEPROM (read only by default)
>>>>
>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>> ---
>>>>  arch/riscv/boot/dts/starfive/Makefile         |  1 +
>>>>  .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 76
>>>> +++++++++++++++++++
>>>>  2 files changed, 77 insertions(+)
>>>>  create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi-
>>>> rv.dts
>>>>
>>>> diff --git a/arch/riscv/boot/dts/starfive/Makefile
>>>> b/arch/riscv/boot/dts/starfive/Makefile
>>>> index 62b659f89ba7..d34c8c79bc10 100644
>>>> --- a/arch/riscv/boot/dts/starfive/Makefile
>>>> +++ b/arch/riscv/boot/dts/starfive/Makefile
>>>> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-
>>>> deepcomputing-fml13v01.dtb
>>>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-mars.dtb
>>>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-emmc.dtb
>>>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-marscm-lite.dtb
>>>> +dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-orangepi-rv.dtb
>>>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-pine64-star64.dtb
>>>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-
>>>> v1.2a.dtb
>>>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2-
>>>> v1.3b.dtb
>>>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
>>>> b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
>>>> new file mode 100644
>>>> index 000000000000..16ec2767134e
>>>> --- /dev/null
>>>> +++ b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts
>>>> @@ -0,0 +1,76 @@
>>>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>>>> +/*
>>>> + * Copyright (C) 2025 Icenowy Zheng <uwu@icenowy.me>
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +#include "jh7110-common.dtsi"
>>>> +
>>>> +/ {
>>>> +       model = "Xunlong Orange Pi RV";
>>>> +       compatible = "xunlong,orangepi-rv", "starfive,jh7110";
>>>> +
>>>> +       /* This regulator is always on by hardware */
>>>> +       reg_vcc3v3_pcie: regulator-vcc3v3-pcie {
>>>> +               compatible = "regulator-fixed";
>>>> +               regulator-name = "vcc3v3-pcie";
>>>> +               regulator-min-microvolt = <3300000>;
>>>> +               regulator-max-microvolt = <3300000>;
>>>> +               regulator-always-on;
>>>> +       };
>>>> +
>>>> +       wifi_pwrseq: wifi-pwrseq {
>>>> +               compatible = "mmc-pwrseq-simple";
>>>> +               reset-gpios = <&sysgpio 62 GPIO_ACTIVE_LOW>;
>>>> +       };
>>>> +};
>>>> +
>>>> +&gmac0 {
>>>> +       assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>;
>>>> +       assigned-clock-parents = <&aoncrg
>>>> JH7110_AONCLK_GMAC0_RMII_RTX>;
>>>> +       starfive,tx-use-rgmii-clk;
>>>> +       status = "okay";
>>>> +};
>>>> +
>>>> +&mmc0 {
>>>> +       #address-cells = <1>;
>>>> +       #size-cells = <0>;
>>>> +       cap-sd-highspeed;
>>>> +       mmc-pwrseq = <&wifi_pwrseq>;
>>>> +       vmmc-supply = <&reg_vcc3v3_pcie>;
>>>> +       vqmmc-supply = <&vcc_3v3>;
>>>> +       status = "okay";
>>>> +
>>>> +       ap6256: wifi@1 {
>>>> +               compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-
>>>> fmac";
>>>> +               reg = <1>;
>>>> +               /* TODO: out-of-band IRQ on GPIO21 */
>>>
>>> What's up with this TODO? Why's the gpio not here? Missing binding
>>> support, missing driver support?
>>
>> Missing driver support in the pinctrl driver.
> 
> Provided Emil is okay with the patchset, I'll probably modify the
> comment to mention what the todo depends on then.
> 

Conor, amending the TODO comment and/or commit message sounds good to me
if you want to.

The need for out-of-band IRQ also applies to Milk-V Mars CM of the same
AP6256 chipset SDIO functionality, where however, it does not appear to
me to be the same use of GPIO21.

Milk-V vendor board support package has compatible = "bcmdhd_wlan" for
an Android driver on the 5.15 kernel not present in mainline Linux today:

https://github.com/milkv-mars/mars-buildroot-sdk/blob/dev/linux/arch/riscv/boot/dts/starfive/jh7110-milkv-mars-cm.dtsi

So it's a different driver now than the vendor stuff and can likely be
improved to be functional but I'm not sure what to do. When Icenowy or
anyone will make suggestions I can test for Milk-V Mars CM, and add the
remaining devicetree description there too when it is known what to do.

-E

>>
>>>
>>>> +       };
>>>> +};
>>>> +
>>>> +&mmc1 {
>>>> +       cd-gpios = <&sysgpio 41 GPIO_ACTIVE_HIGH>;
>>>> +};
>>>> +
>>>> +&pcie0 {
>>>> +       status = "okay";
>>>> +};
>>>> +
>>>> +&pcie1 {
>>>> +       status = "okay";
>>>> +};
>>>> +
>>>> +&phy0 {
>>>> +       rx-internal-delay-ps = <1500>;
>>>> +       tx-internal-delay-ps = <1500>;
>>>> +       motorcomm,rx-clk-drv-microamp = <3970>;
>>>> +       motorcomm,rx-data-drv-microamp = <2910>;
>>>> +       motorcomm,tx-clk-adj-enabled;
>>>> +       motorcomm,tx-clk-10-inverted;
>>>> +       motorcomm,tx-clk-100-inverted;
>>>> +       motorcomm,tx-clk-1000-inverted;
>>>> +};
>>>> +
>>>> +&pwmdac {
>>>> +       status = "okay";
>>>> +};
>>>> -- 
>>>> 2.50.0
>>>>
>>

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[E Shattow]

On 11/24/25 05:22, Conor Dooley wrote:
> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski wrote:
>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>
>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based board.
>>>
>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>> Signed-off-by: E Shattow <e@freeshell.de>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
> 
> It's from me, don't resubmit just to add it since it'll be me applying
> anyway.
> 

Hi Conor,

Okay. Yes I'd dropped the tag since the commit message is appreciably
different, and you would be handling it again anyways. Thanks! And thank
you Krzysztof for the reminder -E

>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions of patchset, under or above your Signed-off-by tag, unless
>> patch changed significantly (e.g. new properties added to the DT
>> bindings). Tag is "received", when provided in a message replied to you
>> on the mailing list. Tools like b4 can help here. However, there's no
>> need to repost patches *only* to add the tags. The upstream maintainer
>> will do that for tags received on the version they apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Krzysztof Kozlowski]

On 24/11/2025 22:59, E Shattow wrote:
> 
> On 11/24/25 05:22, Conor Dooley wrote:
>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski wrote:
>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>
>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based board.
>>>>
>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>
>>> <form letter>
>>> This is a friendly reminder during the review process.
>>>
>>> It looks like you received a tag and forgot to add it.
>>
>> It's from me, don't resubmit just to add it since it'll be me applying
>> anyway.
>>
> 
> Hi Conor,
> 
> Okay. Yes I'd dropped the tag since the commit message is appreciably
> different, and you would be handling it again anyways. Thanks! And thank
> you Krzysztof for the reminder -E


And where did you explain that you dropped the tag because of that?
Please read the form letter carefully.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Icenowy Zheng]

在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
> On 24/11/2025 22:59, E Shattow wrote:
> > 
> > On 11/24/25 05:22, Conor Dooley wrote:
> > > On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
> > > wrote:
> > > > On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
> > > > > From: Icenowy Zheng <uwu@icenowy.me>
> > > > > 
> > > > > Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
> > > > > board.
> > > > > 
> > > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > > > > Signed-off-by: E Shattow <e@freeshell.de>
> > > > 
> > > > <form letter>
> > > > This is a friendly reminder during the review process.
> > > > 
> > > > It looks like you received a tag and forgot to add it.
> > > 
> > > It's from me, don't resubmit just to add it since it'll be me
> > > applying
> > > anyway.
> > > 
> > 
> > Hi Conor,
> > 
> > Okay. Yes I'd dropped the tag since the commit message is
> > appreciably
> > different, and you would be handling it again anyways. Thanks! And
> > thank
> > you Krzysztof for the reminder -E
> 
> 
> And where did you explain that you dropped the tag because of that?
> Please read the form letter carefully.

Well I think there's no clear definition of "the patch has changed
substantially" here.

E may think for this such-short patch, the commit message weighs a lot
and the change to it is significant to the patch (e.g. making the patch
not clear enough).

> 
> Best regards,
> Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Krzysztof Kozlowski]

On 25/11/2025 08:33, Icenowy Zheng wrote:
> 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
>> On 24/11/2025 22:59, E Shattow wrote:
>>>
>>> On 11/24/25 05:22, Conor Dooley wrote:
>>>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
>>>> wrote:
>>>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>>>
>>>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
>>>>>> board.
>>>>>>
>>>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>>>
>>>>> <form letter>
>>>>> This is a friendly reminder during the review process.
>>>>>
>>>>> It looks like you received a tag and forgot to add it.
>>>>
>>>> It's from me, don't resubmit just to add it since it'll be me
>>>> applying
>>>> anyway.
>>>>
>>>
>>> Hi Conor,
>>>
>>> Okay. Yes I'd dropped the tag since the commit message is
>>> appreciably
>>> different, and you would be handling it again anyways. Thanks! And
>>> thank
>>> you Krzysztof for the reminder -E
>>
>>
>> And where did you explain that you dropped the tag because of that?
>> Please read the form letter carefully.
> 
> Well I think there's no clear definition of "the patch has changed
> substantially" here.
> 
> E may think for this such-short patch, the commit message weighs a lot
> and the change to it is significant to the patch (e.g. making the patch
> not clear enough).

You still did not bother to read what we expect. I do not discuss if
this changed significantly or not, although it is obvious that it did
not change and tag should have been retained.

Look again:
<QUOTE>
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</QUOTE>

Where did you explain that?


Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Icenowy Zheng]

在 2025-11-25星期二的 08:48 +0100，Krzysztof Kozlowski写道：
> On 25/11/2025 08:33, Icenowy Zheng wrote:
> > 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
> > > On 24/11/2025 22:59, E Shattow wrote:
> > > > 
> > > > On 11/24/25 05:22, Conor Dooley wrote:
> > > > > On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
> > > > > wrote:
> > > > > > On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
> > > > > > > From: Icenowy Zheng <uwu@icenowy.me>
> > > > > > > 
> > > > > > > Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
> > > > > > > board.
> > > > > > > 
> > > > > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > > > > > > Signed-off-by: E Shattow <e@freeshell.de>
> > > > > > 
> > > > > > <form letter>
> > > > > > This is a friendly reminder during the review process.
> > > > > > 
> > > > > > It looks like you received a tag and forgot to add it.
> > > > > 
> > > > > It's from me, don't resubmit just to add it since it'll be me
> > > > > applying
> > > > > anyway.
> > > > > 
> > > > 
> > > > Hi Conor,
> > > > 
> > > > Okay. Yes I'd dropped the tag since the commit message is
> > > > appreciably
> > > > different, and you would be handling it again anyways. Thanks!
> > > > And
> > > > thank
> > > > you Krzysztof for the reminder -E
> > > 
> > > 
> > > And where did you explain that you dropped the tag because of
> > > that?
> > > Please read the form letter carefully.
> > 
> > Well I think there's no clear definition of "the patch has changed
> > substantially" here.
> > 
> > E may think for this such-short patch, the commit message weighs a
> > lot
> > and the change to it is significant to the patch (e.g. making the
> > patch
> > not clear enough).
> 
> You still did not bother to read what we expect. I do not discuss if
> this changed significantly or not, although it is obvious that it did
> not change and tag should have been retained.
> 
> Look again:
> <QUOTE>
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </QUOTE>
> 
> Where did you explain that?

Sure, I agree that explaination of this should be delivered.

> 
> 
> Best regards,
> Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[E Shattow]

On 11/25/25 00:01, Icenowy Zheng wrote:
> 在 2025-11-25星期二的 08:48 +0100，Krzysztof Kozlowski写道：
>> On 25/11/2025 08:33, Icenowy Zheng wrote:
>>> 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
>>>> On 24/11/2025 22:59, E Shattow wrote:
>>>>>
>>>>> On 11/24/25 05:22, Conor Dooley wrote:
>>>>>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
>>>>>> wrote:
>>>>>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>>>>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>>>>>
>>>>>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
>>>>>>>> board.
>>>>>>>>
>>>>>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>>>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>>>>>
>>>>>>> <form letter>
>>>>>>> This is a friendly reminder during the review process.
>>>>>>>
>>>>>>> It looks like you received a tag and forgot to add it.
>>>>>>
>>>>>> It's from me, don't resubmit just to add it since it'll be me
>>>>>> applying
>>>>>> anyway.
>>>>>>
>>>>>
>>>>> Hi Conor,
>>>>>
>>>>> Okay. Yes I'd dropped the tag since the commit message is
>>>>> appreciably
>>>>> different, and you would be handling it again anyways. Thanks!
>>>>> And
>>>>> thank
>>>>> you Krzysztof for the reminder -E
>>>>
>>>>
>>>> And where did you explain that you dropped the tag because of
>>>> that?
>>>> Please read the form letter carefully.
>>>
>>> Well I think there's no clear definition of "the patch has changed
>>> substantially" here.
>>>
>>> E may think for this such-short patch, the commit message weighs a
>>> lot
>>> and the change to it is significant to the patch (e.g. making the
>>> patch
>>> not clear enough).
>>
>> You still did not bother to read what we expect. I do not discuss if
>> this changed significantly or not, although it is obvious that it did
>> not change and tag should have been retained.
>>
>> Look again:
>> <QUOTE>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </QUOTE>
>>
>> Where did you explain that?
> 
> Sure, I agree that explaination of this should be delivered.
> 
>>
>>
>> Best regards,
>> Krzysztof
> 

Krzysztof,

The submitting-patches document does not support your assertion in this
situation. I evidently have a different understanding of than you, as
when I read it before sending the series I did arrive at the action of:

1. Acked-by is less formal and so it is a matter of opinion and
judgement whether to retain it or not. I choose not to here due to
changes visible in the commit log (the commit messages and titles). I
would let Conor decide if they will acknowledge the revised series
instead of making that decision for them.

2. I am not required to mention the drop of any Acked-by tag in the
cover letter for this situation. Conor is handling this series so I do
need to participate on the mailing list when there's a question or
comment about picking up the lack of Acked-by.

I am in the understanding at the exchange between Conor and I that this
concern of yours will be resolved without my input depending on the
review from Emil. Let us know what/if more specific and actionable needs
done and whom by you expect it to be done.

Thank you,

-E

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 3703 bytes --]

On Tue, Nov 25, 2025 at 05:07:00AM -0800, E Shattow wrote:
> 
> 
> On 11/25/25 00:01, Icenowy Zheng wrote:
> > 在 2025-11-25星期二的 08:48 +0100，Krzysztof Kozlowski写道：
> >> On 25/11/2025 08:33, Icenowy Zheng wrote:
> >>> 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
> >>>> On 24/11/2025 22:59, E Shattow wrote:
> >>>>>
> >>>>> On 11/24/25 05:22, Conor Dooley wrote:
> >>>>>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
> >>>>>> wrote:
> >>>>>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
> >>>>>>>> From: Icenowy Zheng <uwu@icenowy.me>
> >>>>>>>>
> >>>>>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
> >>>>>>>> board.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> >>>>>>>> Signed-off-by: E Shattow <e@freeshell.de>
> >>>>>>>
> >>>>>>> <form letter>
> >>>>>>> This is a friendly reminder during the review process.
> >>>>>>>
> >>>>>>> It looks like you received a tag and forgot to add it.
> >>>>>>
> >>>>>> It's from me, don't resubmit just to add it since it'll be me
> >>>>>> applying
> >>>>>> anyway.
> >>>>>>
> >>>>>
> >>>>> Hi Conor,
> >>>>>
> >>>>> Okay. Yes I'd dropped the tag since the commit message is
> >>>>> appreciably
> >>>>> different, and you would be handling it again anyways. Thanks!
> >>>>> And
> >>>>> thank
> >>>>> you Krzysztof for the reminder -E
> >>>>
> >>>>
> >>>> And where did you explain that you dropped the tag because of
> >>>> that?
> >>>> Please read the form letter carefully.
> >>>
> >>> Well I think there's no clear definition of "the patch has changed
> >>> substantially" here.
> >>>
> >>> E may think for this such-short patch, the commit message weighs a
> >>> lot
> >>> and the change to it is significant to the patch (e.g. making the
> >>> patch
> >>> not clear enough).
> >>
> >> You still did not bother to read what we expect. I do not discuss if
> >> this changed significantly or not, although it is obvious that it did
> >> not change and tag should have been retained.
> >>
> >> Look again:
> >> <QUOTE>
> >> Please read:
> >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> >>
> >> If a tag was not added on purpose, please state why and what changed.
> >> </QUOTE>
> >>
> >> Where did you explain that?
> > 
> > Sure, I agree that explaination of this should be delivered.
> > 
> >>
> >>
> >> Best regards,
> >> Krzysztof
> > 
> 
> Krzysztof,
> 
> The submitting-patches document does not support your assertion in this
> situation. I evidently have a different understanding of than you, as
> when I read it before sending the series I did arrive at the action of:
> 
> 1. Acked-by is less formal and so it is a matter of opinion and
> judgement whether to retain it or not. I choose not to here due to
> changes visible in the commit log (the commit messages and titles). I
> would let Conor decide if they will acknowledge the revised series
> instead of making that decision for them.

If anything, acked-by being "less formal" would mean that it's more
resistant to chances in the patch.

> 2. I am not required to mention the drop of any Acked-by tag in the
> cover letter for this situation. Conor is handling this series so I do
> need to participate on the mailing list when there's a question or
> comment about picking up the lack of Acked-by.

If I were you, I would pretty much always mention the reason for
dropping tags unless the changelog or cover letter contains some pretty
drastic changes between versions thereby making it really obvious why
the tags are gone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 0/2] riscv: dts: starfive: Add OrangePi RV board

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

On Sun, 23 Nov 2025 14:50:43 -0800, E Shattow wrote:
> Icenowy is busy and so with their permission I have applied v2 review
> feedback. Additionally I revise the commit messages. This should now be in
> good shape for -next
> 
> - E
> 
> Changes since v2:
> - enable active high mmc1 card detect gpio
> - drop delete-node from mmc0 reset pins following commit fa939a287224
>   ("dts: starfive: jh7110-common: split out mmc0 reset pins from common
>   into boards")
> - sort phy0 properties rx before tx
> - revise commit description of SoC peripherals as list
> - revise commit description of compatible binding
> 
> [...]

Applied to riscv-dt-for-next, thanks! I know I mentioned waiting for
Emil, but this stuff is actually fairly simple so I just went ahead
with grabbing it.

[1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv
      https://git.kernel.org/conor/c/d94ebab404b0
[2/2] riscv: dts: starfive: add Orange Pi RV
      https://git.kernel.org/conor/c/5b70764e1019

Thanks,
Conor.

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[Krzysztof Kozlowski]

On 25/11/2025 14:07, E Shattow wrote:
> 
> 
> On 11/25/25 00:01, Icenowy Zheng wrote:
>> 在 2025-11-25星期二的 08:48 +0100，Krzysztof Kozlowski写道：
>>> On 25/11/2025 08:33, Icenowy Zheng wrote:
>>>> 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
>>>>> On 24/11/2025 22:59, E Shattow wrote:
>>>>>>
>>>>>> On 11/24/25 05:22, Conor Dooley wrote:
>>>>>>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
>>>>>>> wrote:
>>>>>>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>>>>>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>>>>>>
>>>>>>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
>>>>>>>>> board.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>>>>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>>>>>>
>>>>>>>> <form letter>
>>>>>>>> This is a friendly reminder during the review process.
>>>>>>>>
>>>>>>>> It looks like you received a tag and forgot to add it.
>>>>>>>
>>>>>>> It's from me, don't resubmit just to add it since it'll be me
>>>>>>> applying
>>>>>>> anyway.
>>>>>>>
>>>>>>
>>>>>> Hi Conor,
>>>>>>
>>>>>> Okay. Yes I'd dropped the tag since the commit message is
>>>>>> appreciably
>>>>>> different, and you would be handling it again anyways. Thanks!
>>>>>> And
>>>>>> thank
>>>>>> you Krzysztof for the reminder -E
>>>>>
>>>>>
>>>>> And where did you explain that you dropped the tag because of
>>>>> that?
>>>>> Please read the form letter carefully.
>>>>
>>>> Well I think there's no clear definition of "the patch has changed
>>>> substantially" here.
>>>>
>>>> E may think for this such-short patch, the commit message weighs a
>>>> lot
>>>> and the change to it is significant to the patch (e.g. making the
>>>> patch
>>>> not clear enough).
>>>
>>> You still did not bother to read what we expect. I do not discuss if
>>> this changed significantly or not, although it is obvious that it did
>>> not change and tag should have been retained.
>>>
>>> Look again:
>>> <QUOTE>
>>> Please read:
>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>>
>>> If a tag was not added on purpose, please state why and what changed.
>>> </QUOTE>
>>>
>>> Where did you explain that?
>>
>> Sure, I agree that explaination of this should be delivered.
>>
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>
> 
> Krzysztof,
> 
> The submitting-patches document does not support your assertion in this

I sent patch to fix that because that was too literal. Ack has the same
rules as Rb.

> situation. I evidently have a different understanding of than you, as
> when I read it before sending the series I did arrive at the action of:
> 
> 1. Acked-by is less formal and so it is a matter of opinion and
> judgement whether to retain it or not. I choose not to here due to
> changes visible in the commit log (the commit messages and titles). I
> would let Conor decide if they will acknowledge the revised series
> instead of making that decision for them.

I value my time and you dropping the tag causes the patch appearing for
our review AGAIN. Doing review again without any explanation from
submitter feels like someone is not respecting our time, therefore,
since you keep disagreeing on that matter, I will switch to patches from
other authors.


Best regards,
Krzysztof

Re: [PATCH v3 0/2] riscv: dts: starfive: Add OrangePi RV board

[Emil Renner Berthing]

Quoting Conor Dooley (2025-11-25 23:24:37)
> From: Conor Dooley <conor.dooley@microchip.com>
>
> On Sun, 23 Nov 2025 14:50:43 -0800, E Shattow wrote:
> > Icenowy is busy and so with their permission I have applied v2 review
> > feedback. Additionally I revise the commit messages. This should now be in
> > good shape for -next
> >
> > - E
> >
> > Changes since v2:
> > - enable active high mmc1 card detect gpio
> > - drop delete-node from mmc0 reset pins following commit fa939a287224
> >   ("dts: starfive: jh7110-common: split out mmc0 reset pins from common
> >   into boards")
> > - sort phy0 properties rx before tx
> > - revise commit description of SoC peripherals as list
> > - revise commit description of compatible binding
> >
> > [...]
>
> Applied to riscv-dt-for-next, thanks! I know I mentioned waiting for
> Emil, but this stuff is actually fairly simple so I just went ahead
> with grabbing it.

That's fine thanks. I was under the impression that this still needed some work,
but it seems like you've fixed it up when merging.

In case you still want it here is my

Acked-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>

Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

[E Shattow]

On 11/25/25 11:14, Conor Dooley wrote:
> On Tue, Nov 25, 2025 at 05:07:00AM -0800, E Shattow wrote:
>>
>>
>> On 11/25/25 00:01, Icenowy Zheng wrote:
>>> 在 2025-11-25星期二的 08:48 +0100，Krzysztof Kozlowski写道：
>>>> On 25/11/2025 08:33, Icenowy Zheng wrote:
>>>>> 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
>>>>>> On 24/11/2025 22:59, E Shattow wrote:
>>>>>>>
>>>>>>> On 11/24/25 05:22, Conor Dooley wrote:
>>>>>>>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
>>>>>>>> wrote:
>>>>>>>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>>>>>>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>>>>>>>
>>>>>>>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
>>>>>>>>>> board.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>>>>>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>>>>>>>
>>>>>>>>> <form letter>
>>>>>>>>> This is a friendly reminder during the review process.
>>>>>>>>>
>>>>>>>>> It looks like you received a tag and forgot to add it.
>>>>>>>>
>>>>>>>> It's from me, don't resubmit just to add it since it'll be me
>>>>>>>> applying
>>>>>>>> anyway.
>>>>>>>>
>>>>>>>
>>>>>>> Hi Conor,
>>>>>>>
>>>>>>> Okay. Yes I'd dropped the tag since the commit message is
>>>>>>> appreciably
>>>>>>> different, and you would be handling it again anyways. Thanks!
>>>>>>> And
>>>>>>> thank
>>>>>>> you Krzysztof for the reminder -E
>>>>>>
>>>>>>
>>>>>> And where did you explain that you dropped the tag because of
>>>>>> that?
>>>>>> Please read the form letter carefully.
>>>>>
>>>>> Well I think there's no clear definition of "the patch has changed
>>>>> substantially" here.
>>>>>
>>>>> E may think for this such-short patch, the commit message weighs a
>>>>> lot
>>>>> and the change to it is significant to the patch (e.g. making the
>>>>> patch
>>>>> not clear enough).
>>>>
>>>> You still did not bother to read what we expect. I do not discuss if
>>>> this changed significantly or not, although it is obvious that it did
>>>> not change and tag should have been retained.
>>>>
>>>> Look again:
>>>> <QUOTE>
>>>> Please read:
>>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>>>
>>>> If a tag was not added on purpose, please state why and what changed.
>>>> </QUOTE>
>>>>
>>>> Where did you explain that?
>>>
>>> Sure, I agree that explaination of this should be delivered.
>>>
>>>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>
>> Krzysztof,
>>
>> The submitting-patches document does not support your assertion in this
>> situation. I evidently have a different understanding of than you, as
>> when I read it before sending the series I did arrive at the action of:
>>
>> 1. Acked-by is less formal and so it is a matter of opinion and
>> judgement whether to retain it or not. I choose not to here due to
>> changes visible in the commit log (the commit messages and titles). I
>> would let Conor decide if they will acknowledge the revised series
>> instead of making that decision for them.
> 
> If anything, acked-by being "less formal" would mean that it's more
> resistant to chances in the patch.
> 

That is an interesting "read between the lines" opposite meaning of
formality than what I understand it to be. I'm making my internal mental
note, weird, but okay.

>> 2. I am not required to mention the drop of any Acked-by tag in the
>> cover letter for this situation. Conor is handling this series so I do
>> need to participate on the mailing list when there's a question or
>> comment about picking up the lack of Acked-by.
> 
> If I were you, I would pretty much always mention the reason for
> dropping tags unless the changelog or cover letter contains some pretty
> drastic changes between versions thereby making it really obvious why
> the tags are gone.

Sounds good to me and I will comply. I did infer this from the initial
form-letter reply by Krzysztof that something had run afoul of norms. No
problem for me to explain my understanding so it can be worked out what
needs to happen, and so thank you for the clarification. This was not
the time-saving noise reduction I intended for.

-E