From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16326345725 for ; Wed, 26 Nov 2025 17:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764178649; cv=none; b=UR2qm/rEeRDXqA+2/4XEp9Q3xNa2+xfhHM5Hrj5D+bPHJcGTssFPv1s1ECVVQ1KF+yrKfRBh2OZDLBqcSmIHvlTViTKT7pCqmuQga7u3h1dsfQbL8rN6rsXA0VgNg4pd7bWhaK1mG6SFPeEi/WA9nmuDcm2g9ukG0UHz7nm4CE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764178649; c=relaxed/simple; bh=16cv+oIMfDSmA9KzKt9qElmU+VZvwjpGmR15y/UN72E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OelEgd3fkvrB4V0YAnV4Ad99jjbNk1EgLAILJWDkQctfL1C2h/C5ChlV4QOBIlX5ah1Akd4L/smQfdkqCqjhZd1a06UR9DpoDUqKzxAER/6F0RpGyRK+nrpa08BYQRceM+acUlV50MgSf//A1l2TYhdqsi/9UgsM9xx5X317L30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=TeAwJ1Hx; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TeAwJ1Hx" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C751B1A1D87; Wed, 26 Nov 2025 17:37:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9D82E60721; Wed, 26 Nov 2025 17:37:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C455F102F221D; Wed, 26 Nov 2025 18:37:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764178645; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Eb8/wqazKXP5H4F/DQ5p0D/qqycn+NvVW/OuWZrZprw=; b=TeAwJ1HxZc1mlssgQ9/We7YLdeJ3A4/s760l/iLtyM8eX9nW8EcUzneAdJRucCTFpxhPO3 Bk+DHOc6iw0TrLReKOo9oZmtauzyPwMs8bzWAVZ7GOPxgd3S3NsRiUoN4PFlutsYWiv65N 9RK8xXjQwvu+pbg/hd0redxOl8yCGe4RHMQK3p4m4PRey4Jy4UoKFcGMjsvsFIDLm6gIzI xEt4Pyb1aq3RE0dtz4B09+QhKz75ylJScnWY0Kdyg+iSdLMj0IWVtID6d2W9GGWMsCJQyM +c8I/xkEXIpwkJqtvoLkVPPpChZ0KH6c0FSFsWl0doY128sriLrBCi5zh0eGIA== From: "Kory Maincent (TI.com)" Date: Wed, 26 Nov 2025 18:35:56 +0100 Subject: [PATCH 14/21] drm/tilcdc: Remove the useless module list support Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251126-feature_tilcdc-v1-14-49b9ef2e3aa0@bootlin.com> References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> In-Reply-To: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 The tilcdc driver previously supported a sub-module system where external display drivers (panels, encoders) could register themselves through tilcdc_module_init() and be automatically initialized through a module list. This infrastructure became unused after the component framework support and panel driver was removed. Signed-off-by: Kory Maincent (TI.com) --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 48 +------------------------------------ drivers/gpu/drm/tilcdc/tilcdc_drv.h | 27 --------------------- 2 files changed, 1 insertion(+), 74 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 254cc22ad7711..9b31eaafd2be9 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -7,7 +7,6 @@ /* LCDC DRM driver, based on da8xx-fb */ #include -#include #include #include #include @@ -29,8 +28,6 @@ #include "tilcdc_encoder.h" #include "tilcdc_regs.h" -static LIST_HEAD(module_list); - static const u32 tilcdc_rev1_formats[] = { DRM_FORMAT_RGB565 }; static const u32 tilcdc_straight_formats[] = { DRM_FORMAT_RGB565, @@ -45,20 +42,6 @@ static const u32 tilcdc_legacy_formats[] = { DRM_FORMAT_RGB565, DRM_FORMAT_RGB888, DRM_FORMAT_XRGB8888 }; -void tilcdc_module_init(struct tilcdc_module *mod, const char *name, - const struct tilcdc_module_ops *funcs) -{ - mod->name = name; - mod->funcs = funcs; - INIT_LIST_HEAD(&mod->list); - list_add(&mod->list, &module_list); -} - -void tilcdc_module_cleanup(struct tilcdc_module *mod) -{ - list_del(&mod->list); -} - static int tilcdc_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) { @@ -92,12 +75,6 @@ static const struct drm_mode_config_funcs mode_config_funcs = { static void modeset_init(struct drm_device *dev) { struct tilcdc_drm_private *priv = dev->dev_private; - struct tilcdc_module *mod; - - list_for_each_entry(mod, &module_list, list) { - DBG("loading module: %s", mod->name); - mod->funcs->modeset_init(mod, dev); - } dev->mode_config.min_width = 0; dev->mode_config.min_height = 0; @@ -454,15 +431,9 @@ static struct drm_info_list tilcdc_debugfs_list[] = { static void tilcdc_debugfs_init(struct drm_minor *minor) { - struct tilcdc_module *mod; - drm_debugfs_create_files(tilcdc_debugfs_list, ARRAY_SIZE(tilcdc_debugfs_list), minor->debugfs_root, minor); - - list_for_each_entry(mod, &module_list, list) - if (mod->funcs->debugfs_init) - mod->funcs->debugfs_init(mod, minor); } #endif @@ -549,24 +520,7 @@ static struct platform_driver tilcdc_platform_driver = { .of_match_table = tilcdc_of_match, }, }; - -static int __init tilcdc_drm_init(void) -{ - if (drm_firmware_drivers_only()) - return -ENODEV; - - DBG("init"); - return platform_driver_register(&tilcdc_platform_driver); -} - -static void __exit tilcdc_drm_fini(void) -{ - DBG("fini"); - platform_driver_unregister(&tilcdc_platform_driver); -} - -module_init(tilcdc_drm_init); -module_exit(tilcdc_drm_fini); +module_platform_driver(tilcdc_platform_driver); MODULE_AUTHOR("Rob Clark