From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FF1C347FD3 for ; Wed, 26 Nov 2025 17:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764178672; cv=none; b=DZHI8sWhxUAonWYjNTQaY0IZUxgo8XXTIubHWfCWgX0vsKuj/A1Wy180JKiT1KaVmvdLQvZS6w4mPU40NEZ2yA2LYeRn5GY2I9N62Z2ow/s19WxCwS+54Yw2AU3h3k5kbIJQfOUwoP8vIZpZ8sbIkC/qFA6YHXQsfauKd+sDPEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764178672; c=relaxed/simple; bh=R2u5HUQ57nwiF+bLl16G1CpXw06qaLNsl4SWm4V10gk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qN1wiqOqRoi/0gGdQI08o0I+fFtjFAR/nST04jjsc4/L92bs0sWa+3AzKrX5nhW1XWPOm2e8WspVo218+KLd/vs6sXLeUkc6uqH/5L2SDmpfNyzCEP5TrcNskgmIir5R1djbylK6Z6zx1a+9Y3R7d2kShtqMzH9KJaC6jldNHyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=xvaDogc5; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="xvaDogc5" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id B954F4E418DB; Wed, 26 Nov 2025 17:37:47 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8EB8260721; Wed, 26 Nov 2025 17:37:47 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id CD295102F221D; Wed, 26 Nov 2025 18:37:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764178666; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=PkLVw483Bi2TFNGwF1BcdMAGMT/TwUDIUm6G6/HIAiA=; b=xvaDogc5mDEAnEDR9035aVBrqE9E6VYvl5K/BNb3QgOv7fSsfDEFSjb9NuIolWZE0R9bsa yJkspkRHROmfbK3IS5+XTWsA+qsiULfCBRzYjXaUEEdnaeq6Bai8WJosM//E1GvRavsn6B qrcgi44o1O3bJnCQNcTwVG15/VEHidp6oE5KEPSnTnUL15Nt4Bi2WgOaT0934ll+1mU6RD wAxtfVea3jGMTnQHhpNzvLkxFHEwDimlTNAd24EDLyLfW59XNlduQQuEeugYp6jnSZBis/ 6CXWE6mGTpLjFDER+eDeTRLVJmBpoG/4DA0xjeRdzSE8cNot+DEFrJrGp4ZnyQ== From: "Kory Maincent (TI.com)" Date: Wed, 26 Nov 2025 18:36:03 +0100 Subject: [PATCH 21/21] drm/tilcdc: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251126-feature_tilcdc-v1-21-49b9ef2e3aa0@bootlin.com> References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> In-Reply-To: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Convert the driver to use the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridges. This modernizes the driver by delegating connector creation to the bridge subsystem through drm_bridge_connector_init() instead of manually searching for connectors created by the bridge. The custom tilcdc_encoder_find_connector() function is removed and replaced with the standard drm_bridge_connector infrastructure, which simplifies the code and aligns with current DRM bridge best practices. This change is safe as there are now no in-tree devicetrees that connect tilcdc to bridges which do not support the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. Signed-off-by: Kory Maincent (TI.com) --- drivers/gpu/drm/tilcdc/tilcdc_encoder.c | 38 ++++++++++++++------------------- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_encoder.c b/drivers/gpu/drm/tilcdc/tilcdc_encoder.c index d01e7a31a286c..11fde3a2be353 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_encoder.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_encoder.c @@ -8,46 +8,40 @@ #include #include +#include #include #include #include "tilcdc_drv.h" #include "tilcdc_encoder.h" -static -struct drm_connector *tilcdc_encoder_find_connector(struct drm_device *ddev, - struct drm_encoder *encoder) -{ - struct drm_connector *connector; - - list_for_each_entry(connector, &ddev->mode_config.connector_list, head) { - if (drm_connector_has_possible_encoder(connector, encoder)) - return connector; - } - - dev_err(ddev->dev, "No connector found for %s encoder (id %d)\n", - encoder->name, encoder->base.id); - - return NULL; -} - static int tilcdc_attach_bridge(struct drm_device *ddev, struct drm_bridge *bridge) { struct tilcdc_drm_private *priv = ddev_to_tilcdc_priv(ddev); + struct drm_connector *connector; int ret; priv->encoder->possible_crtcs = BIT(0); - ret = drm_bridge_attach(priv->encoder, bridge, NULL, 0); + ret = drm_bridge_attach(priv->encoder, bridge, NULL, + DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (ret) return ret; - priv->connector = - tilcdc_encoder_find_connector(ddev, priv->encoder); - if (!priv->connector) - return -ENODEV; + connector = drm_bridge_connector_init(ddev, priv->encoder); + if (IS_ERR(connector)) { + dev_err(ddev->dev, "bridge_connector create failed\n"); + return PTR_ERR(connector); + } + + ret = drm_connector_attach_encoder(connector, priv->encoder); + if (ret) { + dev_err(ddev->dev, "attaching encoder to connector failed\n"); + return ret; + } + priv->connector = connector; return 0; } -- 2.43.0