Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Romli, Khairul Anuar" <khairul.anuar.romli@altera.com>
Cc: Rob Herring <robh@kernel.org>, Dinh Nguyen <dinguyen@kernel.org>,
	 Vinod Koul <vkoul@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	 "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add compatible string for Agilex5
Date: Wed, 26 Nov 2025 10:41:01 +0100	[thread overview]
Message-ID: <20251126-frisky-puma-from-valhalla-e3ee05@kuoka> (raw)
In-Reply-To: <e049a03a-49e3-4b00-a3e8-7560f63fa61a@altera.com>

On Wed, Nov 26, 2025 at 07:43:42AM +0000, Romli, Khairul Anuar wrote:
> On 21/11/2025 1:36 am, Rob Herring wrote:
> > On Thu, Nov 20, 2025 at 07:31:10PM +0800, Khairul Anuar Romli wrote:
> >> The address bus on Agilex5 is limited to 40 bits. When SMMU is enable this
> >> will cause address truncation and translation faults. Hence introducing
> >> "altr,agilex5-axi-dma" to enable platform specific configuration to
> >> configure the dma addressable bit mask.
> > 
> > That's likely a bus limitation, not an IP limitation. So that should be
> > handled with dma-ranges.
> > 
> > However, adding a specific compatible is perfectly fine.
> > 
> Would it be okay if I rephrase and send the next version with a 
> correction in the commit message body as your comment in this version?

Yes and your DTS patch might need changes - include proper dma-ranges.

I also do not see how separate compatible without any driver change
solved your case. That's a no-op patch from Linux driver point of view.

See also submitting patches in DT dir about the process how patches are
grouped together.

Best regards,
Krzysztof


  reply	other threads:[~2025-11-26  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 11:31 [PATCH 0/2] Add Agilex5 AXI DMA support Khairul Anuar Romli
2025-11-20 11:31 ` [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add compatible string for Agilex5 Khairul Anuar Romli
2025-11-20 17:36   ` Rob Herring
2025-11-26  7:43     ` Romli, Khairul Anuar
2025-11-26  9:41       ` Krzysztof Kozlowski [this message]
2025-11-20 11:31 ` [PATCH 2/2] arm64: dts: agilex5: Use platform-specific compatible for AXI DMA Khairul Anuar Romli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126-frisky-puma-from-valhalla-e3ee05@kuoka \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=khairul.anuar.romli@altera.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox