[PATCH 0/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[PATCH 0/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[Robert Eckelmann via B4 Relay]

Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.

Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
---
Robert Eckelmann (2):
      arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
      arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

 .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 30 +++++++++++++++++-----
 1 file changed, 23 insertions(+), 7 deletions(-)
---
base-commit: d724c6f85e80a23ed46b7ebc6e38b527c09d64f5
change-id: 20251126-slpi-c616e3a391ce

Best regards,
-- 
Robert Eckelmann <longnoserob@gmail.com>

[PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[Robert Eckelmann via B4 Relay]

From: Robert Eckelmann <longnoserob@gmail.com>

Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.

Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 785006a15e97..0fb1d7e724c4 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -425,6 +425,12 @@ &sdhc_2 {
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
 };
 
+&slpi_pas {
+	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
+
+	status = "okay";
+};
+
 &sound {
 	compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard";
 	pinctrl-0 = <&quat_mi2s_active
@@ -637,3 +643,4 @@ &wifi {
 	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
 	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 };
+

-- 
2.52.0

[PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

[Robert Eckelmann via B4 Relay]

From: Robert Eckelmann <longnoserob@gmail.com>

We know these devices are present, most of them are supported by
downstream and close to the mainline kernels.

This is very handy when rebasing the integration tree with the support.

No functional changes.

Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
---
 .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 0fb1d7e724c4..0b219d0ff451 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 {
 	};
 };
 
+&cci_i2c0 {
+	/* IMX363 @ 10 */
+};
+
 &cdsp_pas {
 	status = "okay";
 	firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
@@ -261,6 +265,18 @@ &ibb {
 	qcom,discharge-resistor-kohms = <300>;
 };
 
+&ipa {
+	qcom,gsi-loader = "self";
+	memory-region = <&ipa_fw_mem>;
+	firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
+
+	status = "okay";
+};
+
+&i2c5 {
+	/* TAS2559 @ 4C */
+};
+
 &lab {
 	regulator-min-microvolt = <4600000>;
 	regulator-max-microvolt = <6000000>;
@@ -311,13 +327,6 @@ &mss_pil {
 	firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
 };
 
-&ipa {
-	qcom,gsi-loader = "self";
-	memory-region = <&ipa_fw_mem>;
-	firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
-	status = "okay";
-};
-
 &pm8998_gpios {
 	vol_up_pin_a: vol-up-active-state {
 		pins = "gpio6";

-- 
2.52.0

Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

[David Heidelberg]

On 26/11/2025 13:08, Robert Eckelmann via B4 Relay wrote:
> From: Robert Eckelmann <longnoserob@gmail.com>
> 
> We know these devices are present, most of them are supported by
> downstream and close to the mainline kernels.
> 
> This is very handy when rebasing the integration tree with the support.
> 
> No functional changes.
> 
> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> ---
>   .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
>   1 file changed, 16 insertions(+), 7 deletions(-)
> 

Reviewed-by: David Heidelberg <david@ixit.cz>

Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[Dmitry Baryshkov]

On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
> From: Robert Eckelmann <longnoserob@gmail.com>
> 
> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
> 
> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index 785006a15e97..0fb1d7e724c4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -425,6 +425,12 @@ &sdhc_2 {
>  	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>  };
>  
> +&slpi_pas {
> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";

qcom/sdm845/Xiaomi/beryllium/slpi.mbn

> +
> +	status = "okay";
> +};
> +
>  &sound {
>  	compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard";
>  	pinctrl-0 = <&quat_mi2s_active
> @@ -637,3 +643,4 @@ &wifi {
>  	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>  	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>  };
> +
> 
> -- 
> 2.52.0
> 
> 

-- 
With best wishes
Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[David Heidelberg]

On 26/11/2025 15:41, Dmitry Baryshkov wrote:
> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
>> From: Robert Eckelmann <longnoserob@gmail.com>
>>
>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
>>
>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>> index 785006a15e97..0fb1d7e724c4 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>> @@ -425,6 +425,12 @@ &sdhc_2 {
>>   	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>>   };
>>   
>> +&slpi_pas {
>> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
> 
> qcom/sdm845/Xiaomi/beryllium/slpi.mbn

Could be this change done for all the firmware files at once but later?

Currently all the firmwares using this legacy path.

David

[...]

Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

[Konrad Dybcio]

On 11/26/25 1:08 PM, Robert Eckelmann via B4 Relay wrote:
> From: Robert Eckelmann <longnoserob@gmail.com>
> 
> We know these devices are present, most of them are supported by
> downstream and close to the mainline kernels.
> 
> This is very handy when rebasing the integration tree with the support.
> 
> No functional changes.
> 
> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> ---
>  .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index 0fb1d7e724c4..0b219d0ff451 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 {
>  	};
>  };
>  
> +&cci_i2c0 {
> +	/* IMX363 @ 10 */

It may be useful for you to add 'status = "okay"' here, so that the busses
are accessible, and you can poke at the device with e.g. i2c-tools

Konrad

Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[Dmitry Baryshkov]

On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
> > On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
> > > From: Robert Eckelmann <longnoserob@gmail.com>
> > > 
> > > Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
> > > 
> > > Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
> > >   1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > > index 785006a15e97..0fb1d7e724c4 100644
> > > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > > @@ -425,6 +425,12 @@ &sdhc_2 {
> > >   	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
> > >   };
> > > +&slpi_pas {
> > > +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
> > 
> > qcom/sdm845/Xiaomi/beryllium/slpi.mbn
> 
> Could be this change done for all the firmware files at once but later?
> 
> Currently all the firmwares using this legacy path.

I'd rather see the patch fixing firmware paths first and then the patch
adding SLPI with the correct path from the day 0 (I feel sorry for
causing pain to PmOS maintainers). Of course both patches can come as a
part of the same series.

> 
> David
> 
> [...]

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

[Dmitry Baryshkov]

On Thu, Nov 27, 2025 at 11:33:40AM +0100, Konrad Dybcio wrote:
> On 11/26/25 1:08 PM, Robert Eckelmann via B4 Relay wrote:
> > From: Robert Eckelmann <longnoserob@gmail.com>
> > 
> > We know these devices are present, most of them are supported by
> > downstream and close to the mainline kernels.
> > 
> > This is very handy when rebasing the integration tree with the support.
> > 
> > No functional changes.
> > 
> > Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> > ---
> >  .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
> >  1 file changed, 16 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > index 0fb1d7e724c4..0b219d0ff451 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > @@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 {
> >  	};
> >  };
> >  
> > +&cci_i2c0 {
> > +	/* IMX363 @ 10 */
> 
> It may be useful for you to add 'status = "okay"' here, so that the busses
> are accessible, and you can poke at the device with e.g. i2c-tools

And a bus frequency then.

> 
> Konrad

-- 
With best wishes
Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[David Heidelberg]

On 29/11/2025 02:15, Dmitry Baryshkov wrote:
> On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
>> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
>>> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
>>>> From: Robert Eckelmann <longnoserob@gmail.com>
>>>>
>>>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
>>>>
>>>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
>>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>>>>    1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> index 785006a15e97..0fb1d7e724c4 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> @@ -425,6 +425,12 @@ &sdhc_2 {
>>>>    	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>>>>    };
>>>> +&slpi_pas {
>>>> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
>>>
>>> qcom/sdm845/Xiaomi/beryllium/slpi.mbn
>>
>> Could be this change done for all the firmware files at once but later?
>>
>> Currently all the firmwares using this legacy path.
> 
> I'd rather see the patch fixing firmware paths first and then the patch
> adding SLPI with the correct path from the day 0 (I feel sorry for
> causing pain to PmOS maintainers). Of course both patches can come as a
> part of the same series.

Would it make sense as a follow up, I would changed "the whole sdm845" 
to the new paths, so distros maintainers can update paths everywhere 
with 6.19?

David

> 
>>
>> David
>>
>> [...]
> 

-- 
David Heidelberg

Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

[Dmitry Baryshkov]

On Sat, 29 Nov 2025 at 14:08, David Heidelberg <david@ixit.cz> wrote:
>
> On 29/11/2025 02:15, Dmitry Baryshkov wrote:
> > On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
> >> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
> >>> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
> >>>> From: Robert Eckelmann <longnoserob@gmail.com>
> >>>>
> >>>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
> >>>>
> >>>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> >>>> Signed-off-by: David Heidelberg <david@ixit.cz>
> >>>> ---
> >>>>    arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
> >>>>    1 file changed, 7 insertions(+)
> >>>>
> >>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> >>>> index 785006a15e97..0fb1d7e724c4 100644
> >>>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> >>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> >>>> @@ -425,6 +425,12 @@ &sdhc_2 {
> >>>>            cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
> >>>>    };
> >>>> +&slpi_pas {
> >>>> +  firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
> >>>
> >>> qcom/sdm845/Xiaomi/beryllium/slpi.mbn
> >>
> >> Could be this change done for all the firmware files at once but later?
> >>
> >> Currently all the firmwares using this legacy path.
> >
> > I'd rather see the patch fixing firmware paths first and then the patch
> > adding SLPI with the correct path from the day 0 (I feel sorry for
> > causing pain to PmOS maintainers). Of course both patches can come as a
> > part of the same series.
>
> Would it make sense as a follow up, I would changed "the whole sdm845"
> to the new paths, so distros maintainers can update paths everywhere
> with 6.19?

I think so.

>
> David
>
> >
> >>
> >> David
> >>
> >> [...]
> >
>
> --
> David Heidelberg
>


-- 
With best wishes
Dmitry