[PATCH v2 0/2] Add ICU support for Renesas RZ/V2N SoC

[PATCH v2 0/2] Add ICU support for Renesas RZ/V2N SoC

[Prabhakar]

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi All,

This patch series aims to add support for the Interrupt Control Unit (ICU)
found in the Renesas RZ/V2N System on Chip (SoC). The RZ/V2N ICU shares
similarities with the RZ/V2H(P) family but has a different register layout,
notably with a reduced set of ECCRAM related registers.
The first patch documents the RZ/V2N ICU in the device tree bindings,
while the second patch introduces support in the irqchip driver by adding
a new compatible string.

v1->v2:
- Dropped using RZ/V2H compatible as a fallback.
- Patch 2/2 is new

Cheers,
Prabhakar

Lad Prabhakar (2):
  dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N
    SoC
  irqchip: renesas: rzv2h-icu: Add support for RZ/V2N SoC

 .../bindings/interrupt-controller/renesas,rzv2h-icu.yaml         | 1 +
 drivers/irqchip/irq-renesas-rzv2h.c                              | 1 +
 2 files changed, 2 insertions(+)

-- 
2.52.0

[PATCH v2 1/2] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC

[Prabhakar]

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Document the Interrupt Control Unit (ICU) used on the Renesas RZ/V2N SoC.
Although the ICU closely matches the design found on the RZ/V2H(P) family,
it differs in its register layout, particularly in the reduced set of
ECCRAM related registers. These variations require a distinct compatible
string so that software can correctly match and handle the RZ/V2N
implementation.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2:
- Dropped using RZ/V2H compatible as a fallback.
---
 .../bindings/interrupt-controller/renesas,rzv2h-icu.yaml         | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
index 3f99c8645767..cb244b8f5e1c 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
@@ -22,6 +22,7 @@ properties:
   compatible:
     enum:
       - renesas,r9a09g047-icu # RZ/G3E
+      - renesas,r9a09g056-icu # RZ/V2N
       - renesas,r9a09g057-icu # RZ/V2H(P)
 
   '#interrupt-cells':
-- 
2.52.0

[PATCH v2 2/2] irqchip: renesas: rzv2h-icu: Add support for RZ/V2N SoC

[Prabhakar]

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Add support for the RZ/V2N Interrupt Control Unit (ICU) by introducing a
dedicated compatible string in the irqchip driver. While the RZ/V2N ICU
differs from the RZ/V2H(P) version in its register layout primarily due
to a reduced set of ECCRAM related registers the irqchip driver does not
currently access these registers.

As a result, the RZ/V2N ICU can be safely handled by rzv2h_icu_probe for
now, but it still requires a distinct compatible so that future changes
can differentiate the SoCs when needed.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2:
- New patch
---
 drivers/irqchip/irq-renesas-rzv2h.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 899a423b5da8..0c44b6109842 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -616,6 +616,7 @@ static int rzv2h_icu_probe(struct platform_device *pdev, struct device_node *par
 
 IRQCHIP_PLATFORM_DRIVER_BEGIN(rzv2h_icu)
 IRQCHIP_MATCH("renesas,r9a09g047-icu", rzg3e_icu_probe)
+IRQCHIP_MATCH("renesas,r9a09g056-icu", rzv2h_icu_probe)
 IRQCHIP_MATCH("renesas,r9a09g057-icu", rzv2h_icu_probe)
 IRQCHIP_PLATFORM_DRIVER_END(rzv2h_icu)
 MODULE_AUTHOR("Fabrizio Castro <fabrizio.castro.jz@renesas.com>");
-- 
2.52.0

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC

[Geert Uytterhoeven]

On Thu, 27 Nov 2025 at 17:24, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Document the Interrupt Control Unit (ICU) used on the Renesas RZ/V2N SoC.
> Although the ICU closely matches the design found on the RZ/V2H(P) family,
> it differs in its register layout, particularly in the reduced set of
> ECCRAM related registers. These variations require a distinct compatible
> string so that software can correctly match and handle the RZ/V2N
> implementation.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2:
> - Dropped using RZ/V2H compatible as a fallback.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 2/2] irqchip: renesas: rzv2h-icu: Add support for RZ/V2N SoC

[Geert Uytterhoeven]

On Thu, 27 Nov 2025 at 17:24, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for the RZ/V2N Interrupt Control Unit (ICU) by introducing a
> dedicated compatible string in the irqchip driver. While the RZ/V2N ICU
> differs from the RZ/V2H(P) version in its register layout primarily due
> to a reduced set of ECCRAM related registers the irqchip driver does not
> currently access these registers.
>
> As a result, the RZ/V2N ICU can be safely handled by rzv2h_icu_probe for
> now, but it still requires a distinct compatible so that future changes
> can differentiate the SoCs when needed.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC

[Rob Herring (Arm)]

On Thu, 27 Nov 2025 16:24:46 +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Document the Interrupt Control Unit (ICU) used on the Renesas RZ/V2N SoC.
> Although the ICU closely matches the design found on the RZ/V2H(P) family,
> it differs in its register layout, particularly in the reduced set of
> ECCRAM related registers. These variations require a distinct compatible
> string so that software can correctly match and handle the RZ/V2N
> implementation.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2:
> - Dropped using RZ/V2H compatible as a fallback.
> ---
>  .../bindings/interrupt-controller/renesas,rzv2h-icu.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required property
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251127162447.320971-2-prabhakar.mahadev-lad.rj@bp.renesas.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC

[Thomas Gleixner]

On Thu, Nov 27 2025 at 11:16, Rob Herring wrote:
> On Thu, 27 Nov 2025 16:24:46 +0000, Prabhakar wrote:
>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> 
>> Document the Interrupt Control Unit (ICU) used on the Renesas RZ/V2N SoC.
>> Although the ICU closely matches the design found on the RZ/V2H(P) family,
>> it differs in its register layout, particularly in the reduced set of
>> ECCRAM related registers. These variations require a distinct compatible
>> string so that software can correctly match and handle the RZ/V2N
>> implementation.
>> 
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>> v1->v2:
>> - Dropped using RZ/V2H compatible as a fallback.
>> ---
>>  .../bindings/interrupt-controller/renesas,rzv2h-icu.yaml         | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
> 	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
> 	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
> 	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required property
> 	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']

Confused. How is the change in

          bindings/interrupt-controller/renesas,rzv2h-icu.yaml

related to the errors your bot found>

Thanks,

        tglx

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC

[Lad, Prabhakar]

Hi Thomas,

On Fri, Dec 12, 2025 at 1:27 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Thu, Nov 27 2025 at 11:16, Rob Herring wrote:
> > On Thu, 27 Nov 2025 16:24:46 +0000, Prabhakar wrote:
> >> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>
> >> Document the Interrupt Control Unit (ICU) used on the Renesas RZ/V2N SoC.
> >> Although the ICU closely matches the design found on the RZ/V2H(P) family,
> >> it differs in its register layout, particularly in the reduced set of
> >> ECCRAM related registers. These variations require a distinct compatible
> >> string so that software can correctly match and handle the RZ/V2N
> >> implementation.
> >>
> >> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >> ---
> >> v1->v2:
> >> - Dropped using RZ/V2H compatible as a fallback.
> >> ---
> >>  .../bindings/interrupt-controller/renesas,rzv2h-icu.yaml         | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
> >       from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
> >       from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
> >       from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@28080000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required property
> >       from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
>
> Confused. How is the change in
>
>           bindings/interrupt-controller/renesas,rzv2h-icu.yaml
>
> related to the errors your bot found>
>
My understanding is that the bot printed out all the errors there were
present in the tree while running the validation.

Cheers,
Prabhakar