From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E351B31771B; Thu, 27 Nov 2025 09:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764236278; cv=none; b=Fg8xBVmOypKaRgnD0dQZ6pyNVA1sHPzCiU+45HzMeT21KDNqpQpBKmIqJT598lrTeDxuE5wZVNAA7v1iln1a+fe27Z5M6y8pGg+ERMxbIF6ebRx1FCrOHeAht+B+JrTiqaxUNzZeh9SaIHUGPeccJ7xX+Gbu8KxmPhz/lrEpKIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764236278; c=relaxed/simple; bh=0umA7AV3QLPprkzNQBE18YPabiRf/OoQS7dKfXP9CJU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n30gpiaOxq6M5wtufnAfMF0AbQMywee9jY3ta72LAiXQwWrGDlCYzvhejXsIQ1ZNjrIzVGguejVUd2ewTFCdWzL91vVAfzCpGNmFlezCvaR9wDZPUAp/X9rOF3bjmiLG77dX68yIRyc31O3UcSB2NCFH6KonfeIICyW5ZiOypOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=As4k8cuN; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="As4k8cuN" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 28AF11A1DA3; Thu, 27 Nov 2025 09:37:55 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EDAD46068C; Thu, 27 Nov 2025 09:37:54 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4E220102F260E; Thu, 27 Nov 2025 10:37:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764236273; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=L9S1rZGl/rz9YmM+17xHKDLknXmtbmaZyBYHTmnGq6Y=; b=As4k8cuN5pEobUrrB5p5aNhgjO75O4U+DBpJNotM5YUCxyK0GtFJZ4JzIIWdJEmCQ1PyX/ Zp2y39HKpUoIchvF1tSu70/0a7GUdW8jtFoCOJNREtHW0x67OZXfM+cmUnVhUDoW+rzwlC qA3sX7z9yr4imuwTY/i/4M5dA+fAYPVgaYzJzurRGjpRcFIVx4qAz+9eFYTyryyHqHe8WU 3vfBu/b8T96rzP4XrywexXFog2TH/83l4GEfzOouJQwTwk+0dhnDraNMm76UttUoAVNmUH dGQhhUfrG12gVjO74EWiTalQrmTEZa0iPtjz0M+O1hZCvSLkDvAseQCzeLQenw== Date: Thu, 27 Nov 2025 10:37:45 +0100 From: Kory Maincent To: Krzysztof Kozlowski Cc: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Markus Schneider-Pargmann , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 02/21] dt-bindings: display: tilcdc: Add fifo-threshold property Message-ID: <20251127103745.7c5d55e6@kmaincent-XPS-13-7390> In-Reply-To: <20251127-subtle-prophetic-corgi-68aab1@kuoka> References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> <20251126-feature_tilcdc-v1-2-49b9ef2e3aa0@bootlin.com> <20251127-subtle-prophetic-corgi-68aab1@kuoka> Organization: bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On Thu, 27 Nov 2025 09:22:56 +0100 Krzysztof Kozlowski wrote: > On Wed, Nov 26, 2025 at 06:35:44PM +0100, Kory Maincent (TI.com) wrote: > > Add the fifo-threshold property to control the DMA FIFO threshold level, > > which specifies the number of words that must be loaded before the DMA > > FIFO becomes ready. > >=20 > > This property is needed to support the da850-evm board configuration > > which requires a non-default FIFO threshold value. Currently, this value > > is specified through the deprecated ti,tilcdc,panel binding. Adding this > > property to the tilcdc binding allows for proper configuration while > > migrating away from the non-standard panel binding. > >=20 > > The default value is 8 words, with valid values being powers of 2 from > > 8 to 512. > >=20 > > Related commit: 55da73fa7a68c ("ARM: dts: davinci: da850-evm: Increase > > fifo threshold") =20 >=20 > Please use syntax pointed out by checkpatch. The checkpatch error (not > even a warning) is there for reason, so we can apply filter/grep > easily. >=20 > >=20 > > Signed-off-by: Kory Maincent (TI.com) > > --- > > Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml | 7 +++++= ++ > > 1 file changed, 7 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.ya= ml > > b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml index > > 34ac1fd04d5c6..bf6d506e25e17 100644 --- > > a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml +++ > > b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml @@ -46,6 > > +46,13 @@ properties: The maximum pixel clock that can be supported by = the > > lcd controller in KHz. > > =20 > > + fifo-threshold: =20 >=20 > Why this is not deducible from the compatible? Feels like a specific SoC > issue. This is indeed deductible from the compatible as ti,da850-tilcdc is only us= e in the related devicetree. Thanks for the pointer this will avoid adding a new= dt parameter. >=20 > Anyway, missing vendor prefix >=20 > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [8, 16, 32, 64, 128, 256, 512] > > + description: > > + Number of words loaded before the DMA fifo becomes ready. The de= fault > > + value is 8. =20 >=20 > missing default and drop free form text in description. >=20 > > + > > blue-and-red-wiring: > > enum: [straight, crossed] > > description: > >=20 > > --=20 > > 2.43.0 > > =20 --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com