From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 594D727E06C for ; Thu, 27 Nov 2025 13:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764250906; cv=none; b=cBNKec1b1AESyaudTsoOQWTvtpygNx4UE6KMz4XRkJg+yfTWGHi8rTkRm3+Xpg9PQOQ9MOmonNPNOz1NeMoDzl9X5kOyJREoUrUbbJgtQEjiC5RCLyANd6APob5Om/2V0zbHdv3Y2NaZs3BXlwlrS9G1MmYb6frvZwKzabOVYaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764250906; c=relaxed/simple; bh=4OUGcMg0ju5t9Xc1HUnE0WRH6R4OUaTZgUyIgpSsfbE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X57i2jknNzQYHMhwrLbWq+8NyVxTld4A/YHiWSKbmpqMyNpZtPdcxuJd8oIJACzZktFlz4Tf0E7Rfai+l/8el7GyiOrtmWVErY6qpPbZ2TDdCCg1dIt0HR5KcRmePMIS95FT+e0KCXn1NBAWshixgaxcZhB9EI+JEGcX+taOtEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ot3q+H8U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e7SSOuEG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ot3q+H8U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e7SSOuEG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AR9UGMg685306 for ; Thu, 27 Nov 2025 13:41:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=EGGCcpomE3a 1W9/bo5UCLEEy3BvQEZ0IAe49EcAnH38=; b=ot3q+H8U5jpjAxPlhuDvfVjGGoP m9r8c3uK5ncb+/F1NwQl9XzafMGTh/LdLtpOtVMO+E/BQ/M1xmrv8p40ebnI9Sij syDNR9mNCvSxu0Dy/aEZ6f/fqO2t6DNn/sX9+gfaeaPNxCOzlFX0xaxOrYVdzedQ +0DTezJVL5miZGWXyLj+LSLOddL42soArBkQoXlzfJodHKqzA8C93Rr5/SYioghs l4aEOplsVY3tQShdDDW5EIdAqcnFGle9/HdMsRr+Vrei+LAUz2f29JpWPE6II8Hc wfoYonjVuzDj2KXEzWWJJ8QRg3B21AtRchGnwA9JULIyCSLj0eSKsevwIDg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apm2rrmh6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 13:41:43 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297dabf9fd0so12773545ad.0 for ; Thu, 27 Nov 2025 05:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764250902; x=1764855702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EGGCcpomE3a1W9/bo5UCLEEy3BvQEZ0IAe49EcAnH38=; b=e7SSOuEGMDxHif8mrRn/PBH177q3uUE4YMmn96P9sIkIN3ahrJBHRTxVHjxzmkXXDj bfngkyBlrmp7a4P0dGeJV+bBR4DXHl+iRIx6C9a3X5rSuSiVEBHi/IqzryemStDF9DmG lZvSvZLVyNWMp1AV/CI2eOTWDgcozeYyFP7fhD3G+w7uvlyjxCbEsuRsl6Bcc0wpoiBS qt7kGo7Lbcqq+mmeKSUfJoAfdAP01YOsfIclrCgZf9Jurteu2CtCK8dVfzQOV2CZ8Alu IKhX4K6j4tWj/Uh/kcOgkCPdAiZaMbO6uzeWazKUOXGl2JGUYfFh289oyrbGrZ/30XDn bJFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764250902; x=1764855702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EGGCcpomE3a1W9/bo5UCLEEy3BvQEZ0IAe49EcAnH38=; b=NYrKoxJRo99US1MPAAXUsYBrchIt4P5HPACQwzz/E2e8x6Wlvck3l5VQB/aG0hjDTq bFJvPB6C8MvRmpDObwx1G969kcB2Td1dmCpIPaTcmIW5tpjOzOmKFTa46tWaMu6Q0h2/ PRjAqzpAFnk9dnpcFzxLiuliqQxohiNQMPUXGL7eKMe6y3loPSfGzeZ7paf+WP2t0x6o DJs+eKDBfAqM5FO+PKSy5wEU0IFp68dGUbj8eAn71PohNcy4i36QYOJtj/WY1GbG3QU/ GYsLcnC0KAi+1j7QgUc07Y/U1kACBBGs8JJnIvVnX71Op++uJXuMaLROdt68gDB+uKkb CsWg== X-Forwarded-Encrypted: i=1; AJvYcCXhB2aunnyXZ82TbFiJX3gF6V8SZrqQLhgU7dQWRWgpFwvflTS8UWqarcMgYPGRa6LwzmfjBXWJ4AnK@vger.kernel.org X-Gm-Message-State: AOJu0YzKRTN9DoV6dkNE/UKN/z+nSYofTSxDqc7atzcXDvHIR8hX6R2p vCavgF7xA67lHj1cP6y6o0rFQf0lMYMFLLAOHxXlNcTmDKj9xEhEo0PJ9WxifNZtr1u590EKxRu Xh70ROq+Xqs9zLJP2igKRY92hP2gJTAuxRlzsJIec+Dpu6s9Hi+Qv3QXeSJhoj0Ru X-Gm-Gg: ASbGnctjwmceupW2OmWYMkLpyxIti9lJFyZJAE1nA4isc55YE4FXmVvv0jrPb9/Z/82 JR56mDQlFqCGSRgGJBLyjY6EKHegNHcygXfwD+6Kln/p31fHl2LscWLQbVDQGrZbmLSEA6OdmoZ i3SH6E6t9a4rj3FdDDEsaOhY8x312OxJ/h4dkExGiLbxUoAKVkXwHE7s60iyUX5xNkwUwNOw1wn 1ezdQZSOBshyqtS1Rsdr/p9Q1aTb+nbwT0Rz4o08Ng6n/6VSqj/20ZPerDNt5We6qNZVK2VIg21 z9GJ+AyY7yT9RyyDZid90QBu6AChdPjqCpq3lD3V2bvMwiwCxswp7wLZoixeGzL1M0v69d3qpxD +Qr6GnKX9Mgvv2UlGfK/trxK+7CCHuBnf6uii/Gk8g/XO X-Received: by 2002:a17:903:40ca:b0:299:dd98:fac2 with SMTP id d9443c01a7336-29b6c6b2646mr296809335ad.54.1764250901778; Thu, 27 Nov 2025 05:41:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjPx9TZ4zc6hlf6vL2I4x61Vjj7XoXSXVtdAplFXfVyPCAp+jHXWHQaeRxTNP0rXywgO7/VA== X-Received: by 2002:a17:903:40ca:b0:299:dd98:fac2 with SMTP id d9443c01a7336-29b6c6b2646mr296808805ad.54.1764250901231; Thu, 27 Nov 2025 05:41:41 -0800 (PST) Received: from hu-jprakash-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce441600sm18934875ad.29.2025.11.27.05.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 05:41:40 -0800 (PST) From: Jishnu Prakash To: jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, krzk+dt@kernel.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, lumag@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konradybcio@kernel.org, daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org, subbaraman.narayanamurthy@oss.qualcomm.com, david.collins@oss.qualcomm.com, anjelique.melendez@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com Cc: rui.zhang@intel.com, lukasz.luba@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org, jishnu.prakash@oss.qualcomm.com, quic_kotarake@quicinc.com, neil.armstrong@linaro.org, stephan.gerhold@linaro.org, Jonathan Cameron Subject: [PATCH V8 2/4] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC Date: Thu, 27 Nov 2025 19:10:34 +0530 Message-Id: <20251127134036.209905-3-jishnu.prakash@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251127134036.209905-1-jishnu.prakash@oss.qualcomm.com> References: <20251127134036.209905-1-jishnu.prakash@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDEwMSBTYWx0ZWRfXxtMmipvWEWRt KY2wiPm0L9Z+QL62h6y/OM3zQ5Rs1RxnkuqsVC7ThCDJJ+zcuHsWG73zPd8bucXu6eQdByBXP/r QgxPf5V4zk2u84of4etRpesgSjuBJ9x2tHQ/f+1EjwHkEvPxEkpdBPtQlb4XqUiU2DBmaNfvMQf apQabCyaBaD7vGHQlRkA9I+BdHPFhGYt2hB8aIF8Pm/fT7BO2vocWrxIewrWm+ne0wWqc7RXtcd zAITmnVCdoprgmXIqez1t6CC52BgHwwUioGwdhevWQh6dh1N0b+9qG9SWLzg1Xe+mSpuSHd6bmo RCVOWqlaLfDCj+UryGpzunWDXqFzIYhKo8/CJDorEVKjiwTiCT1NtickmvNSfww5BpKGlIVh6So vQOx72dnFeqFaXSXSWiwQRJHqIlbSQ== X-Proofpoint-ORIG-GUID: -Qxo6NBGJtnxaUGlTC1_Z5H3HouwmjTZ X-Authority-Analysis: v=2.4 cv=W941lBWk c=1 sm=1 tr=0 ts=69285517 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gEfo2CItAAAA:8 a=i0EeH86SAAAA:8 a=YrMGt2jeDSw4g2R_97MA:9 a=1OuFwYUASf3TG4hYMiVC:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-GUID: -Qxo6NBGJtnxaUGlTC1_Z5H3HouwmjTZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270101 For the PMIC5-Gen3 type PMICs, ADC peripheral is present in HW for the following PMICs: PMK8550, PM8550, PM8550B and PM8550VX PMICs. It is similar to PMIC5-Gen2, with SW communication to ADCs on all PMICs going through PBS(Programmable Boot Sequence) firmware through a single register interface. This interface is implemented on SDAM (Shared Direct Access Memory) peripherals on the master PMIC PMK8550 rather than a dedicated ADC peripheral. Add documentation for PMIC5 Gen3 ADC and update SPMI PMIC bindings to allow ADC5 Gen3 as adc@ subnode. Acked-by: Jonathan Cameron Signed-off-by: Jishnu Prakash --- Changes since v7: - Dropped ADC5 GEN3 channel macro definitions from bindings, based on discussion with Krzysztof concluded here: https://lore.kernel.org/all/d10e2eea-4b86-4e1a-b7a0-54c55907a605@oss.qualcomm.com/, to be added separately in other patches. - Fixed quotes to use only double quotes for "#address-cells", "#size-cells" and "#io-channel-cells" properties, to address Krzysztof's comment. - Removed inclusion of ADC channel macro header files from ADC5 Gen3 example and replaced the macros used in the "reg" properties in channel nodes with the actual hex values. - Removed update made under `reg` property in Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc-common.yaml which referenced ADC macro binding files, to align with change made in patch 1 of this series. Changes since v6: - Updated SPMI PMIC bindings to allow ADC5 Gen3 as adc@ subnode, to address Neil's comment. - Replaced 2025 copyright in newly added files with yearless copyright, following new internal guidelines. - Collected Acked-by tag from Jonathan. Changes since v5: - Addressed following comments from Krzysztof: - Increased line wrap length for top-level device description. - Added more details in binding description explaining how number of SDAM peripherals used for ADC is allocated per SoC. - Dropped "interrupt-names" property. - Moved `required` block to after the list of all properties. - Dropped | from patternProperties description. - Renamed per-PMIC binding files listing ADC channel macro names. - Addressed following comments from Jonathan: - Moved ref before description, under patternProperties. - Arranged enum under qcom,hw-settle-time as groups of 8. Changes since v4: - Added ADC5 Gen3 documentation in a separate new file to avoid complicating existing VADC documentation file further to accomodate this device, as suggested by reviewers. Changes since v3: - Added ADC5 Gen3 documentation changes in existing qcom,spmi-vadc.yaml file instead of adding separate file and updated top-level constraints in documentation file based on discussion with reviewers. - Dropped default SID definitions. - Addressed other reviewer comments. Changes since v2: - Moved ADC5 Gen3 documentation into a separate new file. Changes since v1: - Updated properties separately for all compatibles to clarify usage of new properties and updates in usage of old properties for ADC5 Gen3. - Avoided updating 'adc7' name to 'adc5 gen2' and just left a comment mentioning this convention. - Used predefined channel IDs in individual PMIC channel definitions instead of numeric IDs. - Addressed other comments from reviewers. .../bindings/iio/adc/qcom,spmi-adc5-gen3.yaml | 151 ++++++++++++++++++ .../bindings/iio/adc/qcom,spmi-vadc.yaml | 2 + .../bindings/mfd/qcom,spmi-pmic.yaml | 1 + 3 files changed, 154 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml new file mode 100644 index 000000000000..149f4af8f4b8 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml @@ -0,0 +1,151 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/qcom,spmi-adc5-gen3.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm's SPMI PMIC ADC5 Gen3 + +maintainers: + - Jishnu Prakash + +description: | + SPMI PMIC5 Gen3 voltage ADC (ADC) provides interface to clients to read + voltage. It is a 16-bit sigma-delta ADC. It also performs the same thermal + monitoring function as the existing ADC_TM devices. + + The interface is implemented on SDAM (Shared Direct Access Memory) peripherals + on the master PMIC rather than a dedicated ADC peripheral. The number of PMIC + SDAM peripherals allocated for ADC is not correlated with the PMIC used, it is + programmed in FW (PBS) and is fixed per SOC, based on the SOC requirements. + All boards using a particular (SOC + master PMIC) combination will have the + same number of ADC SDAMs supported on that PMIC. + +properties: + compatible: + const: qcom,spmi-adc5-gen3 + + reg: + items: + - description: SDAM0 base address in the SPMI PMIC register map + - description: SDAM1 base address + minItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + "#io-channel-cells": + const: 1 + + "#thermal-sensor-cells": + const: 1 + + interrupts: + items: + - description: SDAM0 end of conversion (EOC) interrupt + - description: SDAM1 EOC interrupt + minItems: 1 + +patternProperties: + "^channel@[0-9a-f]+$": + type: object + unevaluatedProperties: false + $ref: /schemas/iio/adc/qcom,spmi-vadc-common.yaml + description: + Represents the external channels which are connected to the ADC. + + properties: + qcom,decimation: + enum: [ 85, 340, 1360 ] + default: 1360 + + qcom,hw-settle-time: + enum: [ 15, 100, 200, 300, 400, 500, 600, 700, + 1000, 2000, 4000, 8000, 16000, 32000, 64000, 128000 ] + default: 15 + + qcom,avg-samples: + enum: [ 1, 2, 4, 8, 16 ] + default: 1 + + qcom,adc-tm: + description: + ADC_TM is a threshold monitoring feature in HW which can be enabled + on any ADC channel, to trigger an IRQ for threshold violation. In + earlier ADC generations, it was implemented in a separate device + (documented in Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml.) + In Gen3, this feature can be enabled in the same ADC device for any + channel and threshold monitoring and IRQ triggering are handled in FW + (PBS) instead of another dedicated HW block. + This property indicates ADC_TM monitoring is done on this channel. + type: boolean + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - "#io-channel-cells" + - interrupts + +additionalProperties: false + +examples: + - | + #include + + pmic { + #address-cells = <1>; + #size-cells = <0>; + + adc@9000 { + compatible = "qcom,spmi-adc5-gen3"; + reg = <0x9000>, <0x9100>; + interrupts = <0x0 0x90 0x1 IRQ_TYPE_EDGE_RISING>, + <0x0 0x91 0x1 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; + #io-channel-cells = <1>; + #thermal-sensor-cells = <1>; + + /* PMK8550 Channel nodes */ + channel@3 { + reg = <0x3>; + label = "pmk8550_die_temp"; + qcom,pre-scaling = <1 1>; + }; + + channel@44 { + reg = <0x44>; + label = "pmk8550_xo_therm"; + qcom,pre-scaling = <1 1>; + qcom,ratiometric; + qcom,hw-settle-time = <200>; + qcom,adc-tm; + }; + + /* PM8550 Channel nodes */ + channel@103 { + reg = <0x103>; + label = "pm8550_die_temp"; + qcom,pre-scaling = <1 1>; + }; + + /* PM8550B Channel nodes */ + channel@78f { + reg = <0x78f>; + label = "pm8550b_vbat_sns_qbg"; + qcom,pre-scaling = <1 3>; + }; + + /* PM8550VS_C Channel nodes */ + channel@203 { + reg = <0x203>; + label = "pm8550vs_c_die_temp"; + qcom,pre-scaling = <1 1>; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml index 16c80709a3ee..72188041e8b5 100644 --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml @@ -15,6 +15,8 @@ description: | voltage. The VADC is a 15-bit sigma-delta ADC. SPMI PMIC5/PMIC7 voltage ADC (ADC) provides interface to clients to read voltage. The VADC is a 16-bit sigma-delta ADC. + Note that PMIC7 ADC is the generation between PMIC5 and PMIC5 Gen3 ADC, + it can be considered like PMIC5 Gen2. properties: compatible: diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 078a6886f8b1..895645a1f58b 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -127,6 +127,7 @@ patternProperties: "^adc@[0-9a-f]+$": type: object oneOf: + - $ref: /schemas/iio/adc/qcom,spmi-adc5-gen3.yaml# - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml# - $ref: /schemas/iio/adc/qcom,spmi-rradc.yaml# - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml# -- 2.25.1