From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EA941E0DCB for ; Sun, 30 Nov 2025 15:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764517079; cv=none; b=boPpfbxV6GRMcN2kHV6ZRe82ObsS/HRq/FrHpGfivFiLi93Dc/TMHEVsc4zNDL1bwI5g/7vMILFb9cdSfEiMILjLaw9oV4ch+u3Z9TZ91fCygbq/plY3gti0QEw8VudkzqtXuUJlUK8s9kcMt4wmvoCfLSFtHdSfkWLw0yXu//Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764517079; c=relaxed/simple; bh=oDwSQ2DgZN5UPeFyVpapzafOE9JeM+6gEZ340+HFjeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a85yEOU1qpR0Fq6B3NMEBzS2fUkr6Y8ss8/zIljp53F8wzMbx6I3M/jANm2gRtcsjitTQW1ArWPNMmX+m7pnhMv4sjeDZ1gdSHGt4ZiN95EIjNu14wsMV2p3p2pYhKxRBS5XsEsQVK+Pmw1LrP2WIH492LKIIxbevRBsj1OMhjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AaaDrKoB; arc=none smtp.client-ip=209.85.216.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AaaDrKoB" Received: by mail-pj1-f67.google.com with SMTP id 98e67ed59e1d1-3436d6bdce8so3078899a91.3 for ; Sun, 30 Nov 2025 07:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764517077; x=1765121877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yUC4dObEfZpG4uC9TDLTiGB/YUFdpvHOo5IRraOFoc0=; b=AaaDrKoBBWXbYR+XJ45UhslK0Au/2xTcSPZHNVSVzmtE88ICKipBg783/xdXC0rZfK Rm7ATPEAr/UqhvRHA5HSQRz8Lld5L02iZ/VWUFnV6/g3wjextCMpAMz1Q/utszBlzuPC q6RP0dWOTsvztnGthzLOlZPR5xXieRAnep2SxWTe1lrSARYws+EIK6NqXb5jl3K6+GtT JKCzfIn+BuoZgdm9RZuWWstmL1gSgCaWaDMUEDo0cJiBwc3DBfjhp2Ohw+dt0HU7iKNd JzJHGKSKqkCB2LM1hq2cmvi2zBw1RRjykJASJm6sDip/tFdNMVHHuM0u2r0ZOVvjb7V6 54Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764517077; x=1765121877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yUC4dObEfZpG4uC9TDLTiGB/YUFdpvHOo5IRraOFoc0=; b=LDrfmxPV+PP3QBUCgCa+ekj7XDNW312oHILAO9ooAuJSLDTs1dd4npqW39HDS6UeFw syHhjOG+KrDDlc3YUqoqI0sB+oNd6568Ss2KQW6D0KaiIYk7S/mSf2zAwxgwjEdbEasL a0r7ig3XXhZqgBgoPxSlgBSYMbpTfghHY0XCKBfji/Mb+/wRIVIL9jvWhgMuyq3XcDaE ydp8nD7yQkZBEvsaxkeIzD2aESigvEitTujTyd3ZOkzTx2fBpIua6Z6HHR4Ij8Q9fMkl o01e7s4U9Vqep5OKbhtBRuhFPU4uNmLGcxJALXMXhvHaj18fwg3+GYkZsJlvYUOMRFMn ac6Q== X-Forwarded-Encrypted: i=1; AJvYcCUFrPomPU5Z6rCGFFEEd/qaifh8pgSPBUwkpYO1dbHN/4awLiYuIB4WGc4A4X6soM+qCZPkFBFfpfv+@vger.kernel.org X-Gm-Message-State: AOJu0Yy8256zgix6gwHO5XzZxWUl8wMbtCJyEHKfzKtPIkQ+uki4YcKu 0+b5B67Wx/wzYd82Ia72Ai7/zIlr8uXO2f5/KCLrtK2H2lVdy/bm2wKU X-Gm-Gg: ASbGncv4+ZBgODp/9fLQRDRwvZfumaDw3EIfOQTGDRyAiC2gfxIpM6LYTPgcDBkRPWk TalV0T/3fmpQ0Hp4gjllWag7TO9AvE3qlZm9W64dFleBQA1tiMPtzE+OUKbbZ3weh6qGbFh3YFw CrTu6TrmEr/1z79852KyQ8nRyiE65Oz2rR2nmmGtZMK7umhHZnxmBWmBzjTBny+ynvgOzgb0yBI EpXMFx/AKyFG1rw27i+6uFwAgGIyh6rhBtDsTdlIzcfsuB6k02wx/I2yAnGex3auLSwmu0pJ1SC dYgWAI8U04XpjOPBrHeuNah0tg5CZltMZocKQgeGcUNjAWBsTVsrOZgzatj5xus9ZRY/gtafzO2 rdEzXawm4uCJ86Ea/Zr3tEzpTwRfEmVkfppqQX4Y/3enlG46aV+rUnXG/VFMahu1zI77RpNGZ4G qEhNStnARvPl7DlQ== X-Google-Smtp-Source: AGHT+IGiDaRlSOUQ+fshNFNRIIqAzsM+JdRz2ezhxxJtsrcIPVcLKpE8DvHsW+OMEaI3itBEF++7dw== X-Received: by 2002:a17:90b:5588:b0:341:8b42:309e with SMTP id 98e67ed59e1d1-34733f3de19mr35626599a91.31.1764517077432; Sun, 30 Nov 2025 07:37:57 -0800 (PST) Received: from Ubuntu24.. ([103.187.64.30]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3475e952efbsm6903483a91.1.2025.11.30.07.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 07:37:56 -0800 (PST) From: Shrikant Raskar To: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, heiko@sntech.de, neil.armstrong@linaro.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shrikant Raskar Subject: [PATCH v2 3/4] iio: proximity: rfd77402: Move polling logic into helper Date: Sun, 30 Nov 2025 21:07:11 +0530 Message-ID: <20251130153712.6792-4-raskar.shree97@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251130153712.6792-1-raskar.shree97@gmail.com> References: <20251130153712.6792-1-raskar.shree97@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This change extracts the polling logic into a dedicated helper, rfd77402_result_polling(), which improves readability and keeps rfd77402_measure() focused on the high-level measurement flow. This refactoring is also a necessary preparation step for adding interrupt-based result handling in a follow-up patch. Signed-off-by: Shrikant Raskar --- drivers/iio/proximity/rfd77402.c | 35 +++++++++++++++++++------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/iio/proximity/rfd77402.c b/drivers/iio/proximity/rfd77402.c index 3262af6f6882..2152509816ca 100644 --- a/drivers/iio/proximity/rfd77402.c +++ b/drivers/iio/proximity/rfd77402.c @@ -110,11 +110,28 @@ static int rfd77402_set_state(struct i2c_client *client, u8 state, u16 check) return 0; } -static int rfd77402_measure(struct i2c_client *client) +static int rfd77402_result_polling(struct i2c_client *client) { int ret; int tries = 10; + while (tries-- > 0) { + ret = i2c_smbus_read_byte_data(client, RFD77402_ICSR); + if (ret < 0) + return ret; + + if (ret & RFD77402_ICSR_RESULT) + return 0; + + msleep(20); + } + + return -ETIMEDOUT; +} + +static int rfd77402_measure(struct i2c_client *client) +{ + int ret; ret = rfd77402_set_state(client, RFD77402_CMD_MCPU_ON, RFD77402_STATUS_MCPU_ON); if (ret < 0) @@ -125,20 +142,10 @@ static int rfd77402_measure(struct i2c_client *client) RFD77402_CMD_VALID); if (ret < 0) goto err; - - while (tries-- > 0) { - ret = i2c_smbus_read_byte_data(client, RFD77402_ICSR); - if (ret < 0) - goto err; - if (ret & RFD77402_ICSR_RESULT) - break; - msleep(20); - } - - if (tries < 0) { - ret = -ETIMEDOUT; + + ret = rfd77402_result_polling(client); + if (ret < 0) goto err; - } ret = i2c_smbus_read_word_data(client, RFD77402_RESULT_R); if (ret < 0) -- 2.43.0