From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39922DF13B for ; Wed, 3 Dec 2025 10:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764758996; cv=none; b=pOapz4SZrwczViJZBMbwySGqyhQyve/q/fE0apB3aZi1nQY7eFOJkv6GVG/BJftN2bI7ioai6AWdn+9bURFWUJQsqjd66aZn2iZHHpY/f93i1ObEsUmC2X9XlXCVmR9LF+EXwH4zQDrZfl6c89e+tbxts8pWfgtnDezdLXVqzcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764758996; c=relaxed/simple; bh=08St0W18syl6cb2kqTjkQ6nAwGEFRsXeSnAUw36rRPg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DAkiHBxKl6Xfp/OZug+s60SlWAiqNvtLX42D1r5IWofr4m1M1FCblJwTJ5py0I0+Kl6xqxZQrsc4gWGx5z0Z3hyWjqC40y4B31jQvtzyuHdBXJYIms0aC+OzJfBg6TenXHbIbvEyyhlEnLwe/4USsEA8JeWrg6V0nOHaumCzfh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=hllfMgf4; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="hllfMgf4" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id BA471C13576; Wed, 3 Dec 2025 10:49:28 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0978E60706; Wed, 3 Dec 2025 10:49:52 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C027F1192038B; Wed, 3 Dec 2025 11:49:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764758990; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=jNcvfrXTM72K7iRCwTM8Vuwyzk1BAcytFwMTCwmI/Pk=; b=hllfMgf41LGgmDZYl6QO0NRnJvOIjfX+mNuzo8QgpQrEwrB2A9KO7/RJj4AkUzIupWHYNo HYi2+VvYwCGLecBXkEz5IpHt+1LIiNYfZoQAj3dOMjHAqJZLeLyYP03afGA1cUx16BPTvT AoklCt8caGs70sUepUyJ7gXYLyqzpd10VWdlQt2VQD2nA+SZxWUvXtfPIxYcK7FrLOpAyY mTNLpu8sWcbP/i75ydb4xq3uHDZT4NmOpWoJvYhAHBubayfqzDjsuKk17wVUCIQr3UK3sB h2egsWZfnjQk9mniMD93fhWbXcE8XtKwTeVXG6pUicN31mOMt+Penxk8XcfPCQ== Date: Wed, 3 Dec 2025 11:49:41 +0100 From: Kory Maincent To: Swamil Jain Cc: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , "Bartosz Golaszewski" , Tony Lindgren , Andrzej Hajda , Neil Armstrong , "Robert Foss" , Laurent Pinchart , Jonas Karlman , "Jernej Skrabec" , Markus Schneider-Pargmann , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , , , , , Subject: Re: [PATCH 00/21] Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR Message-ID: <20251203114941.1fafd9dd@kmaincent-XPS-13-7390> In-Reply-To: <7b8e22d1-a872-4ea0-8fce-4323d2bf81ff@ti.com> References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> <7b8e22d1-a872-4ea0-8fce-4323d2bf81ff@ti.com> Organization: bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On Tue, 2 Dec 2025 17:55:15 +0530 Swamil Jain wrote: > Hi Kory, > Thanks for the series. >=20 > On 11/26/25 23:05, Kory Maincent (TI.com) wrote: > > The starting point for this work was adding support for the HDMI cape: > > https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html > > This will be sent in a later series. > >=20 > > Initially, Miguel proposed modifying the ite-it66121 bridge to support > > the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag: > > https://lore.kernel.org/lkml/20250909-it66121-fix-v1-1-bc79ca83df17@boo= tlin.com/ > > This patch was NAK'd as we don't want to add more legacy code. Maxime > > requested that the tilcdc driver be updated to use > > DRM_BRIDGE_ATTACH_NO_CONNECTOR instead. > >=20 > > While working on this update, I discovered that the tilcdc driver > > contained significant amounts of legacy code that needed cleaning. > > Since this driver was developed alongside the tda998x driver for > > several AM335x boards, the tda998x driver also required cleanup and > > support for the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. > >=20 > > This series is based on the tilcdc fix sent to mainline: > > https://lore.kernel.org/lkml/20251125090546.137193-1-kory.maincent@boot= lin.com/ > >=20 > > Patch 1-7: Convert tilcdc binding to YAML and remove the ti,tilcdc,panel > > sub-binding and driver > > Patch 8-16: Clean up tilcdc driver > > Patch 17-19: Clean up tda998x driver > > Patch 20: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support to tda998x > > Patch 21: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support to tilcdc > >=20 > > Signed-off-by: Kory Maincent (TI.com) > > --- > > Kory Maincent (TI.com) (21): > > dt-bindings: display: tilcdc: Convert to DT schema > > dt-bindings: display: tilcdc: Add fifo-threshold property > > drm/tilcdc: Remove simulate_vesa_sync flag > > drm/tilcdc: Add support for DRM bus flags and simplify panel con= fig > > ARM: dts: omap: Bind panel to panel-dpi instead of ti,tilcdc,pan= el > > driver dt-bindings: display: tilcdc: Remove panel binding > > drm/tilcdc: Remove tilcdc panel driver > > drm/tilcdc: Remove component framework support > > drm/tilcdc: Remove tilcdc_panel_info structure > > drm/tilcdc: Remove redundant #endif/#ifdef in debugfs code > > drm/tilcdc: Remove unused encoder and connector tracking arrays > > drm/tilcdc: Rename external_encoder and external_connector to > > encoder and connector drm/tilcdc: Rename tilcdc_external to tilcdc_enco= der > > drm/tilcdc: Remove the useless module list support > > drm/tilcdc: Modernize driver initialization and cleanup paths > > drm/tilcdc: Remove the use of drm_device private_data > > drm/bridge: tda998x: Remove component support > > drm/bridge: tda998x: Move tda998x_create/destroy into probe and > > remove drm/bridge: tda998x: Remove useless tda998x_connector_destroy wr= apper > > drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNEC= TOR > > drm/tilcdc: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR > >=20 > > .../devicetree/bindings/display/tilcdc/panel.txt | 66 --- > > .../devicetree/bindings/display/tilcdc/tilcdc.txt | 82 ---- > > .../devicetree/bindings/display/tilcdc/tilcdc.yaml | 103 +++++ > > arch/arm/boot/dts/ti/davinci/da850-evm.dts | 26 +- > > arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 25 +- > > arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 21 +- > > arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 22 +- > > arch/arm/boot/dts/ti/omap/am335x-sbc-t335.dts | 25 +- > > arch/arm/boot/dts/ti/omap/am335x-sl50.dts | 25 +- > > drivers/gpu/drm/bridge/tda998x_drv.c | 251 ++++++------ > > drivers/gpu/drm/tilcdc/Makefile | 3 +- > > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 117 ++---- > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 456 > > +++++++-------------- drivers/gpu/drm/tilcdc/tilcdc_drv.h = | > > 88 +--- drivers/gpu/drm/tilcdc/tilcdc_encoder.c | 93 +++++ > > .../tilcdc/{tilcdc_external.h =3D> tilcdc_encoder.h} | 5 +- > > drivers/gpu/drm/tilcdc/tilcdc_external.c | 179 -------- > > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 408 > > ------------------ drivers/gpu/drm/tilcdc/tilcdc_panel.h |= 15 > > - drivers/gpu/drm/tilcdc/tilcdc_plane.c | 2 +- > > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 8 +- > > 21 files changed, 589 insertions(+), 1431 deletions(-) > > --- > > base-commit: 670bacfc7579bdd79a3069cfb5ab60a6a7923003 =20 >=20 > I was trying to test the patches, unable to find the base-commit, are > you using drm-misc-next? It is based on the tilcdc fix as explained in the cover letter. https://lore.kernel.org/lkml/20251125090546.137193-1-kory.maincent@bootlin.= com/ Therefore you won't be able to find this base commit hash.=20 Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com