From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88AD376026 for ; Fri, 5 Dec 2025 20:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764966494; cv=none; b=hyM2yl9VUXIPgvWKGsIVeSFyEQZcIlx+ydrCZC4NxgYv82QXEuei6Q4XYHOuYlE1gZEYx9PZiIDQMlNZVjXktY5NGrpTyP6OOeHW/Z9D8bHIMDdpL0DOEH1sphfnB9U2mn2LCv3lM0YtulhKKHkFf7CpKTYMlWJf+ajt3EaQQqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764966494; c=relaxed/simple; bh=EVOhk1HI6FciASKyQp7+FOie/7X+cAATsS5lmRg1qfs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gbpkJur92LQ/trh5+9k2UmBpRa/0oaeKKw6gSBtOOw3yBukCKoACFdVgd/6uFz4wn3qkmB9+OkVeU1AyaM3fFdVk6BOL0jMe6YMlOX2SKdfIWLcqyfawk4dDIMyZArOOqhATVDPcgzbR3QL2qK0S5pC0yWS3eSIdITXEDau7kAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AEnGdXUV; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AEnGdXUV" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-297ef378069so22366765ad.3 for ; Fri, 05 Dec 2025 12:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764966492; x=1765571292; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SdEQYEeEhg+Pxb0AQxBFfKIUgC+j17YfvZoVKrA407E=; b=AEnGdXUVRhpew8isONlRzdg21vZAj8cfIOYo8LhLaevJJ7+LS5TEzepZUSFTEEK7WN 0bB3FXitKY9sNTVM2OtoBu+zYPx8uoYyQgJ1kDeXyy14u3URPM9m5S3p/8tr697LhRsE hbvMebovHNnMUZaIO7DPPhKMaBiGSpF5uUjiZrYnRBT5EAzU0rnrIr1+AsAhDskAmLdl BbTpPZpFQ1CvEuSU3h69ma/jsLIrSM0Ut9l09A+yreBlObFObbe7fDOCGrb9S1/a2cDH yxWyD3ZjOImlMgp+962SqXbCDnzoXHq0k3eaGWtxd4Yxekk3ZCPNHGS2A6ZBmfjr4rWN h70w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764966492; x=1765571292; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SdEQYEeEhg+Pxb0AQxBFfKIUgC+j17YfvZoVKrA407E=; b=Kmk6tcF72PnTl/joDr/r9JPI0WN3LmkPxDbIwvZJRqzxd9SwMzrT0p/aBaya4b5ZK5 sPR2ej69H159gTqAgKoCoFgHFhsmcES1Qo/jxLOlQTP4SB+cVPs8TdqkhxUIft8U2Onh VfSDCUdW6nCUMSAzr3WIGxZ4mag3V12PQBwLGm/TkuYOeGuOsGeDCfNMPxRnskLUF9gh bZjNYjoeImStRWCTV2d4mEzUdP3QFHSmSJGasXW2fZ3oPzWWjDu3cOrB5XWf0qaskNpk 8mbLKLx9vNQIpBPyFuHHRkniUn5c0ar2TOjUl4106PKrbrA/s82UrslMGAGDk1gnZwAQ TwXg== X-Forwarded-Encrypted: i=1; AJvYcCX4V1312tgPJn2dk/uTbnymLGVa2xn3hOmeJo1yH+FiTNFKPUHurfU4nxgOMSByC1EFkWvWWEsxyyLB@vger.kernel.org X-Gm-Message-State: AOJu0YzunA2tVEXH60vh1gZ1eoE9Tjx78hLrKXr+DbHj9UF1PBF+RrPI 6PM2xp8pQh13t0RI7J0MaP8Zos66hWli/+t5IETYe3c/6opAoJXfUhSF X-Gm-Gg: ASbGncu7CoktS2LVzodhCULJ2NW788HUJiMSURC0rZ7tZFZ6VUvs8P7tX8/+Vs/LEHj BAIjlnB8Hwoe1YeH4YlkwS0kylOJ/92dNCqEJ4BkjPFI77cR9naaKRHcBTRfZT6DGPmVWOyJDpx 0RM8MUfcxGxTdb97HJ5ZWeFbhoQZTQJvkUzVhdtT7wByug6ZV6SSvspymz3sqli3xSoEuUaxtCx Ug6XLEWx/FjQwVRvEj5/fkfP4A922CFyAZ7wfJRXzKLAMKG+bjBPHdFH5yAH1BvaRk9ynlLwebo NwN4Ldg1Q8MtfZxHGCzPICoKLQOTAPw/302ETmQcUmSUT/bM6VMOKXaY/st2JVkiNVbqLc7u7U5 bIOSnF3GK+0gbw2l+T2JDAJcqMuJhtA6g0meoL1fzMUy1y2Pc3wNj5x8KBqEEKS8xggWrBVf+tZ oF/0nwISBjK50qWs5Y9OCrASBasatNh3/nb1qSIDvZxV+VNaeGQvrke6qrFq/73HEAQSTK5eiW0 26e2ZgC187CxdObWPYjYS0zqa/sy+ZMuWEiaXaakH55pQYknW/ksFmcfceTawuLQeEWa6Pr X-Google-Smtp-Source: AGHT+IE7SZxJEEgg2GMHkTTXb7pxe8bAQ0ErqGaRLH8Fgf3Ui7YDuS3yTvPgzhY3cUjHgxCL6TCIsw== X-Received: by 2002:a17:903:3510:b0:298:3a2f:2333 with SMTP id d9443c01a7336-29df610f3eamr2230825ad.31.1764966491847; Fri, 05 Dec 2025 12:28:11 -0800 (PST) Received: from Lewboski.localdomain ([181.191.143.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae99fa59sm57256845ad.58.2025.12.05.12.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 12:28:11 -0800 (PST) From: Tomas Borquez To: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Tomas Borquez Subject: [RFC PATCH 0/3] ad9832: driver cleanup Date: Fri, 5 Dec 2025 17:27:40 -0300 Message-ID: <20251205202743.10530-1-tomasborquez13@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is a general cleanup of ad9832, with the purpose of graduating it from staging. The main changes are removing legacy platform_data support, converting to IIO channels with read/write_raw callbacks, and adding devicetree support. I'm sending this as an RFC because I have some concerns about the ABI design and would appreciate guidance before putting more time into this. Patch 1 removes the legacy platform_data support as suggested by Jonathan [1]. The driver now initializes to a safe state and lets userspace configure frequencies/phases via sysfs. Patch 2 converts frequency and phase configuration from custom sysfs attributes to proper IIO channels using read_raw/write_raw callbacks (This is the main area where I'd like feedback). Patch 3 adds devicetree bindings documentation. Design Concerns: 1) Channel Organization and ABI Break The device has 2 frequency registers and 4 phase registers. Since both frequency and phase must use IIO_ALTVOLTAGE since there's no better fit (as far as I know), I've organized channels as: out_altvoltage0_frequency (FREQ0) out_altvoltage1_frequency (FREQ1) out_altvoltage2_phase (PHASE0) out_altvoltage3_phase (PHASE1) out_altvoltage4_phase (PHASE2) out_altvoltage5_phase (PHASE3) The old ABI used out_altvoltage0_frequency0, out_altvoltage0_frequency1, out_altvoltage0_phase0, etc. The new approach felt cleaner but I'm open to alternatives and better ways of mapping them. Is this channel mapping reasonable, or would a different organization be preferred? And is the ABI break okay? 2) Scale Attributes The frequency scale is 1 Hz and phase scale is 2*PI/4096 radians. I cannot use info_mask_shared_by_type for IIO_CHAN_INFO_SCALE because all channels share IIO_ALTVOLTAGE. So instead I'm using IIO_CONST_ATTR for the scales: out_altvoltage_frequency_scale = "1" out_altvoltage_phase_scale = "0.0015339808" Is there a better approach here? Or should I just document the units and skip scale attributes entirely? 3) Remaining Custom Attributes Other controls remain as custom sysfs attributes: - out_altvoltage_frequencysymbol: select active frequency register - out_altvoltage_phasesymbol: select active phase register - out_altvoltage_pincontrol_en: hardware pin control enable - out_altvoltage_out_enable: output enable I'm not sure if these map cleanly to IIO interfaces. Should these be documented in ABI or is there a preferred way to handle them? 4) Implementation Notes - read_raw uses explicit address switching rather than channel index arithmetic for clarity, though phase values could alternatively be accessed via st->phase[chan->channel - 2] and directly in freq with st->freq[chan->channel]. - I'm unsure if mutex guards on cached reads are necessary. Link: https://lore.kernel.org/linux-iio/20250628161040.3d21e2c4@jic23-huawei/ [1] Signed-off-by: Tomas Borquez Tomas Borquez (3): staging: iio: ad9832: remove platform_data support staging: iio: ad9832: convert to iio channels dt-bindings: iio: add analog devices ad9832/ad9835 .../bindings/iio/frequency/adi,ad9832.yaml | 65 +++++ drivers/staging/iio/frequency/ad9832.c | 264 +++++++++++------- drivers/staging/iio/frequency/ad9832.h | 33 --- 3 files changed, 233 insertions(+), 129 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,ad9832.yaml delete mode 100644 drivers/staging/iio/frequency/ad9832.h -- 2.43.0