From: Jonathan Cameron <jic23@kernel.org>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk@kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Date: Sat, 6 Dec 2025 20:33:58 +0000 [thread overview]
Message-ID: <20251206203358.19e66133@jic23-huawei> (raw)
In-Reply-To: <20251204-honeywell_abp2_driver-v3-1-ad3275bad35e@subdimension.ro>
On Thu, 04 Dec 2025 17:12:55 +0200
Petre Rodan <petre.rodan@subdimension.ro> wrote:
> Adds binding for digital Honeywell ABP2 series pressure and temperature
> sensors.
> The i2c address is hardcoded and depends on the part number.
> There is an optional interrupt that signals the end of conversion.
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
Hi Petre,
One trivial thing that you might want to change if doing a v4 for other reasons.
> +
> + vdd-supply:
> + description: provide VDD power to the sensor.
Not worth a respin, but that description adds no real value over the name.
For simple supplies like this
vdd-supply: true
is fine.
next prev parent reply other threads:[~2025-12-06 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 15:12 [PATCH v3 0/2] iio: pressure: add Honeywell ABP2 driver Petre Rodan
2025-12-04 15:12 ` [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa Petre Rodan
2025-12-06 20:33 ` Jonathan Cameron [this message]
2025-12-04 15:12 ` [PATCH v3 2/2] iio: pressure: add Honeywell ABP2 driver Petre Rodan
2025-12-06 20:54 ` Jonathan Cameron
2025-12-06 21:50 ` Andy Shevchenko
2025-12-07 6:58 ` Petre Rodan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206203358.19e66133@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox