From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E7F22FB983 for ; Thu, 11 Dec 2025 09:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765446039; cv=none; b=Zi+Ceqycj2uQPz4SZHq7E4/TmIVBqPIWmTfGCmAklS6JwjOEbYkEzKpUS64tinceJLj8za5OXIrfnxP/sb3ZT6m+mpG+1bfgN77H5eS8GNxUjQHyCX2qLQXYqpaKge1xbNH8i9qYIQvlZiJEqF9+t8lq565CfeIoMRWKBdBH4bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765446039; c=relaxed/simple; bh=Ix9SgrqDz4o3q5W0m+YSAf0FGjexUuirXLqG6HMqDi4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mWqrzv9BCd6X1LjgWUmVESfON0ZJiI03AdpzSQ9E1g+hka6ZvfFBpvBDSPkkKdJq3saST9Ie5QBk239YwmsvVdeKNg5CW8IUV4nb1XQq+pYKpn/S+tWvnxzSe9Nf+HW6LfVpYTqnVTAIPJ3Y+LFmfGdqHOSdcclX1TwE4rF02qQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=N8BY+0RW; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="N8BY+0RW" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E15C8C19346; Thu, 11 Dec 2025 09:40:09 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DF0096068C; Thu, 11 Dec 2025 09:40:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 14F2B103C8D53; Thu, 11 Dec 2025 10:40:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765446032; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=WZVCcNfKSTt2Hd14gUawnCXPs39wl8U5m2GxT9YHICY=; b=N8BY+0RW1/KCWSmz1ejzT8wkU32hMHoROWuSW1FXKVX56lJPTLnrOG87aYRBJX3eLmwdQz ElonbiZKTB2yohpJE+9k8TDVw2t9dMGuu4ov3c9BVvflGTXLZViwe/G9lROCs1KMjA5Cg1 HqAOW3glYucmbg2jWQCfC+vmSqV0f3bRAfIGwFYLKzsrZIZn5PifwpK4SdhZWFCK8zSDep NJinbhnm5mFm/zI9m2xrgrfv6TFXNgAyWJZmSCZG+MROAk2te2haBPin+EoimEwAAmRl4c 665fBJnGyGTn7KpP/dBIwnBN6Ey1VxFEPONWoRQP8/KCoFPe22GeYDOR7es8FA== Date: Thu, 11 Dec 2025 10:40:24 +0100 From: Kory Maincent To: "Luca Ceresoli" Cc: "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Markus Schneider-Pargmann" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , Subject: Re: [PATCH 03/21] drm/tilcdc: Remove simulate_vesa_sync flag Message-ID: <20251211104024.1e7d5c42@kmaincent-XPS-13-7390> In-Reply-To: References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> <20251126-feature_tilcdc-v1-3-49b9ef2e3aa0@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On Wed, 10 Dec 2025 19:10:45 +0100 "Luca Ceresoli" wrote: > Hi K=C3=B6ry, >=20 > On Wed Nov 26, 2025 at 6:35 PM CET, Kory Maincent (TI.com) wrote: > > The tilcdc hardware does not generate VESA-compliant sync signals. It > > aligns the vertical sync (VS) on the second edge of the horizontal sync > > (HS) instead of the first edge. To compensate for this hardware > > behavior, the driver applies a timing adjustment in mode_fixup(). > > > > Previously, this adjustment was conditional based on the simulate_vesa_= sync > > flag, which was only set when using external encoders. This appears > > problematic because: > > > > 1. The timing adjustment seems needed for the hardware behavior regardl= ess > > of whether an external encoder is used > > 2. The external encoder infrastructure is driver-specific and being > > removed due to design issues > > 3. Boards using tilcdc without bridges (e.g., am335x-evm, am335x-evmsk) > > may not be getting the necessary timing adjustments > > > > Remove the simulate_vesa_sync flag and apply the VESA sync timing > > adjustment unconditionally, ensuring consistent behavior across all > > configurations. While it's unclear if the previous conditional behavior > > was causing actual issues, the unconditional adjustment better reflects > > the hardware's characteristics. > > > > Signed-off-by: Kory Maincent (TI.com) > > --- > > > > Only few board currently use tilcdc not associated to a bridge like the > > am335x_evm or the am335x-evmsk. =20 >=20 > Have you tested this change on any affected board? >=20 > The change looks good to me but without some testing it would be risky. I have tested it on few boards but not these mainline devicetree as I don't have them. I have tested a tilcdc with tda998x bridge (BeagleBone Black), a tilcdc with ti,tilcdc,panel panel (BeagleBone with LCD cape), a tilcdc with it66121 bri= dge (new Beagle Bone Green Eco board with HDMI cape). That's all the boards I have. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com