From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: media: i2c: et8ek8: document missing crc as optional property
Date: Wed, 17 Dec 2025 09:27:16 +0100 [thread overview]
Message-ID: <20251217-fast-ambrosial-angelfish-ee39d2@quoll> (raw)
In-Reply-To: <ddb6f986cb54e513ba508fa28fc9d2c8df0e2987.1765782992.git.alex.t.tran@gmail.com>
On Sun, Dec 14, 2025 at 11:58:33PM -0800, Alex Tran wrote:
> Convert the et8ek8 sensor device tree binding from TXT to YAML format.
Commit subject is completely wrong. You are not documenting missing
properties.
> Add the optional crc property to the endpoint node for the et8ek8 sensor.
Why?
> This property enables CRC checksums for the sensor bus and was added to
> match the new driver support for reading it from the device tree.
This does not explain me why.
I asked you first to convert the bindings, not add new properties. If
you add new properties, you must provide justification why binding has
to be changed - see other commits how to do this. Also please read
submitting patches how to split your work into logical chunks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-17 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 7:58 [PATCH v2 0/4] media: omap3isp/et8ek8: Add CCP2 CRC configuration support Alex Tran
2025-12-15 7:58 ` [PATCH v2 1/4] media: i2c: et8ek8: et8ek8_driver: add support for crc configuration via device tree Alex Tran
2025-12-17 8:28 ` Krzysztof Kozlowski
2025-12-15 7:58 ` [PATCH v2 2/4] dt-bindings: media: i2c: et8ek8: document missing crc as optional property Alex Tran
2025-12-17 8:27 ` Krzysztof Kozlowski [this message]
2025-12-18 23:50 ` Alex Tran
2025-12-15 7:58 ` [PATCH v2 3/4] media: platform: ti: omap3isp: isp: read crc configuration from device tree for CCP2 Alex Tran
2025-12-15 7:58 ` [PATCH v2 4/4] dt-bindings: media: omap3isp: document missing crc as optional property Alex Tran
2025-12-17 8:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217-fast-ambrosial-angelfish-ee39d2@quoll \
--to=krzk@kernel.org \
--cc=alex.t.tran@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox