From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D68A2EB874; Thu, 18 Dec 2025 06:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766039257; cv=none; b=X+YMtPiDB2Nez1ss5JRBujIvmnN6nvgATOdqY/fiXm6o7j8WjxEUWIQToLsd816uE1/5lVGqGpzjdoBuhiAi2ZyYtAjLsXJTz6222pnsmiWs7QIs5tEWffOSG4VTEjgxfvrdyklH9oQWq3mcckjm7t5j/nylMmkp4bNMMziQEH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766039257; c=relaxed/simple; bh=YhIlSeZO2iMUWTxjdXd1CpKLs4JM1e3VWgkxEUxp0vc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZJYybZrcoDFgG1f1HwmLsVLeqUEW3f3VHRz4agzh9UoaOx2B5DQu7OCOFwEr4KY3yLzkfia8d3ZvEj5GBEnEXdVUwrC3HyM6tte6tin2xYEVBi40gBFHzXhjM/lLOKXo6oaToKqo/Cw8OqqfIcZceEDkYXMkc4cCLvG2jQPLmS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=k/2Syp7F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="k/2Syp7F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65953C4CEFB; Thu, 18 Dec 2025 06:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1766039257; bh=YhIlSeZO2iMUWTxjdXd1CpKLs4JM1e3VWgkxEUxp0vc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k/2Syp7Fqq53yJmJnGnrgu9Dp+zKAbDVxVvr5TrRqj19dfUg685x1K+ITLg3BOaF1 3MGStfVKbldiBrrJtYGN5F2JQq1KCe08Kiv0D2zEZmek1pPkPfyoYmSVnMzFQpaVui bnTD76IbZE/EGEMwIOTUUILpho7ay+OzuItGtPGM= Date: Thu, 18 Dec 2025 07:27:33 +0100 From: Greg Kroah-Hartman To: Roy Luo Cc: Doug Anderson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?iso-8859-1?Q?Andr=E9?= Draszik , Tudor Ambarus , Thinh Nguyen , Philipp Zabel , Badhri Jagan Sridharan , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Joy Chakraborty , Naveen Kumar Subject: Re: [PATCH v9 2/2] usb: dwc3: Add Google Tensor SoC DWC3 glue driver Message-ID: <2025121847-swifter-pug-a1f7@gregkh> References: <20251205-controller-v9-0-9f158b18f979@google.com> <20251205-controller-v9-2-9f158b18f979@google.com> <2025120553-suffrage-divisive-5890@gregkh> <2025121728-reliably-crabgrass-2601@gregkh> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 17, 2025 at 05:34:37PM -0800, Roy Luo wrote: > On Wed, Dec 17, 2025 at 12:14 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Dec 17, 2025 at 11:18 AM Roy Luo wrote: > > > > > > On Wed, Dec 17, 2025 at 5:24 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Thu, Dec 04, 2025 at 11:14:39PM -0800, Roy Luo wrote: > > > > > On Thu, Dec 4, 2025 at 10:05 PM Greg Kroah-Hartman > > > > > wrote: > > > > > > > > > > > > On Fri, Dec 05, 2025 at 02:26:38AM +0000, Roy Luo wrote: > > > > > > > +config USB_DWC3_GOOGLE > > > > > > > + tristate "Google Platform" > > > > > > > + depends on ARCH_GOOGLE || COMPILE_TEST > > > > > > > > > > > > There is no ARCH_GOOGLE in the tree now, so how is this supposed to > > > > > > work? Shouldn't tools that check for "invalid config options" trigger > > > > > > on this? > > > > > > > > > > > > thanks, > > > > > > > > > > > > greg k-h > > > > > > > > > > Hi Greg, > > > > > > > > > > The menuconfig looks like the following and it doesn't complain: > > > > > | Symbol: ARCH_GOOGLE [=ARCH_GOOGLE] > > > > > | Type : unknown > > > > > | > > > > > | Symbol: PHY_GOOGLE_USB [=y] > > > > > | Type : tristate > > > > > | Defined at drivers/phy/Kconfig:104 > > > > > | Prompt: Google Tensor SoC USB PHY driver > > > > > | Depends on: ARCH_GOOGLE || COMPILE_TEST [=y] > > > > > > > > > > According to Kconfig documentation [1], the unknown symbol > > > > > would simply be evaluated as an "n", which is what we want. > > > > > "Convert the symbol into an expression. Boolean and tristate > > > > > symbols are simply converted into the respective expression > > > > > values. All other symbol types result in ‘n’." > > > > > > > > > > In a different Kconfig documentation, an environment variable > > > > > "KCONFIG_WARN_UNKNOWN_SYMBOLS" is there to detect > > > > > undefined symbols in the "config input", but I can't find one that > > > > > catches undefined symbols in the Kconfig tree itself. > > > > > > > > > > That is, the tool seems to allow this. > > > > > However, if this turns out to be a major problem. I think we > > > > > can either: > > > > > - Remove ARCH_GOOGLE and leave COMPILE_TEST as > > > > > the only dependency. Then add ARCH_GOOGLE back > > > > > later once it's in the tree. > > > > > > > > Please do this. I do not want to take patches that purposfully add > > > > dependencies on config options that might, or might not, appear in the > > > > future. Please just remove all of the dependancies for now, as they are > > > > not needed, right? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Greg, > > > > > > Yes, we can remove ARCH_GOOGLE for now. > > > To clarify, we're not removing all of the dependencies, we still want > > > to keep COMPILE_TEST for build tests, right? > > > Please let me know if you think otherwise. > > > > I think you'd just remove all of them. Normally COMPILE_TEST just > > allows folks to compile stuff even when they don't want the ARCH. We > > can can add ARCH_GOOGLE back in later once the config exists. > > > > -Doug > > Doug, > > Thanks for chiming in. I'm hesitant to remove COMPILE_TEST > because Greg specifically requested its inclusion in v7 [1]. > Also it seems beneficial to get some build coverage before > ARCH_GOOGLE is officially added to the tree. > Greg, could you clarify? I wanted it in because it would not build without it on a non "google" system. But now, as that option isn't there, just don't have any dependency, as it's obviously not needed. thanks, greg k-h