public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: toshiba: Use recommended node names
@ 2025-12-16 18:00 Rob Herring (Arm)
  2025-12-17  2:13 ` nobuhiro.iwamatsu.x90
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-12-16 18:00 UTC (permalink / raw)
  To: soc, Nobuhiro Iwamatsu, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, devicetree, linux-kernel

Update Toshiba TMPV7708 node name to the recommended standard node
names. Generally, node names and paths aren't considered ABI, so it
is safe to change them.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
SoC maintainers, Please take this directly.

 arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts      | 2 +-
 arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts  | 2 +-
 arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi | 2 +-
 arch/arm64/boot/dts/toshiba/tmpv7708.dtsi             | 4 ++--
 arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi        | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
index d209fdc98597..8d099b237025 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
@@ -43,7 +43,7 @@ &piether {
 	phy-handle = <&phy0>;
 	phy-mode = "rgmii-id";
 
-	mdio0 {
+	mdio {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "snps,dwmac-mdio";
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
index ed7aa7e457b1..4439b3e8acbb 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
@@ -43,7 +43,7 @@ &piether {
 	phy-handle = <&phy0>;
 	phy-mode = "rgmii-id";
 
-	mdio0 {
+	mdio {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "snps,dwmac-mdio";
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
index 0c8321022a73..af406f7285c4 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
@@ -26,7 +26,7 @@ &spi0_pins {
 &spi0 {
 	status = "okay";
 
-	mmc-slot@0 {
+	mmc@0 {
 		compatible = "mmc-spi-slot";
 		reg = <0>;
 		gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
index 9aa7b1872bd6..88e38d6efcaa 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
@@ -161,7 +161,7 @@ gic: interrupt-controller@24001000 {
 			      <0 0x24006000 0 0x2000>;
 		};
 
-		pmux: pmux@24190000 {
+		pmux: pinctrl@24190000 {
 			compatible = "toshiba,tmpv7708-pinctrl";
 			reg = <0 0x24190000 0 0x10000>;
 		};
@@ -463,7 +463,7 @@ piether: ethernet@28000000 {
 			status = "disabled";
 		};
 
-		wdt: wdt@28330000 {
+		wdt: watchdog@28330000 {
 			compatible = "toshiba,visconti-wdt";
 			reg = <0 0x28330000 0 0x1000>;
 			clocks = <&pismu TMPV770X_CLK_WDTCLK>;
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
index a480c6ba5f5d..5ea835fe08a8 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
@@ -91,7 +91,7 @@ i2c8_pins: i2c8-pins {
 		bias-pull-up;
 	};
 
-	pwm_mux: pwm_mux {
+	pwm_mux: pwm-pins {
 		function = "pwm";
 	};
 
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: toshiba: Use recommended node names
  2025-12-16 18:00 [PATCH] arm64: dts: toshiba: Use recommended node names Rob Herring (Arm)
@ 2025-12-17  2:13 ` nobuhiro.iwamatsu.x90
  2025-12-22 10:01 ` Krzysztof Kozlowski
  2025-12-22 10:02 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: nobuhiro.iwamatsu.x90 @ 2025-12-17  2:13 UTC (permalink / raw)
  To: robh, soc, krzk+dt, conor+dt; +Cc: linux-arm-kernel, devicetree, linux-kernel

Hi Rob,

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: Wednesday, December 17, 2025 3:01 AM
> To: soc@kernel.org; iwamatsu nobuhiro(岩松 信洋 □DITC○CPT)
> <nobuhiro.iwamatsu.x90@mail.toshiba>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] arm64: dts: toshiba: Use recommended node names
> 
> Update Toshiba TMPV7708 node name to the recommended standard node
> names. Generally, node names and paths aren't considered ABI, so it is safe to
> change them.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Best regards,
  Nobuhiro
> ---
> SoC maintainers, Please take this directly.
> 
>  arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts      | 2 +-
>  arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts  | 2 +-
> arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi | 2 +-
>  arch/arm64/boot/dts/toshiba/tmpv7708.dtsi             | 4 ++--
>  arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi        | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> index d209fdc98597..8d099b237025 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> @@ -43,7 +43,7 @@ &piether {
>  	phy-handle = <&phy0>;
>  	phy-mode = "rgmii-id";
> 
> -	mdio0 {
> +	mdio {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		compatible = "snps,dwmac-mdio";
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
> b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
> index ed7aa7e457b1..4439b3e8acbb 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrb.dts
> @@ -43,7 +43,7 @@ &piether {
>  	phy-handle = <&phy0>;
>  	phy-mode = "rgmii-id";
> 
> -	mdio0 {
> +	mdio {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		compatible = "snps,dwmac-mdio";
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
> b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
> index 0c8321022a73..af406f7285c4 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708-visrobo-vrc.dtsi
> @@ -26,7 +26,7 @@ &spi0_pins {
>  &spi0 {
>  	status = "okay";
> 
> -	mmc-slot@0 {
> +	mmc@0 {
>  		compatible = "mmc-spi-slot";
>  		reg = <0>;
>  		gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> index 9aa7b1872bd6..88e38d6efcaa 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> @@ -161,7 +161,7 @@ gic: interrupt-controller@24001000 {
>  			      <0 0x24006000 0 0x2000>;
>  		};
> 
> -		pmux: pmux@24190000 {
> +		pmux: pinctrl@24190000 {
>  			compatible = "toshiba,tmpv7708-pinctrl";
>  			reg = <0 0x24190000 0 0x10000>;
>  		};
> @@ -463,7 +463,7 @@ piether: ethernet@28000000 {
>  			status = "disabled";
>  		};
> 
> -		wdt: wdt@28330000 {
> +		wdt: watchdog@28330000 {
>  			compatible = "toshiba,visconti-wdt";
>  			reg = <0 0x28330000 0 0x1000>;
>  			clocks = <&pismu TMPV770X_CLK_WDTCLK>; diff
> --git a/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> b/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> index a480c6ba5f5d..5ea835fe08a8 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> @@ -91,7 +91,7 @@ i2c8_pins: i2c8-pins {
>  		bias-pull-up;
>  	};
> 
> -	pwm_mux: pwm_mux {
> +	pwm_mux: pwm-pins {
>  		function = "pwm";
>  	};
> 
> --
> 2.51.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: toshiba: Use recommended node names
  2025-12-16 18:00 [PATCH] arm64: dts: toshiba: Use recommended node names Rob Herring (Arm)
  2025-12-17  2:13 ` nobuhiro.iwamatsu.x90
@ 2025-12-22 10:01 ` Krzysztof Kozlowski
  2025-12-22 10:02 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-22 10:01 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: soc, Nobuhiro Iwamatsu, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

On Tue, Dec 16, 2025 at 12:00:54PM -0600, Rob Herring (Arm) wrote:
> Update Toshiba TMPV7708 node name to the recommended standard node
> names. Generally, node names and paths aren't considered ABI, so it
> is safe to change them.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> SoC maintainers, Please take this directly.

Applied, rebased on top of my earlier fixes.

I took all your patches to my DTS cleanup branch, not to soc tree,
because that way I can combine with my other fixes. I'll send them to
soc tree soon.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: toshiba: Use recommended node names
  2025-12-16 18:00 [PATCH] arm64: dts: toshiba: Use recommended node names Rob Herring (Arm)
  2025-12-17  2:13 ` nobuhiro.iwamatsu.x90
  2025-12-22 10:01 ` Krzysztof Kozlowski
@ 2025-12-22 10:02 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-22 10:02 UTC (permalink / raw)
  To: soc, Nobuhiro Iwamatsu, Krzysztof Kozlowski, Conor Dooley,
	Rob Herring (Arm)
  Cc: linux-arm-kernel, devicetree, linux-kernel


On Tue, 16 Dec 2025 12:00:54 -0600, Rob Herring (Arm) wrote:
> Update Toshiba TMPV7708 node name to the recommended standard node
> names. Generally, node names and paths aren't considered ABI, so it
> is safe to change them.
> 
> 

Applied, thanks!

[1/1] arm64: dts: toshiba: Use recommended node names
      https://git.kernel.org/krzk/linux-dt/c/22fbe6e21450d629642e4bdc8d8d329219abeb46

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-22 10:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-16 18:00 [PATCH] arm64: dts: toshiba: Use recommended node names Rob Herring (Arm)
2025-12-17  2:13 ` nobuhiro.iwamatsu.x90
2025-12-22 10:01 ` Krzysztof Kozlowski
2025-12-22 10:02 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox