Re: [PATCH 1/3] dt-bindings: mmc: spacemit,sdhci: add reset support

Krzysztof Kozlowski
2025-12-22T08:16:42Z

On 22/12/2025 03:12, Yixun Lan wrote:
>>> required:
>>> - compatible
>>> - reg
>>> - interrupts
>>> - clocks
>>> - clock-names
>>> + - resets
>>> + - reset-names
>>
>> This is an ABI break without mentioning in commit msg and without any
>> justification.
>>
> Indeed, this will introduce a breakage when combining new kernel + old dtb
>
> Since in current case, the eMMC works fine without reset line operation,
> I then would make this property optional (drop it from 'required' section)
> and switch to use devm_reset_control_get_optional_xx() API in driver code
>
> Does this looks good to you?
>

Yes

Best regards,
Krzysztof